The entire package uses legacy Python macros, consider not doing that and benefiting from the automation described in https://docs.fedoraproject.org/en-US/packaging-guidelines/Python/ -- I am happy to help answer questions. Using the new macros would prevent situations like bz2090769.


Summary: Zope Hookable Objects
Name: python-zope-hookable

The order here is quite unusual. What is the motivation?




Source0: https://pypi.io/packages/source/z/%{modname}/%{modname}-%{version}.tar.gz

Consider using %{pypi_source %{modname}} instead: https://docs.fedoraproject.org/en-US/packaging-guidelines/Python_201x/#_source_files_from_pypi
The number of the source is also redundant.




URL: https://pypi.io/project/zope.hookable

Consider using https://github.com/zopefoundation/zope.hookable which is what upstream lists as their homepage




%package -n python3-zope-hookable
Summary: Zope Hookable Objects

The summary is repeated here for no good reason. You seem to define %{modname} not to repeat a string that is not much longer than literal %{modname}, yet you copy-paste the summary instead of using %{summary} here. The same goes with description but that is a tad trickier to reuse, see: https://docs.fedoraproject.org/en-US/packaging-guidelines/Python_201x/#_example_python_spec_file





%{?python_provide:%python_provide python3-zope-hookable}

This is deprecated and SHOULD NOT be used. It is also not needed: See the note below https://docs.fedoraproject.org/en-US/packaging-guidelines/Python_201x/#_the_py_provides_macro



Requires: python3-zope-component
Requires: python3-zope-interface
Requires: python3-zope-event

This is not needed and MUST NOT be used. See https://docs.fedoraproject.org/en-US/packaging-guidelines/Python_201x/#_automatically_generated_dependencies and https://docs.fedoraproject.org/en-US/packaging-guidelines/#_package_dependencies



rm -rf %{modname}.egg-info

This is not needed. There is no .egg-info in the source tarball. And even if it was, it would not be required to be removed.





# build Sphinx documents
COPYRIGHT=`grep Author: PKG-INFO |sed -e 's/Author: //'`
cat >docs/conf.py <<END
templates_path = ['_templates']
source_suffix = '.rst'
master_doc = 'index'
project = '%{modname}'
copyright = '$COPYRIGHT'
version = '%{version}'
release = '%{version}'
pygments_style = 'sphinx'
html_static_path = ['_static']
extensions = []
END

This is very confusing. Why is it needed?




%exclude %{python3_sitearch}/zope/hookable/*.txt

Why is this excluded?

> Requires: python3-zope-component
> Requires: python3-zope-interface
> Requires: python3-zope-event
> 
> This is not needed and MUST NOT be used. See https://docs.fedoraproject.org/en-US/packaging-guidelines/Python_201x/#_automatically_generated_dependencies and https://docs.fedoraproject.org/en-US/packaging-guidelines/#_package_dependencies

Correction. I assumed those would be autogenerated, but they are not, because upstream does not seem to list those as dependencies at all. Where does this list come from?




From the build.log:

********************************************************************************
WARNING:
        An optional code optimization (C extension) could not be compiled.
        Optimizations for this package will not be available!
command 'gcc' failed: No such file or directory
********************************************************************************


Consider making this arched and BuildRequiring gcc to make the package faster.






There are also tests in the tarball but no %check section in the specfile.

this review is stalled and a response is needed soon

https://docs.fedoraproject.org/en-US/fesco/Package_review_policy/#stalled

This review is stalled :(

https://docs.fedoraproject.org/en-US/fesco/Package_review_policy/#stalled

I am going to work on this again.

jonathanspw is going to submit this package.