Spec URL: https://fale.fedorapeople.org/nebula/nebula.spec SRPM URL: https://fale.fedorapeople.org/nebula/nebula-1.5.2-1.fc36.src.rpm COPR Build (with review): https://copr.fedorainfracloud.org/coprs/fale/nebula/build/4456036/ Description: A scalable overlay networking tool with a focus on performance, simplicity and security Fedora Account System Username: fale
- You're installing a systemd service but spec is missing systemd scriplets. Check https://docs.fedoraproject.org/en-US/packaging-guidelines/Scriptlets/#_systemd - RPM build warnings: File listed twice: /usr/share/doc/nebula/README.md File listed twice: /usr/share/doc/golang-github-slackhq-nebula-devel/README.md I think that removing `cert/README.md` from %doc would do the trick - The service file will check for /etc/nebula/config.yml config file, but it's missing. You can use the example file nebula-1.5.2/examples/config.yml for example. You can check jdoss' spec file, lines 88 and 114: https://copr-dist-git.fedorainfracloud.org/cgit/jdoss/nebula/nebula.git/tree/nebula.spec - Maybe you want to add a `Fedora` string to the Build version, something like %{version}-Fedora. Check line jdoss' line 77 or doctl's spec to see how to export LDFLAGS.
Thanks a lot Mikel :-) Spec URL: https://fale.fedorapeople.org/nebula/nebula.spec SRPM URL: https://fale.fedorapeople.org/nebula/nebula-1.5.2-1.fc36.src.rpm COPR Build (with review): https://copr.fedorainfracloud.org/coprs/fale/nebula/build/4456861/
Much better now! I'll approve the package review, but there is one extra thing you may want to check and another issue(?) you'll need to solve: - All the content from examples is being installed, not sure if the Vagrant and init files make sense to be installed. If you think that's required, I'll suggest to create a doc subpackage, otherwise a rm of those folders or not including `examples` at all are other options. - A package called nebula existed in the past for Fedora, not sure how to deal with it. fedora-review is correct: - The specfile is sane - License is correct - Builds successfully in mock - No rpmlint errors - %check section passes - The latest version is packaged - The package complies with the Packaging Guidelines Package approved! On import, don't forget to do the following: - Add package to release-monitoring.org - Add package to Koschei. - Give go-sig privileges on package - Close the review bug by referencing it in the rpm changelog and/or the Bodhi ticket. (rhbz#BUG_ID) Thanks!
Thanks Mikel :-). 1. I'll drop the example folder before checking it in. 2. I've spoken with xvitaly and tomhughes in #fedora-devel and they confirmed that is ok with the only caveat of adding a "Conflicts: nebula < 1.0" so that there is no update and conflict risk with it. Thanks, Fale
Awesome Fabio, thanks for checking! If it is not document it could be good to note it somewhere.
FEDORA-2022-562852f1f7 has been submitted as an update to Fedora 37. https://bodhi.fedoraproject.org/updates/FEDORA-2022-562852f1f7
FEDORA-2022-562852f1f7 has been pushed to the Fedora 37 stable repository. If problem still persists, please make note of it in this bug report.
FEDORA-2022-b7d68aee70 has been submitted as an update to Fedora 36. https://bodhi.fedoraproject.org/updates/FEDORA-2022-b7d68aee70
FEDORA-2022-b7d68aee70 has been pushed to the Fedora 36 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --advisory=FEDORA-2022-b7d68aee70 \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2022-b7d68aee70 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
FEDORA-2022-b7d68aee70 has been pushed to the Fedora 36 stable repository. If problem still persists, please make note of it in this bug report.