Note: This bug is displayed in read-only format because the product is no longer active in Red Hat Bugzilla.

Bug 2091544

Summary: "Pending changes - Boot Order" cannot be dismissed after editing VM from CLI
Product: OpenShift Container Platform Reporter: Felix Matouschek <fmatouschek>
Component: Console Kubevirt PluginAssignee: Yaacov Zamir <yzamir>
Status: CLOSED NEXTRELEASE QA Contact: Guohua Ouyang <gouyang>
Severity: low Docs Contact:
Priority: low    
Version: 4.10CC: cnv-qe-bugs, gouyang, yzamir
Target Milestone: ---   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2022-06-02 11:37:07 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Attachments:
Description Flags
YAML of the VM
none
YAML of the VMI
none
Screenshot of the Pending Changes box none

Description Felix Matouschek 2022-05-30 09:48:18 UTC
Description of problem:

In the 'Virtual Machine' view the 'Pending changes - Boot Order' box above the VM details cannot be dismissed after editing a VM from CLI.

Version-Release number of selected component (if applicable):

4.10.12

How reproducible:

Always

Steps to Reproduce:
1. Create VM from wizard (do not start it)
2. Make sure VM has no explicit boot order (i.a. remove "bootOrder" keys from disks in UI YAML view) 
3. Add new disk and volume with 'oc edit'
4. Start the VM

Actual results:

'Pending changes - Boot Order' box does appear and cannot be dismissed. Clicking 'Save and Restart' has no effect, the box appears again.

Expected results:

'Pending changes - Boot Order' box does either not appear at all or at least it can be dismissed.

Additional info:

The disk/volume I added was a cdrom and a sysprep volume.

I noticed that the definition of the cdrom in the VMI has two additional attributes ('readonly: true' and 'tray: closed').

Comment 1 Felix Matouschek 2022-05-30 09:48:58 UTC
Created attachment 1885020 [details]
YAML of the VM

Comment 2 Felix Matouschek 2022-05-30 09:49:16 UTC
Created attachment 1885023 [details]
YAML of the VMI

Comment 3 Felix Matouschek 2022-05-30 09:50:16 UTC
Created attachment 1885024 [details]
Screenshot of the Pending Changes box

Comment 4 Guohua Ouyang 2022-06-01 05:12:38 UTC
I could reproduce the issue on 4.10.15, but not on the 4.11 new UI.
This should not be a blocker bug for 4.10.z, I'm intending to close it with resolution "NextRelease".

@Felix @Yaccov, what do you think?

Comment 5 Felix Matouschek 2022-06-02 09:53:14 UTC
I don't think it's that big of an issue. If it's already fixed, would a backport of the fix be trivial?

Comment 6 Guohua Ouyang 2022-06-02 10:11:13 UTC
There is no a fix yet, the 4.11 new UI has been rewritten so the problem does not show.

Comment 7 Yaacov Zamir 2022-06-02 11:29:55 UTC
(In reply to Guohua Ouyang from comment #4)
> I could reproduce the issue on 4.10.15, but not on the 4.11 new UI.
> This should not be a blocker bug for 4.10.z, I'm intending to close it with
> resolution "NextRelease".
> 
> @Felix @Yaccov, what do you think?

sure, if it's fixed on 4.11 we can close

Comment 8 Yaacov Zamir 2022-06-02 11:34:02 UTC
(In reply to Felix Matouschek from comment #5)
> I don't think it's that big of an issue. If it's already fixed, would a
> backport of the fix be trivial?

4.11 is a we-write so we don't know what is the bug on 4.10,
if we want to fix in 4.10 we will need to move the bug to the 4.10 component.

a - I'll move it to 4.10
b - we will close it in 4.10 if we find that it's not a trivial fix

Comment 9 Guohua Ouyang 2022-06-02 11:37:07 UTC
close the bug unless we have a strong reason to fix it for 4.10.z, thanks.

Comment 10 Felix Matouschek 2022-06-02 11:38:30 UTC
If it's fixed in 4.11 I'm fine with that. Thanks.