Created attachment 1885491 [details] Units Description of problem: Mi/Gi/Ti is shown instead of MiB/GiB/TiB Version-Release number of selected component (if applicable): How reproducible: always Steps to Reproduce: 1. Open or create VM 2. Open Disks tab and click "Add Disk" button 3. Actual results: units dropdown shows Mi/Gi/Ti Expected results: MiB/GiB/TiB Additional info: the value in div is wrong, so the typo is probably in BE
Hi Leon Thank you for this bug, since in the YAML file itself we insert the units with the 'B' at the end (Mi,Gi,Ti) we should consult with PM if this makes sense that the user will see MiB, GiB and TiB while the string in the YAML will stay as required by the backend (Mi, Gi, Ti) adding @rsdeor to discussion
Aviv, Storage unit are either MB/GB/TB or MiB/GiB/TiB and this is used throughout the industry and we should use those units. We should ask storage why they are using non standard units names
From what we have now, I can see a mixed approach among the console sections. In k8s there is no mention of MiB/GiB/TiB quantity but only Mi/Gi/Ti (International System standard): https://kubernetes.io/docs/reference/kubernetes-api/common-definitions/quantity/
Ugo, You are correct that the quantity should use Mi/Gi/Ti (mebi, gibi, tebi), but to this you need to add the unit you are using (Byte, in storage case)), so this becomes MiB/GiB/TiB. You can see it in the "Examples and comparisons with SI prefixes" table in the same link (https://kubernetes.io/docs/reference/kubernetes-api/common-definitions/quantity/)
Okay right. To be consistent among all the virtualization section pages/modals we should fix the units in: - Disk Modal - Disk List in wizard / Disk List in virtual machine / Disk list in virtual machine instance - Customize Form - Edit Boot Source Modal These items have some logic in common so one fix can solve this issue in multiple items. Should we create a different bug to solve all of them or is it acceptable to use this bug?
great work, verified on OCP-v4.11.0-47
Since the problem described in this bug report should be resolved in a recent advisory, it has been closed with a resolution of ERRATA. For information on the advisory (Important: OpenShift Virtualization 4.11.0 Images security and bug fix update), and where to find the updated files, follow the link below. If the solution does not work for you, open a new bug report. https://access.redhat.com/errata/RHSA-2022:6526