Bug 2091973 - Package review : rust-opentelemetry : rust implementation of OpenTelemetry
Summary: Package review : rust-opentelemetry : rust implementation of OpenTelemetry
Keywords:
Status: CLOSED WONTFIX
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Petr Menšík
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: 2091981
TreeView+ depends on / blocked
 
Reported: 2022-05-31 12:41 UTC by JB Trystram
Modified: 2023-05-03 13:08 UTC (History)
3 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2023-05-03 06:43:10 UTC
Type: Bug
Embargoed:
pemensik: fedora-review+


Attachments (Terms of Use)

Description JB Trystram 2022-05-31 12:41:51 UTC
Spec : https://gitlab.com/jbtrystram/fedora-review-requests/-/raw/main/rust-opentelemetry/rust-opentelemetry.spec

SRPM : https://gitlab.com/jbtrystram/fedora-review-requests/-/raw/main/rust-opentelemetry/rust-opentelemetry-0.17.0-1.fc37.src.rpm?inline=false


Description: OpenTelemetry is a collection of tools, APIs, and SDKs used to instrument, generate, collect, and export telemetry data (metrics, logs, and traces) for analysis in order to understand your software's performance and behavior

Homepage: https://crates.io/crates/opentelemetry
Fedora user : jbtrystram

Koji build : https://koji.fedoraproject.org/koji/taskinfo?taskID=87730514

Comment 1 Petr Menšík 2022-06-29 09:37:28 UTC
Package Review
==============

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed


Issues:
=======
- Package does not contain duplicates in %files.
  Note: warning: File listed twice:
  /usr/share/cargo/registry/opentelemetry-0.17.0/CHANGELOG.md
  See: https://docs.fedoraproject.org/en-US/packaging-
  guidelines/#_duplicate_files


===== MUST items =====

Generic:
[x]: Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
     Guidelines.
[x]: License field in the package spec file matches the actual license.
     Note: Checking patched sources after %prep for licenses. Licenses
     found: "Unknown or generated", "*No copyright* Apache License 2.0",
     "*No copyright* W3C License". 93 files have unknown license. Detailed
     output of licensecheck in /home/pihhan/fedora/review/2091973-rust-
     opentelemetry/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[x]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
     names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[x]: If the package is a rename of another package, proper Obsoletes and
     Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
     one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
     Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
     license(s) in its own file, then that file, containing the text of the
     license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Permissions on files are set properly.
[x]: Package must not depend on deprecated() packages.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
     work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
     provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
     %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Large documentation must go in a -doc subpackage. Large could be size
     (~1MB) or number of files.
     Note: Documentation size is 0 bytes in 0 files.
[x]: Packages must not store files under /srv, /opt or /usr/local

===== SHOULD items =====

Generic:
[-]: If the source package does not include license text(s) as a separate
     file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Fully versioned dependency in subpackages if applicable.
     Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in rust-
     opentelemetry-devel , rust-opentelemetry+default-devel , rust-
     opentelemetry+async-std-devel , rust-opentelemetry+async-trait-devel ,
     rust-opentelemetry+crossbeam-channel-devel , rust-
     opentelemetry+dashmap-devel , rust-opentelemetry+fnv-devel , rust-
     opentelemetry+metrics-devel , rust-opentelemetry+percent-encoding-
     devel , rust-opentelemetry+pin-project-devel , rust-
     opentelemetry+rand-devel , rust-opentelemetry+rt-async-std-devel ,
     rust-opentelemetry+rt-tokio-devel , rust-opentelemetry+rt-tokio-
     current-thread-devel , rust-opentelemetry+serde-devel , rust-
     opentelemetry+serialize-devel , rust-opentelemetry+testing-devel ,
     rust-opentelemetry+tokio-devel , rust-opentelemetry+tokio-stream-devel
     , rust-opentelemetry+trace-devel
        Note: enforced by crate(opentelemetry) = %{version} require
[?]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[-]: Sources are verified with gpgverify first in %prep if upstream
     publishes signatures.
     Note: gpgverify is not used. Release is not signed.
[!]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed
     files.
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
     $RPM_BUILD_ROOT)
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: SourceX is a working URL.
[x]: Package should compile and build into binary rpms on all supported
     architectures.
[x]: Spec use %global instead of %define unless justified.

===== EXTRA items =====

Generic:
[!]: Spec file according to URL is the same as in SRPM.
     Note: Spec file as given by url is not the same as in SRPM (see
     attached diff).
     See: (this test has no URL)
[x]: Rpmlint is run on all installed packages.
     Note: There are rpmlint messages (see attachment).


Rpmlint
-------
Cannot parse rpmlint output:


Rpmlint (installed packages)
----------------------------
Cannot parse rpmlint output:


Source checksums
----------------
https://crates.io/api/v1/crates/opentelemetry/0.17.0/download#/opentelemetry-0.17.0.crate :
  CHECKSUM(SHA256) this package     : 6105e89802af13fdf48c49d7646d3b533a70e536d818aae7e78ba0433d01acb8
  CHECKSUM(SHA256) upstream package : 6105e89802af13fdf48c49d7646d3b533a70e536d818aae7e78ba0433d01acb8


Requires
--------
rust-opentelemetry-devel (rpmlib, GLIBC filtered):
    (crate(futures-channel/default) >= 0.3.0 with crate(futures-channel/default) < 0.4.0~)
    (crate(futures-executor/default) >= 0.3.0 with crate(futures-executor/default) < 0.4.0~)
    (crate(futures-util/sink) >= 0.3.0 with crate(futures-util/sink) < 0.4.0~)
    (crate(futures-util/std) >= 0.3.0 with crate(futures-util/std) < 0.4.0~)
    (crate(js-sys/default) >= 0.3.0 with crate(js-sys/default) < 0.4.0~)
    (crate(lazy_static/default) >= 1.4.0 with crate(lazy_static/default) < 2.0.0~)
    (crate(thiserror/default) >= 1.0.0 with crate(thiserror/default) < 2.0.0~)
    cargo

rust-opentelemetry+default-devel (rpmlib, GLIBC filtered):
    cargo
    crate(opentelemetry)
    crate(opentelemetry/trace)

rust-opentelemetry+async-std-devel (rpmlib, GLIBC filtered):
    (crate(async-std/default) >= 1.6.0 with crate(async-std/default) < 2.0.0~)
    (crate(async-std/unstable) >= 1.6.0 with crate(async-std/unstable) < 2.0.0~)
    cargo
    crate(opentelemetry)

rust-opentelemetry+async-trait-devel (rpmlib, GLIBC filtered):
    (crate(async-trait/default) >= 0.1.0 with crate(async-trait/default) < 0.2.0~)
    cargo
    crate(opentelemetry)

rust-opentelemetry+crossbeam-channel-devel (rpmlib, GLIBC filtered):
    (crate(crossbeam-channel/default) >= 0.5.0 with crate(crossbeam-channel/default) < 0.6.0~)
    cargo
    crate(opentelemetry)

rust-opentelemetry+dashmap-devel (rpmlib, GLIBC filtered):
    (crate(dashmap/default) >= 4.0.1 with crate(dashmap/default) < 5.0.0~)
    cargo
    crate(opentelemetry)

rust-opentelemetry+fnv-devel (rpmlib, GLIBC filtered):
    (crate(fnv/default) >= 1.0.0 with crate(fnv/default) < 2.0.0~)
    cargo
    crate(opentelemetry)

rust-opentelemetry+metrics-devel (rpmlib, GLIBC filtered):
    cargo
    crate(opentelemetry)
    crate(opentelemetry/dashmap)
    crate(opentelemetry/fnv)

rust-opentelemetry+percent-encoding-devel (rpmlib, GLIBC filtered):
    (crate(percent-encoding/default) >= 2.0.0 with crate(percent-encoding/default) < 3.0.0~)
    cargo
    crate(opentelemetry)

rust-opentelemetry+pin-project-devel (rpmlib, GLIBC filtered):
    (crate(pin-project/default) >= 1.0.2 with crate(pin-project/default) < 2.0.0~)
    cargo
    crate(opentelemetry)

rust-opentelemetry+rand-devel (rpmlib, GLIBC filtered):
    (crate(rand/std) >= 0.8.0 with crate(rand/std) < 0.9.0~)
    (crate(rand/std_rng) >= 0.8.0 with crate(rand/std_rng) < 0.9.0~)
    cargo
    crate(opentelemetry)

rust-opentelemetry+rt-async-std-devel (rpmlib, GLIBC filtered):
    cargo
    crate(opentelemetry)
    crate(opentelemetry/async-std)

rust-opentelemetry+rt-tokio-devel (rpmlib, GLIBC filtered):
    cargo
    crate(opentelemetry)
    crate(opentelemetry/tokio)
    crate(opentelemetry/tokio-stream)

rust-opentelemetry+rt-tokio-current-thread-devel (rpmlib, GLIBC filtered):
    cargo
    crate(opentelemetry)
    crate(opentelemetry/tokio)
    crate(opentelemetry/tokio-stream)

rust-opentelemetry+serde-devel (rpmlib, GLIBC filtered):
    (crate(serde/default) >= 1.0.0 with crate(serde/default) < 2.0.0~)
    (crate(serde/derive) >= 1.0.0 with crate(serde/derive) < 2.0.0~)
    (crate(serde/rc) >= 1.0.0 with crate(serde/rc) < 2.0.0~)
    cargo
    crate(opentelemetry)

rust-opentelemetry+serialize-devel (rpmlib, GLIBC filtered):
    cargo
    crate(opentelemetry)
    crate(opentelemetry/serde)

rust-opentelemetry+testing-devel (rpmlib, GLIBC filtered):
    (crate(tokio/macros) >= 1.0.0 with crate(tokio/macros) < 2.0.0~)
    (crate(tokio/rt-multi-thread) >= 1.0.0 with crate(tokio/rt-multi-thread) < 2.0.0~)
    cargo
    crate(opentelemetry)
    crate(opentelemetry/metrics)
    crate(opentelemetry/rt-async-std)
    crate(opentelemetry/rt-tokio)
    crate(opentelemetry/rt-tokio-current-thread)
    crate(opentelemetry/trace)

rust-opentelemetry+tokio-devel (rpmlib, GLIBC filtered):
    (crate(tokio/rt) >= 1.0.0 with crate(tokio/rt) < 2.0.0~)
    (crate(tokio/time) >= 1.0.0 with crate(tokio/time) < 2.0.0~)
    cargo
    crate(opentelemetry)

rust-opentelemetry+tokio-stream-devel (rpmlib, GLIBC filtered):
    (crate(tokio-stream/default) >= 0.1.0 with crate(tokio-stream/default) < 0.2.0~)
    cargo
    crate(opentelemetry)

rust-opentelemetry+trace-devel (rpmlib, GLIBC filtered):
    cargo
    crate(opentelemetry)
    crate(opentelemetry/async-trait)
    crate(opentelemetry/crossbeam-channel)
    crate(opentelemetry/percent-encoding)
    crate(opentelemetry/pin-project)
    crate(opentelemetry/rand)



Provides
--------
rust-opentelemetry-devel:
    crate(opentelemetry)
    rust-opentelemetry-devel

rust-opentelemetry+default-devel:
    crate(opentelemetry/default)
    rust-opentelemetry+default-devel

rust-opentelemetry+async-std-devel:
    crate(opentelemetry/async-std)
    rust-opentelemetry+async-std-devel

rust-opentelemetry+async-trait-devel:
    crate(opentelemetry/async-trait)
    rust-opentelemetry+async-trait-devel

rust-opentelemetry+crossbeam-channel-devel:
    crate(opentelemetry/crossbeam-channel)
    rust-opentelemetry+crossbeam-channel-devel

rust-opentelemetry+dashmap-devel:
    crate(opentelemetry/dashmap)
    rust-opentelemetry+dashmap-devel

rust-opentelemetry+fnv-devel:
    crate(opentelemetry/fnv)
    rust-opentelemetry+fnv-devel

rust-opentelemetry+metrics-devel:
    crate(opentelemetry/metrics)
    rust-opentelemetry+metrics-devel

rust-opentelemetry+percent-encoding-devel:
    crate(opentelemetry/percent-encoding)
    rust-opentelemetry+percent-encoding-devel

rust-opentelemetry+pin-project-devel:
    crate(opentelemetry/pin-project)
    rust-opentelemetry+pin-project-devel

rust-opentelemetry+rand-devel:
    crate(opentelemetry/rand)
    rust-opentelemetry+rand-devel

rust-opentelemetry+rt-async-std-devel:
    crate(opentelemetry/rt-async-std)
    rust-opentelemetry+rt-async-std-devel

rust-opentelemetry+rt-tokio-devel:
    crate(opentelemetry/rt-tokio)
    rust-opentelemetry+rt-tokio-devel

rust-opentelemetry+rt-tokio-current-thread-devel:
    crate(opentelemetry/rt-tokio-current-thread)
    rust-opentelemetry+rt-tokio-current-thread-devel

rust-opentelemetry+serde-devel:
    crate(opentelemetry/serde)
    rust-opentelemetry+serde-devel

rust-opentelemetry+serialize-devel:
    crate(opentelemetry/serialize)
    rust-opentelemetry+serialize-devel

rust-opentelemetry+testing-devel:
    crate(opentelemetry/testing)
    rust-opentelemetry+testing-devel

rust-opentelemetry+tokio-devel:
    crate(opentelemetry/tokio)
    rust-opentelemetry+tokio-devel

rust-opentelemetry+tokio-stream-devel:
    crate(opentelemetry/tokio-stream)
    rust-opentelemetry+tokio-stream-devel

rust-opentelemetry+trace-devel:
    crate(opentelemetry/trace)
    rust-opentelemetry+trace-devel



Diff spec file in url and in SRPM
---------------------------------
--- /home/pihhan/fedora/review/2091973-rust-opentelemetry/srpm/rust-opentelemetry.spec	2022-06-26 12:10:39.905404500 +0200
+++ /home/pihhan/fedora/review/2091973-rust-opentelemetry/srpm-unpacked/rust-opentelemetry.spec	2022-05-31 11:11:39.000000000 +0200
@@ -1,2 +1,11 @@
+## START: Set by rpmautospec
+## (rpmautospec version 0.2.6)
+%define autorelease(e:s:pb:) %{?-p:0.}%{lua:
+    release_number = 1;
+    base_release_number = tonumber(rpm.expand("%{?-b*}%{!?-b:1}"));
+    print(release_number + base_release_number - 1);
+}%{?-e:.%{-e*}}%{?-s:.%{-s*}}%{?dist}
+## END: Set by rpmautospec
+
 # Generated by rust2rpm 21
 %bcond_without check
@@ -281,3 +290,4 @@
 
 %changelog
-%autochangelog
+* Tue May 31 2022 John Doe <packager> 0.17.0-1
+- Uncommitted changes


Generated by fedora-review 0.8.0 (e988316) last change: 2022-04-07
Command line :/usr/bin/fedora-review -b 2091973
Buildroot used: fedora-rawhide-x86_64
Active plugins: Generic, Shell-api
Disabled plugins: Java, R, Haskell, fonts, Ocaml, C/C++, Python, SugarActivity, PHP, Perl
Disabled flags: EPEL6, EPEL7, DISTTAG, BATCH, EXARCH

Comment 2 Petr Menšík 2022-06-29 09:41:37 UTC
I just expect this requires also rust-opentelemetry as a base package. Linking the bugs.

Comment 3 Fabio Valentini 2023-05-02 21:44:30 UTC
If you are still interested in this package, the fedora-review+ flag is almost certainly expired and will need to be refreshed.


Note You need to log in before you can comment on or make changes to this bug.