Bug 2092637 - Review Request: python-google-cloud-pubsub - Google Cloud Pub/Sub API client library
Summary: Review Request: python-google-cloud-pubsub - Google Cloud Pub/Sub API client ...
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Ben Beasley
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2022-06-01 21:45 UTC by Major Hayden 🤠
Modified: 2022-06-24 00:58 UTC (History)
3 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2022-06-15 19:54:01 UTC
Type: ---
Embargoed:
code: fedora-review+


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Fedora Pagure releng/fedora-scm-requests issue 44921 0 None Closed [RHEL7/Leapp/Bug] package adobe-mappings-cmap available in rhel7 and rhel8 seen as high risk 2022-06-27 12:04:21 UTC

Description Major Hayden 🤠 2022-06-01 21:45:18 UTC
Spec URL: https://mhayden.fedorapeople.org/python-google-cloud-pubsub.spec
SRPM URL: https://mhayden.fedorapeople.org/python-google-cloud-pubsub-2.12.1-1.fc36.src.rpm
Description: Google Cloud Pub/Sub API client library
Fedora Account System Username: mhayden

Comment 1 Benson Muite 2022-06-02 07:03:07 UTC
Unofficial Review

Package Review
==============

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed



===== MUST items =====

Generic:
[x]: Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
     Guidelines.
[x]: License field in the package spec file matches the actual license.
     Note: Checking patched sources after %prep for licenses. Licenses
     found: "Unknown or generated", "Apache License 2.0", "*No copyright*
     Apache License 2.0", "*No copyright* [generated file]", "Apache
     License 2.0 [generated file]". 96 files have unknown license. Detailed
     output of licensecheck in
     /home/benson/Projects/FedoraPackaging/python-google-cloud-
     pubsub/2092637-python-google-cloud-pubsub/licensecheck.txt
[?]: Package does not own files or directories owned by other packages.
     Note: Dirs in package are owned also by: /usr/lib/python3.10/site-
     packages/google(python3-google-cloud-access-approval, python3-google-
     cloud-bigquery-reservation, python3-google-cloud-bigquery-
     datatransfer, python3-google-cloud-data-fusion, python3-google-cloud-
     core, python3-google-cloud-debugger-client, python3-google-cloud-
     datacatalog, python3-google-cloud-kms, python3-google-cloud-redis,
     python3-google-api-core, python3-google-cloud-api-gateway,
     python3-google-cloud-appengine-admin, python3-googleapis-common-
     protos, python3-google-cloud-source-context, python3-google-cloud-dlp,
     python3-google-cloud-functions, python3-google-cloud-firestore,
     python3-google-cloud-dataproc-metastore, python3-google-cloud-common,
     python3-google-cloud-deploy, python3-google-cloud-apigee-connect,
     python3-google-cloud-container, python3-google-cloud-dns,
     python3-google-cloud-iam, python3-google-cloud-automl, python3-google-
     cloud-dataproc, python3-google-cloud-dms, python3-google-cloud-
     storage, python3-google-cloud-bigquery-storage, python3-grpc-google-
     iam-v1, python3-google-cloud-asset, python3-google-cloud-billing,
     python3-google-cloud-os-config, python3-protobuf, python3-google-
     cloud-spanner, python3-google-cloud-domains, python3-google-cloud-
     bigquery, python3-google-cloud-private-ca, python3-google-cloud-
     billing-budgets, python3-google-cloud-containeranalysis,
     python3-google-cloud-bigquery-connection, python3-google-cloud-
     bigtable, python3-google-cloud-build, python3-google-resumable-media,
     python3-google-cloud-shell, python3-google-cloud-filestore,
     python3-google-cloud-access-context-manager, python3-google-cloud-org-
     policy), /usr/lib/python3.10/site-
     packages/google/cloud(python3-google-cloud-access-approval,
     python3-google-cloud-bigquery-reservation, python3-google-cloud-
     bigquery-datatransfer, python3-google-cloud-data-fusion,
     python3-google-cloud-core, python3-google-cloud-debugger-client,
     python3-google-cloud-datacatalog, python3-google-cloud-kms,
     python3-google-cloud-redis, python3-google-cloud-api-gateway,
     python3-google-cloud-appengine-admin, python3-googleapis-common-
     protos, python3-google-cloud-source-context, python3-google-cloud-dlp,
     python3-google-cloud-functions, python3-google-cloud-firestore,
     python3-google-cloud-dataproc-metastore, python3-google-cloud-common,
     python3-google-cloud-deploy, python3-google-cloud-apigee-connect,
     python3-google-cloud-container, python3-google-cloud-dns,
     python3-google-cloud-iam, python3-google-cloud-automl, python3-google-
     cloud-dataproc, python3-google-cloud-dms, python3-google-cloud-
     storage, python3-google-cloud-bigquery-storage, python3-google-cloud-
     asset, python3-google-cloud-billing, python3-google-cloud-os-config,
     python3-google-cloud-spanner, python3-google-cloud-domains,
     python3-google-cloud-bigquery, python3-google-cloud-private-ca,
     python3-google-cloud-billing-budgets, python3-google-cloud-
     containeranalysis, python3-google-cloud-bigquery-connection,
     python3-google-cloud-bigtable, python3-google-cloud-build,
     python3-google-cloud-shell, python3-google-cloud-filestore,
     python3-google-cloud-org-policy)
[x]: Package contains no bundled libraries without FPC exception.
[?]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
     names).
[x]: Package is named according to the Package Naming Guidelines.
[?]: Package does not generate any conflict.
[?]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
     Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[?]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
     (~1MB) or number of files.
     Note: Documentation size is 81920 bytes in 4 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
     one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
     Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
     license(s) in its own file, then that file, containing the text of the
     license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package must not depend on deprecated() packages.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
     work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
     provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
     %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

Python:
[x]: Python eggs must not download any dependencies during the build
     process.
[x]: A package which is used by another package via an egg interface should
     provide egg info.
[x]: Package meets the Packaging Guidelines::Python
[x]: Package contains BR: python2-devel or python3-devel
[x]: Packages MUST NOT have dependencies (either build-time or runtime) on
     packages named with the unversioned python- prefix unless no properly
     versioned package exists. Dependencies on Python packages instead MUST
     use names beginning with python2- or python3- as appropriate.
[x]: Python packages must not contain %{pythonX_site(lib|arch)}/* in %files
[x]: Binary eggs must be removed in %prep

===== SHOULD items =====

Generic:
[-]: If the source package does not include license text(s) as a separate
     file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[?]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[-]: Sources are verified with gpgverify first in %prep if upstream
     publishes signatures.
     Note: gpgverify is not used.
[?]: Package should compile and build into binary rpms on all supported
     architectures.
[?]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed
     files.
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
     $RPM_BUILD_ROOT)
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: SourceX is a working URL.
[x]: Spec use %global instead of %define unless justified.

===== EXTRA items =====

Generic:
[x]: Rpmlint is run on all installed packages.
     Note: There are rpmlint messages (see attachment).
[x]: Spec file according to URL is the same as in SRPM.


Rpmlint
-------
Cannot parse rpmlint output:


Rpmlint (installed packages)
----------------------------
Cannot parse rpmlint output:


Source checksums
----------------
https://github.com/googleapis/python-pubsub/archive/v2.12.1/python-pubsub-2.12.1.tar.gz :
  CHECKSUM(SHA256) this package     : 59a5b7276f7256ec647039b83025fc62c2428acce1608677fcf932db7cb69634
  CHECKSUM(SHA256) upstream package : 59a5b7276f7256ec647039b83025fc62c2428acce1608677fcf932db7cb69634


Requires
--------
python3-google-cloud-pubsub (rpmlib, GLIBC filtered):
    ((python3.10dist(google-api-core) < 2.1~~ or python3.10dist(google-api-core) >= 2.2) with (python3.10dist(google-api-core) < 2.2~~ or python3.10dist(google-api-core) >= 2.3) with (python3.10dist(google-api-core) < 2.3 or python3.10dist(google-api-core) > 2.3) with (python3.10dist(google-api-core) < 2~~ or python3.10dist(google-api-core) >= 2.1) with python3.10dist(google-api-core) < 3~~dev0 with python3.10dist(google-api-core) >= 1.31.5)
    ((python3.10dist(google-api-core[grpc]) < 2.1~~ or python3.10dist(google-api-core[grpc]) >= 2.2) with (python3.10dist(google-api-core[grpc]) < 2.2~~ or python3.10dist(google-api-core[grpc]) >= 2.3) with (python3.10dist(google-api-core[grpc]) < 2.3 or python3.10dist(google-api-core[grpc]) > 2.3) with (python3.10dist(google-api-core[grpc]) < 2~~ or python3.10dist(google-api-core[grpc]) >= 2.1) with python3.10dist(google-api-core[grpc]) < 3~~dev0 with python3.10dist(google-api-core[grpc]) >= 1.31.5)
    (python3.10dist(grpc-google-iam-v1) < 0.13~~dev0 with python3.10dist(grpc-google-iam-v1) >= 0.12.3)
    (python3.10dist(grpcio) < 2~~dev0 with python3.10dist(grpcio) >= 1.38.1)
    python(abi)
    python3.10dist(grpcio-status)
    python3.10dist(proto-plus)



Provides
--------
python3-google-cloud-pubsub:
    python-google-cloud-pubsub
    python3-google-cloud-pubsub
    python3.10-google-cloud-pubsub
    python3.10dist(google-cloud-pubsub)
    python3dist(google-cloud-pubsub)



Generated by fedora-review 0.8.0 (e988316) last change: 2022-04-07
Command line :/usr/bin/fedora-review -b 2092637
Buildroot used: fedora-rawhide-x86_64
Active plugins: Python, Generic, Shell-api
Disabled plugins: Perl, fonts, Ocaml, Haskell, SugarActivity, R, C/C++, PHP, Java
Disabled flags: EPEL6, EPEL7, DISTTAG, BATCH, EXARCH

FURTHER COMMENTS
1) Can
rm -f %{buildroot}%{_bindir}/fixup*.py
be replaced by
rm -f %{buildroot}%{_bindir}/fixup_pubsub_v1_keywords.py
to indicate the specific file being removed
2) A copr build would be helpful to verify it works on more architectures
3) Is libcst needed for extras?
4) Seems not compatible with Fedora 35: 
https://github.com/googleapis/python-pubsub/blob/main/setup.py#L36
https://packages.fedoraproject.org/pkgs/python-google-api-core/python3-google-api-core/
5) There is more documentation at https://github.com/googleapis/python-pubsub/tree/main/docs which is also online at https://cloud.google.com/python/docs/reference/pubsub/latest though the README provides basic information, so this need not be packaged.

Comment 2 Major Hayden 🤠 2022-06-02 12:50:51 UTC
(In reply to Benson Muite from comment #1)
> FURTHER COMMENTS
> 1) Can
> rm -f %{buildroot}%{_bindir}/fixup*.py
> be replaced by
> rm -f %{buildroot}%{_bindir}/fixup_pubsub_v1_keywords.py
> to indicate the specific file being removed

Fixed that. I had copied that over from another spec while I was testing this one.

> 2) A copr build would be helpful to verify it works on more architectures

Done! https://copr.fedorainfracloud.org/coprs/mhayden/python-google-cloud/build/4490687/

> 3) Is libcst needed for extras?

Fixed.

> 4) Seems not compatible with Fedora 35: 
> https://github.com/googleapis/python-pubsub/blob/main/setup.py#L36
> https://packages.fedoraproject.org/pkgs/python-google-api-core/python3-
> google-api-core/

Yes, there's an ongoing issue in F35 right now that has something to do with protobuf, proto-plus, or iam-v1. I've been talking to the folks in #fedora-python to hunt that down.

> 5) There is more documentation at
> https://github.com/googleapis/python-pubsub/tree/main/docs which is also
> online at https://cloud.google.com/python/docs/reference/pubsub/latest
> though the README provides basic information, so this need not be packaged.

I was packaging the docs previously for these google cloud packages, but then I ended up in some challenging situations with sphinx trying to refer to other bits of documentation that it couldn't reach during an RPM build.

SRPM URL: https://download.copr.fedorainfracloud.org/results/mhayden/python-google-cloud/fedora-rawhide-x86_64/04490687-python-google-cloud-pubsub/python-google-cloud-pubsub-2.12.1-1.fc37.src.rpm
Spec URL: https://download.copr.fedorainfracloud.org/results/mhayden/python-google-cloud/fedora-rawhide-x86_64/04490687-python-google-cloud-pubsub/python-google-cloud-pubsub.spec

Comment 3 Benson Muite 2022-06-04 10:52:09 UTC
Works with the tutorial at https://cloud.google.com/pubsub/docs/building-pubsub-messaging-system

Minor comments:

1) Google Cloud CLI https://cloud.google.com/python/docs/setup is needed to be able to use this package, and it is unclear if this can be packaged.

2) Can the explanation for the testing workaround be expanded further? https://docs.fedoraproject.org/en-US/packaging-guidelines/Python/#_tests
Also why the option --disable-warnings tests/unit (it seems needed on many similar packages) ?

Comment 4 Benson Muite 2022-06-07 17:37:20 UTC
Checking the spec file again, %license LICENSE seems to be missing.

Comment 5 Ben Beasley 2022-06-11 15:10:23 UTC
(In reply to Major Hayden 🤠 from comment #2)
> I was packaging the docs previously for these google cloud packages, but
> then I ended up in some challenging situations with sphinx trying to refer
> to other bits of documentation that it couldn't reach during an RPM build.

If you wanted to package the documentation, you would need to ask sphinx for PDF output instead of HTML (see bug 2006555 and the linked packaging mailing list discussion). Then you could do something like:

> # Drop intersphinx mappings, since we can’t download remote inventories and
> # can’t easily produce working hyperlinks from inventories in local
> # documentation packages.
> echo 'intersphinx_mapping.clear()' >> docs/conf.py

to stop it from complaining about intersphinx mappings. See https://src.fedoraproject.org/rpms/python-aiosignal/ for an example, and let me know if you want a PR to enable documentation on any of these packages.

However, packaging generated documentation is *not* required, and in many cases may not be worth the trouble.

Comment 6 Ben Beasley 2022-06-11 15:12:10 UTC
(In reply to Benson Muite from comment #4)
> Checking the spec file again, %license LICENSE seems to be missing.

This is handled by %pyproject_save_files in many cases, including this one. See https://docs.fedoraproject.org/en-US/packaging-guidelines/Python/#_build_macros, and verify with:

> $ rpm -qL -p results/python3-google-cloud-pubsub-2.12.1-1.fc37.noarch.rpm
> /usr/lib/python3.10/site-packages/google_cloud_pubsub-2.12.1.dist-info/LICENSE

Comment 7 Ben Beasley 2022-06-11 16:03:22 UTC
(In reply to Benson Muite from comment #3)
> 2) Can the explanation for the testing workaround be expanded further?
> https://docs.fedoraproject.org/en-US/packaging-guidelines/Python/#_tests
> Also why the option --disable-warnings tests/unit (it seems needed on many
> similar packages) ?

From a quick test, it looks like --disable-warnings is not needed. I suspect it was copy-pasted from a package that treated warnings as errors by default via pytest.ini/setup.cfg.

Comment 8 Ben Beasley 2022-06-11 16:07:44 UTC
Package APPROVED, with my gratitude to Benson Muite for the preliminary review.

Please consider the suggestions in the “Issues” section, below.

Package Review
==============

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated

===== Issues =====

- Version 2.13.0 is available (released 5 days ago).

  https://github.com/googleapis/python-pubsub/releases/tag/v2.13.0

  If dependent packages are compatible, please consider upgrading. It looks
  like no packaging changes will be required.

- Please consider dropping the “--disable-warnings” option to pytest, since it
  does not seem to be required here and could potentially obscure useful
  diagnostics.

===== MUST items =====

Generic:
[x]: Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
     Guidelines.
[x]: License field in the package spec file matches the actual license.
     Note: Checking patched sources after %prep for licenses. Licenses
     found: "Unknown or generated", "Apache License 2.0", "*No copyright*
     Apache License 2.0", "*No copyright* [generated file]", "Apache
     License 2.0 [generated file]". 96 files have unknown license. Detailed
     output of licensecheck in /home/reviewer/2092637-python-google-cloud-
     pubsub/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.

     $ rpm -qL -p results/python3-google-cloud-pubsub-2.12.1-1.fc37.noarch.rpm 
     /usr/lib/python3.10/site-packages/google_cloud_pubsub-2.12.1.dist-info/LICENSE
     $ rpm -q --requires -p results/python3-google-cloud-pubsub+libcst-2.12.1-1.fc37.noarch.rpm 
     python(abi) = 3.10
     python3-google-cloud-pubsub = 2.12.1-1.fc37
     […]

[-]: Package does not own files or directories owned by other packages.
     Note: Dirs in package are owned also by: /usr/lib/python3.10/site-
     packages/google(python3-google-cloud-os-config, python3-google-cloud-
     redis, python3-google-cloud-automl, python3-google-cloud-container,
     python3-google-cloud-shell, python3-google-cloud-dms, python3-google-
     api-core, python3-google-cloud-debugger-client, python3-google-cloud-
     iam, python3-google-resumable-media, python3-google-cloud-billing-
     budgets, python3-google-cloud-domains, python3-google-cloud-common,
     python3-google-cloud-storage, python3-google-cloud-dataproc,
     python3-google-cloud-dns, python3-google-cloud-firestore,
     python3-google-cloud-datacatalog, python3-google-cloud-org-policy,
     python3-google-cloud-kms, python3-google-cloud-functions,
     python3-google-cloud-billing, python3-google-cloud-appengine-admin,
     python3-google-cloud-bigtable, python3-googleapis-common-protos,
     python3-google-cloud-dlp, python3-google-cloud-api-gateway,
     python3-google-cloud-data-fusion, python3-google-cloud-bigquery,
     python3-google-cloud-bigquery-datatransfer, python3-google-cloud-
     access-context-manager, python3-google-cloud-dataproc-metastore,
     python3-google-cloud-private-ca, python3-google-cloud-apigee-connect,
     python3-google-cloud-bigquery-storage, python3-grpc-google-iam-v1,
     python3-google-cloud-asset, python3-google-cloud-bigquery-reservation,
     python3-google-cloud-build, python3-google-cloud-access-approval,
     python3-google-cloud-core, python3-google-cloud-deploy,
     python3-google-cloud-containeranalysis, python3-protobuf,
     python3-google-cloud-source-context, python3-google-cloud-filestore,
     python3-google-cloud-bigquery-connection, python3-google-cloud-
     spanner), /usr/lib/python3.10/site-
     packages/google/cloud(python3-google-cloud-os-config, python3-google-
     cloud-redis, python3-google-cloud-automl, python3-google-cloud-
     container, python3-google-cloud-shell, python3-google-cloud-dms,
     python3-google-cloud-debugger-client, python3-google-cloud-iam,
     python3-google-cloud-billing-budgets, python3-google-cloud-domains,
     python3-google-cloud-common, python3-google-cloud-storage,
     python3-google-cloud-dataproc, python3-google-cloud-dns,
     python3-google-cloud-firestore, python3-google-cloud-datacatalog,
     python3-google-cloud-org-policy, python3-google-cloud-kms,
     python3-google-cloud-functions, python3-google-cloud-billing,
     python3-google-cloud-appengine-admin, python3-google-cloud-bigtable,
     python3-googleapis-common-protos, python3-google-cloud-dlp,
     python3-google-cloud-api-gateway, python3-google-cloud-data-fusion,
     python3-google-cloud-bigquery, python3-google-cloud-bigquery-
     datatransfer, python3-google-cloud-dataproc-metastore, python3-google-
     cloud-private-ca, python3-google-cloud-apigee-connect, python3-google-
     cloud-bigquery-storage, python3-google-cloud-asset, python3-google-
     cloud-bigquery-reservation, python3-google-cloud-build,
     python3-google-cloud-access-approval, python3-google-cloud-core,
     python3-google-cloud-deploy, python3-google-cloud-containeranalysis,
     python3-google-cloud-source-context, python3-google-cloud-filestore,
     python3-google-cloud-bigquery-connection, python3-google-cloud-
     spanner)

     Appropriate co-ownership of Python namespace package directories.

[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
     names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
     Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
     (~1MB) or number of files.
     Note: Documentation size is 81920 bytes in 4 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
     one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
     Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
     license(s) in its own file, then that file, containing the text of the
     license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package must not depend on deprecated() packages.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
     work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
     provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
     %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

Python:
[x]: Python eggs must not download any dependencies during the build
     process.
[x]: A package which is used by another package via an egg interface should
     provide egg info.
[x]: Package meets the Packaging Guidelines::Python
[x]: Package contains BR: python2-devel or python3-devel
[x]: Packages MUST NOT have dependencies (either build-time or runtime) on
     packages named with the unversioned python- prefix unless no properly
     versioned package exists. Dependencies on Python packages instead MUST
     use names beginning with python2- or python3- as appropriate.
[x]: Python packages must not contain %{pythonX_site(lib|arch)}/* in %files
[x]: Binary eggs must be removed in %prep

===== SHOULD items =====

Generic:
[-]: If the source package does not include license text(s) as a separate
     file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[-]: Fully versioned dependency in subpackages if applicable.
     Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in
     python3-google-cloud-pubsub , python3-google-cloud-pubsub+libcst
[x]: Package functions as described.

     (Tests pass)

[!]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[-]: Sources are verified with gpgverify first in %prep if upstream
     publishes signatures.
     Note: gpgverify is not used.
[x]: Package should compile and build into binary rpms on all supported
     architectures.
[x]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed
     files.
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
     $RPM_BUILD_ROOT)
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: SourceX is a working URL.
[x]: Spec use %global instead of %define unless justified.

===== EXTRA items =====

Generic:
[x]: Rpmlint is run on all installed packages.
     Note: There are rpmlint messages (see attachment).
[x]: Spec file according to URL is the same as in SRPM.


Rpmlint
-------
Cannot parse rpmlint output:


Rpmlint (installed packages)
----------------------------
Cannot parse rpmlint output:


Source checksums
----------------
https://github.com/googleapis/python-pubsub/archive/v2.12.1/python-pubsub-2.12.1.tar.gz :
  CHECKSUM(SHA256) this package     : 59a5b7276f7256ec647039b83025fc62c2428acce1608677fcf932db7cb69634
  CHECKSUM(SHA256) upstream package : 59a5b7276f7256ec647039b83025fc62c2428acce1608677fcf932db7cb69634


Requires
--------
python3-google-cloud-pubsub (rpmlib, GLIBC filtered):
    ((python3.10dist(google-api-core) < 2.1~~ or python3.10dist(google-api-core) >= 2.2) with (python3.10dist(google-api-core) < 2.2~~ or python3.10dist(google-api-core) >= 2.3) with (python3.10dist(google-api-core) < 2.3 or python3.10dist(google-api-core) > 2.3) with (python3.10dist(google-api-core) < 2~~ or python3.10dist(google-api-core) >= 2.1) with python3.10dist(google-api-core) < 3~~dev0 with python3.10dist(google-api-core) >= 1.31.5)
    ((python3.10dist(google-api-core[grpc]) < 2.1~~ or python3.10dist(google-api-core[grpc]) >= 2.2) with (python3.10dist(google-api-core[grpc]) < 2.2~~ or python3.10dist(google-api-core[grpc]) >= 2.3) with (python3.10dist(google-api-core[grpc]) < 2.3 or python3.10dist(google-api-core[grpc]) > 2.3) with (python3.10dist(google-api-core[grpc]) < 2~~ or python3.10dist(google-api-core[grpc]) >= 2.1) with python3.10dist(google-api-core[grpc]) < 3~~dev0 with python3.10dist(google-api-core[grpc]) >= 1.31.5)
    (python3.10dist(grpc-google-iam-v1) < 0.13~~dev0 with python3.10dist(grpc-google-iam-v1) >= 0.12.3)
    (python3.10dist(grpcio) < 2~~dev0 with python3.10dist(grpcio) >= 1.38.1)
    python(abi)
    python3.10dist(grpcio-status)
    python3.10dist(proto-plus)

python3-google-cloud-pubsub+libcst (rpmlib, GLIBC filtered):
    python(abi)
    python3-google-cloud-pubsub
    python3.10dist(libcst)



Provides
--------
python3-google-cloud-pubsub:
    python-google-cloud-pubsub
    python3-google-cloud-pubsub
    python3.10-google-cloud-pubsub
    python3.10dist(google-cloud-pubsub)
    python3dist(google-cloud-pubsub)

python3-google-cloud-pubsub+libcst:
    python-google-cloud-pubsub+libcst
    python3-google-cloud-pubsub+libcst
    python3.10-google-cloud-pubsub+libcst
    python3.10dist(google-cloud-pubsub[libcst])
    python3dist(google-cloud-pubsub[libcst])



Generated by fedora-review 0.8.0 (e988316) last change: 2022-04-07
Command line :/usr/bin/fedora-review -b 2092637
Buildroot used: fedora-rawhide-x86_64
Active plugins: Generic, Shell-api, Python
Disabled plugins: PHP, Ocaml, Perl, Java, C/C++, Haskell, fonts, SugarActivity, R
Disabled flags: EPEL6, EPEL7, DISTTAG, BATCH, EXARCH
============================ rpmlint session starts ============================
rpmlint: 2.2.0
configuration:
    /usr/lib/python3.10/site-packages/rpmlint/configdefaults.toml
    /etc/xdg/rpmlint/fedora.toml
    /etc/xdg/rpmlint/licenses.toml
    /etc/xdg/rpmlint/scoring.toml
    /etc/xdg/rpmlint/users-groups.toml
    /etc/xdg/rpmlint/warn-on-functions.toml
checks: 32, packages: 3

python3-google-cloud-pubsub+libcst.noarch: W: no-documentation
python3-google-cloud-pubsub.noarch: W: files-duplicate /usr/lib/python3.10/site-packages/google/pubsub_v1/py.typed /usr/lib/python3.10/site-packages/google/pubsub/py.typed
 3 packages and 0 specfiles checked; 0 errors, 2 warnings, 0 badness; has taken 1.1 s

Comment 9 Major Hayden 🤠 2022-06-13 13:02:57 UTC
Thanks, Ben and Benson! Repo requested: https://pagure.io/releng/fedora-scm-requests/issue/44921

Comment 10 Tomas Hrcka 2022-06-14 07:20:47 UTC
(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/python-google-cloud-pubsub

Comment 12 Fedora Update System 2022-06-15 11:53:09 UTC
FEDORA-2022-dbc48fbcd8 has been submitted as an update to Fedora 36. https://bodhi.fedoraproject.org/updates/FEDORA-2022-dbc48fbcd8

Comment 13 Fedora Update System 2022-06-16 02:40:09 UTC
FEDORA-2022-dbc48fbcd8 has been pushed to the Fedora 36 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf install --enablerepo=updates-testing --advisory=FEDORA-2022-dbc48fbcd8 \*`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2022-dbc48fbcd8

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 14 Fedora Update System 2022-06-24 00:58:30 UTC
FEDORA-2022-dbc48fbcd8 has been pushed to the Fedora 36 stable repository.
If problem still persists, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.