Bug 2092796 - [RFE] CPU|Memory display in the template card is not consistent with the display in the template drawer
Summary: [RFE] CPU|Memory display in the template card is not consistent with the disp...
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Container Native Virtualization (CNV)
Classification: Red Hat
Component: User Experience
Version: 4.11.0
Hardware: Unspecified
OS: Unspecified
low
low
Target Milestone: ---
: 4.12.0
Assignee: Matan Schatzman
QA Contact: Leon Kladnitsky
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2022-06-02 09:25 UTC by Leon Kladnitsky
Modified: 2023-01-24 13:36 UTC (History)
5 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2023-01-24 13:36:17 UTC
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)
catalog (156.59 KB, image/png)
2022-06-02 09:25 UTC, Leon Kladnitsky
no flags Details
CPU Memory display in drawer should be as in the card. Divider line should be in grey color as the template display name in the card (to avoid confusion with the number) (42.44 KB, image/png)
2022-06-02 11:51 UTC, Yifat Menchik
no flags Details
CPU Memory display in the drawer (42.44 KB, image/png)
2022-06-02 11:55 UTC, Yifat Menchik
no flags Details
CPU & Memory in card view (16.11 KB, image/png)
2022-06-06 10:14 UTC, Yifat Menchik
no flags Details
CPU & Memory in drawer view (43.72 KB, image/png)
2022-06-06 10:14 UTC, Yifat Menchik
no flags Details


Links
System ID Private Priority Status Summary Last Updated
Github kubevirt-ui kubevirt-plugin pull 836 0 None open Bug 2092796: Change cpu and memory appearance values 2022-08-17 11:16:45 UTC
Red Hat Issue Tracker CNV-18864 0 None None None 2022-12-15 08:43:03 UTC
Red Hat Product Errata RHSA-2023:0408 0 None None None 2023-01-24 13:36:30 UTC

Description Leon Kladnitsky 2022-06-02 09:25:47 UTC
Created attachment 1886000 [details]
catalog

Description of problem: CPU|Memory display in the template card of Virtualization Catalog page should have value before the units, like the display in the drawer card 


Version-Release number of selected component (if applicable):


How reproducible:


Steps to Reproduce:
1.
2.
3.

Actual results:


Expected results:


Additional info:

Comment 1 Yifat Menchik 2022-06-02 11:51:51 UTC
Created attachment 1886072 [details]
CPU Memory display in drawer should be as in the card. Divider line should be in grey color as the template display name in the card (to avoid confusion with the number)

Comment 2 Yifat Menchik 2022-06-02 11:55:05 UTC
Created attachment 1886073 [details]
CPU Memory display in the drawer

Comment 3 Yifat Menchik 2022-06-06 10:13:10 UTC
Please discard the attachment in comments #1 and #2, as a result of my misunderstanding the problem.
This is the updated design for the CPU and memory in the card view and in the drawer view.

Comment 4 Yifat Menchik 2022-06-06 10:14:08 UTC
Created attachment 1887054 [details]
CPU & Memory in card view

Comment 5 Yifat Menchik 2022-06-06 10:14:52 UTC
Created attachment 1887055 [details]
CPU & Memory in drawer view

Comment 6 Hilda Stastna 2022-06-06 18:38:30 UTC
From what I've understood about this bug, there are two issues regarding CPU | Memory field:

1. inconsistency of displaying the CPU and Memory info in the UI,
2. problematic divider "|", that can look like number one for some users.

The expected result/solution that was agreed on (Comment 4 and 5) is problematic, because it solves the issue only with the divider + has two other issues:

1. solves the issue regarding the divider ONLY for the Catalog card, as the solution is present only for it,
   not for any other places in the UI with the CPU | Memory field, including the drawer mentioned in this BZ.
   When started dealing with this bug, I was told not to fix it in any other places in the UI.
2. adds even more inconsistency to the UI, because again - the solution presented in this ticket is only for the Catalog card

According to mentioned above, I recommend to re-evaluate what should be the expected result of this bug. If there is no time for this or if more changes are coming regarding CPU | Memory field, postponing this bug for a next release could be a way, too, to fix both inconsistency and the divider issues and to prevent creating more inconsistency in the UI.

Comment 9 Guohua Ouyang 2022-08-18 23:39:45 UTC
verified on v4.12.0-106

Comment 13 errata-xmlrpc 2023-01-24 13:36:17 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (Important: OpenShift Virtualization 4.12.0 Images security update), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHSA-2023:0408


Note You need to log in before you can comment on or make changes to this bug.