Hi, this is my first packaging request. I am the co-maintainer of this GNU package and would be willing to maintain the Fedora RPM package for it. For now, I am doing this via Copr. I am still in need of a sponsor. The package is currently divided into three parts: - gnunet: The base component including most of the services and libraries - gnunet-*-plugins: Optional database plugins - gnunet-devel: The ususal headers etc - gnunet-bcd: A business card generation tool (needs latex) - gnunet-conversation: A VoP2P service (needs gtreamer et al.) Cheers Spec URL: https://git.gnunet.org/gnunet-rpm.git/log/?h=dev/schanzen/copr SRPM URL: https://download.copr.fedorainfracloud.org/results/schanzen/gnunet/fedora-rawhide-x86_64/04501710-gnunet/ Copr: https://copr.fedorainfracloud.org/coprs/schanzen/gnunet Description: GNUnet is peer-to-peer framework providing a network abstractions and applications focusing on security and privacy. So far, we have created applications for anonymous file-sharing, decentralized naming and identity management, decentralized and confidential telephony and tunneling IP traffic over GNUnet. GNUnet is currently developed by a worldwide group of independent free software developers. GNUnet is a GNU package (http://www.gnu.org/). Fedora Account System Username: schanzen
Perhaps use: SRPM URL: https://download.copr.fedorainfracloud.org/results/schanzen/gnunet/fedora-rawhide-x86_64/04501710-gnunet/gnunet-0.17.0-2.fc37.src.rpm
Spec URL: https://download.copr.fedorainfracloud.org/results/schanzen/gnunet/fedora-rawhide-x86_64/04501710-gnunet/gnunet.spec
Hi, in the meantime I have been updating the package for every release and set the COPR build to build with fedora-review. The open issues seem to be: -- - Package installs properly. Note: Installation errors (see attachment) See: https://docs.fedoraproject.org/en-US/packaging-guidelines/ => More on this below. - If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. Note: License file libgnunet_plugin_rest_copying.so is not marked as %license See: https://docs.fedoraproject.org/en-US/packaging- guidelines/LicensingGuidelines/#_license_text => This is probably a false positive regex match. - systemd_user_post is invoked in %post and systemd_user_preun in %preun for Systemd user units service files. Note: Systemd user unit service file(s) in gnunet See: https://docs.fedoraproject.org/en-US/packaging- guidelines/Scriptlets/#_user_units => I have no idea what the "issue" is with this. I followed the user unit guide. => Regarding some of the manual checks: [ ]: Package must own all directories that it creates. Note: Directories without known owners: /usr/include/gnunet, /usr/share/doc/gnunet => I tried to get rid of this for hours. I have no idea what the issue is. The directories are declared with %dir. [ ]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in libgnunet => So, libgnunet is the subpackage that is basically the core everything else depends upon. => The subpackage itself does not have any local Require's. I cannot get rid of this message. gnunet-doc.noarch: E: files-duplicated-waste 318478 => GNUnet 0.19.2 will fix this hopefully along with some man pages. gnunet.x86_64: E: call-to-mktemp /usr/bin/gnunet-testing gnunet.x86_64: E: call-to-mktemp /usr/lib64/gnunet/libgnunet_plugin_datacache_sqlite.so gnunet.x86_64: E: call-to-mktemp /usr/lib64/libgnunetdatacache.so.0.0.1 gnunet.x86_64: E: call-to-mktemp /usr/lib64/libgnunetfs.so.2.1.1 libgnunet.x86_64: E: call-to-mktemp /usr/lib64/libgnunetutil.so.15.0.0 => This results in 6 errors and does not make sense. The code never calls mktemp. In fact, it only calls mkstemp and mkdtemp: https://git.gnunet.org/gnunet.git/tree/src/util/disk.c#n380 -- I have added my review.txt as attachment. Happy new year.
Created attachment 1934946 [details] review.txt The review.txt from my local run
This is an automatic check from review-stats script. This review request ticket hasn't been updated for some time. We're sorry it is taking so long. If you're still interested in packaging this software into Fedora repositories, please respond to this comment clearing the NEEDINFO flag. You may want to update the specfile and the src.rpm to the latest version available and to propose a review swap on Fedora devel mailing list to increase chances to have your package reviewed. If this is your first package and you need a sponsor, you may want to post some informal reviews. Read more at https://fedoraproject.org/wiki/How_to_get_sponsored_into_the_packager_group. Without any reply, this request will shortly be considered abandoned and will be closed. Thank you for your patience.
(In reply to Package Review from comment #5) > This is an automatic check from review-stats script. > > This review request ticket hasn't been updated for some time. We're sorry > it is taking so long. If you're still interested in packaging this software > into Fedora repositories, please respond to this comment clearing the > NEEDINFO flag. > > You may want to update the specfile and the src.rpm to the latest version > available and to propose a review swap on Fedora devel mailing list to > increase > chances to have your package reviewed. If this is your first package and you > need a sponsor, you may want to post some informal reviews. Read more at > https://fedoraproject.org/wiki/How_to_get_sponsored_into_the_packager_group. > > Without any reply, this request will shortly be considered abandoned > and will be closed. > Thank you for your patience. I am still interested in getting this packaged. I am currently working on moving the build system to meson, which will land in copr with the next release. The currently release is still on COPR (see links in OP)
Recent files: SPEC: https://download.copr.fedorainfracloud.org/results/schanzen/gnunet/fedora-rawhide-x86_64/06667708-gnunet/gnunet.spec SRPM: https://download.copr.fedorainfracloud.org/results/schanzen/gnunet/fedora-rawhide-x86_64/06667708-gnunet/gnunet-0.20.0-1.fc40.src.rpm