This bug was introduced with https://github.com/linux-system-roles/storage/pull/269

This is the coverity output:

Error: REVERSE_INULL (CWE-476): [#def1]
auto-maintenance-fe4fd028db23607414acce481388f23ac51cd944/storage/library/blivet.py:1369: alias: Assigning: "thinlv" = "__coverity_temp_var5".
auto-maintenance-fe4fd028db23607414acce481388f23ac51cd944/storage/library/blivet.py:1371: deref: Accessing a property of "thinlv".
auto-maintenance-fe4fd028db23607414acce481388f23ac51cd944/storage/library/blivet.py:1378: check_after_deref: Null-checking "thinlv" suggests that it may be null, but it has already been dereferenced on all paths leading to the check.

Here is the code in question: https://github.com/linux-system-roles/storage/blob/master/library/blivet.py#L1369-L1379

        for thinlv in thinlvs_to_create:

            if thinlv['size'] is None:
                tlv_size = Size(calculated_thinlv_size)
            else:
                tlv_size = Size(thinlv['size'])

            thinlv_params = dict(thin_pool=True, size=tlv_size, parents=[pool_device])

            if thinlv is not None:
                thinlv_params.update(dict(name=thinlv['name']))

If it is possible for thinlv to be None, then the code will blow up on thinlv['size'] - either we need to guarantee that thinlv will never be None, and get rid of the 'if thinlv is not None' check, or move that check to the first line of code inside the loop, and do something to avoid using thinlv in subsequent code.

Jan, please take a look.

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (rhel-system-roles bug fix and enhancement update), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHEA-2022:8117