Bug 209615 - Review Request: wmcpuload - WindowMaker dockapp
Review Request: wmcpuload - WindowMaker dockapp
Status: CLOSED WONTFIX
Product: Fedora
Classification: Fedora
Component: Package Review (Show other bugs)
rawhide
All Linux
medium Severity medium
: ---
: ---
Assigned To: Patrice Dumas
Fedora Package Reviews List
:
Depends On:
Blocks: FE-DEADREVIEW
  Show dependency treegraph
 
Reported: 2006-10-06 08:50 EDT by David Kovalsky
Modified: 2014-03-31 19:44 EDT (History)
2 users (show)

See Also:
Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
Environment:
Last Closed: 2008-01-21 04:13:42 EST
Type: ---
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---


Attachments (Terms of Use)

  None (edit)
Description David Kovalsky 2006-10-06 08:50:47 EDT
Spec URL: http://www.kovalsky.cz/packages/wmcpuload.spec
SRPM URL: http://www.kovalsky.cz/packages/wmcpuload-1.0.1-1.src.rpm
Description: DockApp for window managers such as WindowMaker showing CPU usage

Please note this is my first package in Extras (togethew with wmmemload, bz 209614) -> need a sponsor
Comment 1 Patrice Dumas 2006-10-07 05:00:27 EDT
I have exactly the same comments than for wmmemload (including
the .src.rpm not accessible).
Comment 2 David Kovalsky 2006-10-12 10:31:45 EDT
uploaded the new fixed files, please take a look
http://www.kovalsky.cz/packages/wmcpuload.spec
http://www.kovalsky.cz/packages/wmcpuload-1.0.1-1.src.rpm

Thanks a lot for your review notes!
Comment 3 David Kovalsky 2006-10-13 07:36:56 EDT
Updated packages to address issues similar to the ones mentioned in bz 209614

http://www.kovalsky.cz/packages/wmcpuload.spec
http://www.kovalsky.cz/packages/wmcpuload-1.0.1-2.src.rpm
Comment 4 Patrice Dumas 2006-10-13 18:37:41 EDT
For the doc files, you don't need to install them yourself. 
rpmbuild will do everything for you with 

%doc AUTHORS COPYING ChangeLog THANKS README NEWS TODO
Comment 5 Patrice Dumas 2006-10-13 18:45:32 EDT
Another comment, in the %description, the line

' It runs on GNU/Linux, FreeBSD, OpenBSD,
NetBSD, BSDi, Solaris, Cygwin, IRIX and Darwin.'

isn't of much use on fedora.

Also, installing things 'by hand' with the install calls in 
%install isn't wrong, but here a simple

make install DESTDIR=$RPM_BUILD_ROOT

should work.
Comment 6 David Kovalsky 2006-10-16 07:33:33 EDT
Updated packages to address above mentioned issues 

http://www.kovalsky.cz/packages/wmcpuload.spec
http://www.kovalsky.cz/packages/wmcpuload-1.0.1-3.src.rpm

description changed, integrated "tips" :-) thanks!


Is there anything else blocking the package?

Comment 7 Patrice Dumas 2006-10-17 12:50:09 EDT
Comments in Comment #5 weren't blocking.

The timestamp of the source file isn't the right one, it is
also not blocking. To keep the timestamp, you can use wget -N
to download, or spectool -g on the spec file.

Seems like an internal version of libdockapp is used. It is 
a blocker. libdockapp should be packaged in fedora extras and 
the build of wmcpuload should be arranged to build against
the external libdockapp.
Comment 8 Kevin Fenzi 2006-12-16 14:35:54 EST
Hey Patrice. 

Are you formally reviewing this package? It's assigned to you, but still
blocking the FE-NEW blocker. If you are reviewing it, can you move that to
FE-REVIEW? 
If not, can you move it back to being assigned to nobody@fedoraproject.org? 
Comment 9 Patrice Dumas 2006-12-16 18:48:45 EST
Yes, I am formally reviewing it. I don't want the libdockapp 
internal library to be used.
Comment 10 Patrice Dumas 2007-06-26 14:16:12 EDT
I packaged libdockapp some time ago for wmacpi, you can use it.
Comment 11 Jason Tibbitts 2008-01-20 17:27:18 EST
Any updates?
Comment 12 David Kovalsky 2008-01-21 04:13:42 EST
Indeed, I can't find the time to invest the effort ATM.

Sorry.

Note You need to log in before you can comment on or make changes to this bug.