Red Hat Bugzilla – Bug 209615
Review Request: wmcpuload - WindowMaker dockapp
Last modified: 2014-03-31 19:44:10 EDT
Spec URL: http://www.kovalsky.cz/packages/wmcpuload.spec
SRPM URL: http://www.kovalsky.cz/packages/wmcpuload-1.0.1-1.src.rpm
Description: DockApp for window managers such as WindowMaker showing CPU usage
Please note this is my first package in Extras (togethew with wmmemload, bz 209614) -> need a sponsor
I have exactly the same comments than for wmmemload (including
the .src.rpm not accessible).
uploaded the new fixed files, please take a look
Thanks a lot for your review notes!
Updated packages to address issues similar to the ones mentioned in bz 209614
For the doc files, you don't need to install them yourself.
rpmbuild will do everything for you with
%doc AUTHORS COPYING ChangeLog THANKS README NEWS TODO
Another comment, in the %description, the line
' It runs on GNU/Linux, FreeBSD, OpenBSD,
NetBSD, BSDi, Solaris, Cygwin, IRIX and Darwin.'
isn't of much use on fedora.
Also, installing things 'by hand' with the install calls in
%install isn't wrong, but here a simple
make install DESTDIR=$RPM_BUILD_ROOT
Updated packages to address above mentioned issues
description changed, integrated "tips" :-) thanks!
Is there anything else blocking the package?
Comments in Comment #5 weren't blocking.
The timestamp of the source file isn't the right one, it is
also not blocking. To keep the timestamp, you can use wget -N
to download, or spectool -g on the spec file.
Seems like an internal version of libdockapp is used. It is
a blocker. libdockapp should be packaged in fedora extras and
the build of wmcpuload should be arranged to build against
the external libdockapp.
Are you formally reviewing this package? It's assigned to you, but still
blocking the FE-NEW blocker. If you are reviewing it, can you move that to
If not, can you move it back to being assigned to email@example.com?
Yes, I am formally reviewing it. I don't want the libdockapp
internal library to be used.
I packaged libdockapp some time ago for wmacpi, you can use it.
Indeed, I can't find the time to invest the effort ATM.