Red Hat Bugzilla – Bug 209617
Review Request: comix - A user-friendly, customizable image viewer
Last modified: 2008-10-03 05:21:54 EDT
Spec URL: http://www.ioa.s.u-tokyo.ac.jp/~mtasaka/dist/extras/development/SPECS/comix.spec
SRPM URL: http://www.ioa.s.u-tokyo.ac.jp/~mtasaka/dist/extras/development/SRPMS/comix-3.6-1.src.rpm
Comix is a user-friendly, customizable image viewer.
It is specifically designed to handle comic books, but
also serves as a generic viewer. It reads images in ZIP,
RAR or tar archives (also gzip or bzip2 compressed) as
well as plain image files. It is written in Python and
uses GTK+ through the PyGTK bindings.
Note: rpmlint says:
W: comix non-conffile-in-etc /etc/gconf/schemas/comix.schemas
However, this is not a configuration file and files under
/etc/gconf/schemas are usually not marked as %config
( as you can see these files in epiphany. yelp, planner, etc)
Hmm, the source doesn't match upstream. Ahh, because the source URL gives me
some HTML for selecting a mirror. You should use dl.sourceforge.net instead of
prdownloads.sourceforge.net. I also had to manually add a mirror (easynews) in
order to actually download the source, since the sourceforge mirror system is so
The non-conffile-in-etc bit is known to be bogus for gconf schemas.
This package owns /etc/gconf, which is owned by GConf in FC5 but which is
completely unowned in FC6. Ouch. This package also owns /etc/gconf/schemas,
which unfortunately doesn't seem to be owned by GConf as it should. I really
don't know what this package should do; I guess owning those directories is
better than leaving them unowned, but this should be fixed in Core and if it is
this package will need to stop owning those directories.
So I'll approve this package for FC6/rawhide, but for FC5 you will need to stop
* source files match upstream:
* package meets naming and packaging guidelines.
* specfile is properly named, is cleanly written and uses macros consistently.
* dist tag is present.
* build root is correct.
* license field matches the actual license.
* license is open source-compatible. License text included in package.
* latest version is being packaged.
* BuildRequires are proper.
* %clean is present.
* package builds in mock (development, x86_64).
* package installs properly
* rpmlint has only bogus complaints.
* final provides and requires are sane:
comix = 3.6-1.fc6
* %check is not present; no test suite upstream. Package manually tested and
seems to work fine.
* owns the directories it creates.
? owns /etc/gconf; in FC5, it must not.
* no duplicates in %files.
* file permissions are appropriate.
* scriptlets are OK (gconf schema installation, icon cache update, desktop
database update, mime database update)
* code, not content.
* documentation is small, so no -docs subpackage is necessary.
* %docs are not necessary for the proper functioning of the package.
* .desktop file installed properly
Thank you for a quick review and approving this package!!
* Rebuild for FE-devel succeeded.
* SyncNeeded is requested for FE-5.
Now I close this bug as CLOSED NEXTRELEASE.
(In reply to comment #2)
> You should use dl.sourceforge.net instead of
I changed URL as you recommended.
> This package owns /etc/gconf, which is owned by GConf in FC5 but which is
> completely unowned in FC6. Ouch.
Well, I checked FC5, however, /etc/gconf is not owned by GConf2 (I have
not checked GConf because this package does not require GConf) and..
/etc/gconf is not owned by any packages required by this package in FC5,
either. So I have to make this package own /etc/gconf in FC5, too
(I strongly think that some other package should own /etc/gconf and
> This package also owns /etc/gconf/schemas,
> which unfortunately doesn't seem to be owned by GConf as it should.
This is the same for FC5.
Package Change Request
Package Name: comix
New Branches: F-10
Early branching request.