Bug 2096691 - [Alibaba 4.11] Specifying ResourceGroup id in install-config.yaml, New pv are still getting created to default ResourceGroups
Summary: [Alibaba 4.11] Specifying ResourceGroup id in install-config.yaml, New pv are...
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: OpenShift Container Platform
Classification: Red Hat
Component: Storage
Version: 4.11
Hardware: All
OS: All
unspecified
medium
Target Milestone: ---
: 4.11.0
Assignee: Jan Safranek
QA Contact: Rohit Patil
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2022-06-14 08:36 UTC by Rohit Patil
Modified: 2022-08-10 11:18 UTC (History)
5 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2022-08-10 11:17:47 UTC
Target Upstream Version:
Embargoed:

Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Github openshift alibaba-disk-csi-driver-operator pull 32 0 None Merged Bug 2096691: Add resourceGroupID to StorageClass parameters 2022-06-20 07:35:30 UTC
Github openshift alibaba-disk-csi-driver-operator pull 33 0 None open Bug 2096691: Fix typo in resourceiGroupId param 2022-06-23 09:50:15 UTC
Github openshift library-go pull 1377 0 None Merged Bug 2096691: Add custom hooks to CSIStorageClassController 2022-06-20 07:35:33 UTC
Red Hat Product Errata RHSA-2022:5069 0 None None None 2022-08-10 11:18:04 UTC

Comment 3 Jan Safranek 2022-06-14 11:23:48 UTC 
If I understand it correctly, alibaba-disk-csi-driver-operator should provide the group ID in csi-disk StorageClass:

parameters:
  resourceGroupId: <the resource group from install-config.yaml>
Comment 4 Wei Duan 2022-06-14 13:27:25 UTC 
It works if we adding sc.parameters.resourceGroupId in the storageclass.

Here I'm not sure if our operator should do this (adding resourceGroupId in preset sc) or CSI Driver should default create volume in the same resource group with cluster.
Comment 5 Jan Safranek 2022-06-14 13:34:48 UTC 
... and the resource group is part of infrastructure.status:


apiVersion: config.openshift.io/v1
kind: Infrastructure
metadata:
  name: cluster
spec:
  cloudConfig:
    key: config
    name: cloud-provider-config
  platformSpec:
    type: AlibabaCloud
status:
  [...]
  platform: AlibabaCloud
  platformStatus:
    alibabaCloud:
      region: us-east-1
      resourceGroupID: rg-acfnxrgr6qtm3mq
    type: AlibabaCloud
Comment 6 Jan Safranek 2022-06-14 14:10:30 UTC 
> Here I'm not sure if our operator should do this (adding resourceGroupId in preset sc) or CSI Driver should default create volume 
> in the same resource group with cluster.

I think the operator should set the resource group in the default StorageClass, to have all cluster resources together.
Comment 13 Jan Safranek 2022-06-23 09:46:03 UTC 
> Here the "resourceGroupID" should be "resourceGroupId" inside default sc.

Good catch! I should not have tested in the default resource group!
Comment 17 errata-xmlrpc 2022-08-10 11:17:47 UTC 
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (Important: OpenShift Container Platform 4.11.0 bug fix and security update), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHSA-2022:5069
Note You need to log in before you can comment on or make changes to this bug.