Note: This bug is displayed in read-only format because the product is no longer active in Red Hat Bugzilla.

Bug 2097717

Summary:	Hot set of CPUs for dedicated VM must be blocked in UI
Product:	[oVirt] ovirt-engine	Reporter:	Polina <pagranat>
Component:	Frontend.WebAdmin	Assignee:	Lucia Jelinkova <ljelinko>
Status:	CLOSED CURRENTRELEASE	QA Contact:	Polina <pagranat>
Severity:	medium	Docs Contact:
Priority:	unspecified
Version:	4.5.1	CC:	ahadas, bugs, mzamazal
Target Milestone:	ovirt-4.5.2	Keywords:	ZStream
Target Release:	4.5.2	Flags:	sbonazzo: ovirt-4.5+
Hardware:	x86_64
OS:	Linux
Whiteboard:
Fixed In Version:	ovirt-engine-4.5.2	Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2022-08-30 08:47:42 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	Virt	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Polina 2022-06-16 11:41:46 UTC

Description of problem:
Now the user is notified in the log that "Hot plugging a CPU is not supported with the CPU pinning policy ISOLATE_THREADS."
Though if he doesn't check the logs it looks like it must work but actually doesn't work.

Version-Release number of selected component (if applicable):
ovirt-engine-4.5.1.1-0.14.el8ev.noarch

How reproducible:100%

Steps to Reproduce:
1. Run decicated/isolated VM with one CPU
2. increase the CPUs to 4, ok in the edit window.

Actual results:
got the UI message that it could be applied immediately or later. ok for immediate apply - nothing happens . the cpu remains 1
In log we see error -
2022-06-16 14:26:20,738+03 INFO [org.ovirt.engine.core.bll.UpdateVmCommand] (default task-16) [829884ef-7df4-466e-b84a-a7004ae1e433] Running command: UpdateVmCommand internal: false. Entities affected : ID: cb7432a4-1a83-4a61-8d07-272da4e553b4 Type: VMAction group EDIT_VM_PROPERTIES with role type USER
2022-06-16 14:26:20,842+03 WARN [org.ovirt.engine.core.bll.HotSetNumberOfCpusCommand] (default task-16) [82636de] Validation of action 'HotSetNumberOfCpus' failed for user admin@internal-authz. Reasons: VAR__ACTION__HOT_SET_CPUS,VAR__TYPE__VM,$clusterVersion 4.7,$architecture x86_64,HOT_PLUG_CPU_IS_NOT_SUPPORTED_DEDICATED,$policy ISOLATE_THREADS
2022-06-16 14:26:20,980+03 ERROR [org.ovirt.engine.core.dal.dbbroker.auditloghandling.AuditLogDirector] (default task-16) [82636de] EVENT_ID: FAILED_HOT_SET_NUMBER_OF_CPUS(2,034), Failed to hot set number of CPUS to VM golden_env_mixed_virtio_2. Underlying error message: Hot plugging a CPU is not supported with the CPU pinning policy ISOLATE_THREADS.

Expected results:
the hot set num of CPUs must be blocked in case it is not supposed to work

Additional info:

Comment 1 Arik 2022-06-21 08:51:19 UTC

makes sense for this to go together with https://github.com/oVirt/ovirt-engine/pull/469

Comment 2 Milan Zamazal 2022-07-18 13:23:17 UTC

Just for tracking: The fix mentioned in Comment 1 fixed the issue in the backend, this bug is about the frontend part.

Comment 3 Polina 2022-08-02 11:16:13 UTC

verified on ovirt-engine-4.5.2-0.3.el8ev.noarch

now we get:

Error while executing action:

golden_env_mixed_virtio_1_0:
Hot plugging a CPU is not supported with the CPU pinning policy DEDICATED.

or 

Hot plugging a CPU is not supported with the CPU pinning policy ISOLATE_THREADS.

Comment 4 Sandro Bonazzola 2022-08-30 08:47:42 UTC

This bugzilla is included in oVirt 4.5.2 release, published on August 10th 2022.
Since the problem described in this bug report should be resolved in oVirt 4.5.2 release, it has been closed with a resolution of CURRENT RELEASE.
If the solution does not work for you, please open a new bug report.