Bug 2097845 - Review Request: perl-MouseX-Types-Common - Set of commonly-used type constraints
Summary: Review Request: perl-MouseX-Types-Common - Set of commonly-used type constra...
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Jitka Plesnikova
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2022-06-16 17:06 UTC by Ralf Corsepius
Modified: 2022-06-27 10:23 UTC (History)
2 users (show)

Fixed In Version: perl-MouseX-Types-Common-0.001000-2.fc35 perl-MouseX-Types-Common-0.001000-2.fc36 perl-MouseX-Types-Common-0.001000-2.fc37
Clone Of:
Environment:
Last Closed: 2022-06-27 10:23:40 UTC
Type: ---
Embargoed:
jplesnik: fedora-review+


Attachments (Terms of Use)

Description Ralf Corsepius 2022-06-16 17:06:09 UTC
Spec URL: https://corsepiu.fedorapeople.org/packages/perl-MouseX-Types-Common.spec
SRPM URL: https://corsepiu.fedorapeople.org/packages/perl-MouseX-Types-Common-0.001000-1.fc37.src.rpm
Description: A set of commonly-used type constraints that do not ship with Mouse
by default.

Fedora Account System Username: corsepiu

Comment 1 Ralf Corsepius 2022-06-16 17:07:46 UTC
This package is an optional, so far missing, BR: of perl-Type-Tiny.

Comment 2 Jitka Plesnikova 2022-06-20 17:57:43 UTC
Source file is ok
Summary is ok
License is ok
Description is ok
URL and Source0 are ok
All tests passed

BuildRequires:
FIX: Use 'perl(:VERSION) >= 5.6.2' instead of 'perl-interpreter >= 0:5.006002'
     because the package has an epoch.
FIX: Please add BRs:
     coreutils - spec line: 32, 41
     make - spec line: 37, 40, 44
     sed - spec line: 33
     perl(MouseX::Types::Mouse) - lib/MouseX/Types/Common/Numeric.pm:12
     perl(Module::Install::Metadata) - Makefile.PL: 6, 7, 10, 11, 14
     perl(Module::Install::WriteAll) - Makefile.PL: 16

$ rpm -qp --requires perl-MouseX-Types-Common-0.001000-1.fc37.noarch.rpm | sort | uniq -c | grep -v rpmlib
      1 perl(:MODULE_COMPAT_5.36.0)
      1 perl(MouseX::Types)
      1 perl(MouseX::Types::Mouse)
      1 perl(strict)
      1 perl(:VERSION) >= 5.6.0
      1 perl(warnings)
Binary requires are Ok.

$ rpm -qp --provides perl-MouseX-Types-Common-0.001000-1.fc37.noarch.rpm | sort | uniq -c
      1 perl(MouseX::Types::Common) = 0.001000
      1 perl-MouseX-Types-Common = 0.001000-1.fc37
      1 perl(MouseX::Types::Common::Numeric) = 0.001000
      1 perl(MouseX::Types::Common::String) = 0.001000
Binary provides are Ok.

$ rpmlint ./perl-MouseX-Types-Common*
================================ rpmlint session starts ===============================
rpmlint: 2.2.0
configuration:
    /usr/lib/python3.10/site-packages/rpmlint/configdefaults.toml
    /etc/xdg/rpmlint/fedora.toml
    /etc/xdg/rpmlint/licenses.toml
    /etc/xdg/rpmlint/scoring.toml
    /etc/xdg/rpmlint/users-groups.toml
    /etc/xdg/rpmlint/warn-on-functions.toml
checks: 32, packages: 3

= 2 packages and 1 specfiles checked; 0 errors, 0 warnings, 0 badness; has taken 0.2 s
Rpmlint is ok

Otherwise the package is in line with Fedora and Perl packaging guide lines.
Please correct all 'FIX' items.

Resolution:
Approved

Comment 3 Gwyn Ciesla 2022-06-21 19:42:34 UTC
(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/perl-MouseX-Types-Common

Comment 4 Jitka Plesnikova 2022-06-27 10:23:40 UTC
Built by corsepiu


Note You need to log in before you can comment on or make changes to this bug.