Review request for a new release. Spec URL: http://freeshell.in/~kushal/prozilla.spec SRPM URL: http://freeshell.in/~kushal/prozilla-2.0.4-1.src.rpm rpmlint output : [kd@kushal redhat]$ rpmlint ./RPMS/i386/prozilla-2.0.4-1.i386.rpm W: prozilla hidden-file-or-dir /usr/share/locale/ro/LC_MESSAGES/.mo W: prozilla hidden-file-or-dir /usr/share/locale/it/LC_MESSAGES/.mo W: prozilla hidden-file-or-dir /usr/share/locale/pt_BR/LC_MESSAGES/.mo W: prozilla hidden-file-or-dir /usr/share/locale/nl/LC_MESSAGES/.mo
typo fixed
You can't assign a review to yourself if you are the bug reporter :p I'll do the reviewer !
#1 : BuildRoot is incorrect ! see http://fedoraproject.org/wiki/Packaging/Guidelines#head-f196e7b2477c2f5dd97ef64e8eacddfb517f1aa1 #2 : %makeinstall macro should not be used ! see http://fedoraproject.org/wiki/Packaging/Guidelines#head-f196e7b2477c2f5dd97ef64e8eacddfb517f1aa1makeins #3 don't ship %{_libdir}/libprozilla.la and %{_libdir}/libprozilla.a. Delete them during %install #4 don't shipt#No idea why these files are here.. %ghost /usr/share/locale/it/LC_MESSAGES/.mo %ghost /usr/share/locale/nl/LC_MESSAGES/.mo %ghost /usr/share/locale/pt_BR/LC_MESSAGES/.mo %ghost /usr/share/locale/ro/LC_MESSAGES/.mo Delete them during %install #5 no need to ship README twice, but you should rather consider shipping FAQ as well. #6 is there a reason why you are using %post -p /sbin/ldconfig %postun -p /sbin/ldconfig ?
(In reply to comment #3) > #4 don't shipt#No idea why these files are here.. > %ghost /usr/share/locale/it/LC_MESSAGES/.mo > %ghost /usr/share/locale/nl/LC_MESSAGES/.mo > %ghost /usr/share/locale/pt_BR/LC_MESSAGES/.mo > %ghost /usr/share/locale/ro/LC_MESSAGES/.mo > Delete them during %install These files almost certainly contain some translation data. They are not hidden, instead they just lack a file prefix. I suspect there's something wrong with the Makefile or related things. Because these are only 4 languages, this must be the translation for libprozilla (I guess the GUI translation works.) I can't help you much further, sitting in front of Win2000 Box - just pushing into the right direction...
Hope all fixed :) Spec URL: http://freeshell.in/~kushal/prozilla.spec SRPM URL: http://freeshell.in/~kushal/prozilla-2.0.4-2.src.rpm
Where have the translations gone ?
No idea. I think that is a bug in the makefile.
Read Handling Locale Files: http://fedoraproject.org/wiki/Packaging/Guidelines#head-8c605ebf8330f6d505f384e671986fa99a8f72ee
No locale files found after installation.
Yes, there are !!! chitlesh(SOURCES)[0]$ls prozilla-2.0.4/po cat-id-tbl.c es.po fr.po it.po nl.gmo POTFILES.in proz.pot pt_BR.po ro.po ChangeLog fr.gmo it.gmo Makefile.in.in nl.po prozgui.pot pt_BR.gmo ro.gmo stamp-cat-id Have a look at what you have changed from 2.0.4-1 to 2.0.4-2 !
Use gettext as BR %find_lang proz in %install %files -f proz.lang instead of %files replace %dir %{_includedir}/prozilla/* by %{_includedir}/prozilla/
Doing that comes to an error No translations found for proz in /var/tmp/prozilla-2.0.4-3-root-root error: Bad exit status from /var/tmp/rpm-tmp.58160 (%install) Coz the makefile installing them to the real /usr/share without any name .. installing pt_BR.gmo as /usr/share/locale/pt_BR/LC_MESSAGES/.mo installing ro.gmo as /usr/share/locale/ro/LC_MESSAGES/.mo installing nl.gmo as /usr/share/locale/nl/LC_MESSAGES/.mo installing it.gmo as /usr/share/locale/it/LC_MESSAGES/.mo
Ok, ill have a look at it. I feel you are having problems with it, do you mind that I co-package prozilla with you in FE ?
Created attachment 143231 [details] prozilla.spec
the makeinstall macro was causing those problems. the localedir wasn't correctly assigned on the po folders. Use my spec file (attached)
(In reply to comment #13) > Ok, ill have a look at it. > I feel you are having problems with it, do you mind that I co-package prozilla > with you in FE ? You are welcome :) Sorry for the late reply
I've committed the new changes to the already available prozilla package in FE. The builds were successful on FC-5,FC-6 and devel. I'll invite you to have a look at the spec file. I'm now closing this bug.