Bug 2099999 - Add support for --package-metadata linker option
Summary: Add support for --package-metadata linker option
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: package-notes
Version: 36
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Zbigniew Jędrzejewski-Szmek
QA Contact:
URL:
Whiteboard:
Depends On:
Blocks: 2055458 2055863 2059858
TreeView+ depends on / blocked
 
Reported: 2022-06-22 07:36 UTC by Andreas Schneider
Modified: 2022-09-03 16:20 UTC (History)
4 users (show)

Fixed In Version: package-notes-0.5-4.fc37
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2022-09-03 16:20:46 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)

Description Andreas Schneider 2022-06-22 07:36:51 UTC
Description of problem:

Please add support for the --package-metadata linker option. This has been agreed on between ld.bfd and ld.mold.

See discussion at: https://github.com/rui314/mold/issues/505

ld.mold commit:
https://github.com/rui314/mold/commit/e9f6715c6ef01b5bf02dc8bf36bce8af4f07b44e

ld.bfd commit:
https://sourceware.org/git/?p=binutils-gdb.git;a=commit;h=9e2bb0cb5e74aed4158f08495534922d7108f928

Comment 1 Luca Boccassi 2022-06-22 11:45:58 UTC
It's on my to-do, but I was waiting for ld.gold as well, I sent a patch for it last month but haven't received any answer yet: https://sourceware.org/pipermail/binutils/2022-May/121060.html

Comment 2 Luca Boccassi 2022-08-02 10:53:36 UTC
Reminder that this is still blocked waiting on ld.gold https://sourceware.org/pipermail/binutils/2022-July/122097.html
Any chance the maintainers who are in RedHat could be asked to have a quick look?

I can then provide the required backports for Fedora Rawhide, and then the package can use this.

Comment 3 Andreas Schneider 2022-08-03 13:37:33 UTC
Nick, can you comment on comment #2 ?

Comment 4 Nick Clifton 2022-08-04 09:51:36 UTC
OK, so I try not to act as a maintainer for the upstream ld.gold linker because I am not a C++ programmer, so I am not going to review/approve Luca's upstream patch.

But - I am perfectly happy to have the patches applied to the Fedora binutils.  So a will do this later on today.

Comment 5 Luca Boccassi 2022-08-04 10:20:53 UTC
Thanks Nick, sounds good - there was already a review from Cary Coutant: https://sourceware.org/pipermail/binutils/2022-July/122093.html
Who else can we ask to have a look? Looking at the git log you seem to be one of the most common contributors to gold/, is there another maintainer we can ask?

Comment 6 Nick Clifton 2022-08-04 12:55:55 UTC
Fixed in binutils-2.38-23.fc37.

We are working on updating the f36 and f35 binutils with the patch and they should be ready soon.

(In reply to Luca Boccassi from comment #5)
> Thanks Nick, sounds good - there was already a review from Cary Coutant:
> https://sourceware.org/pipermail/binutils/2022-July/122093.html
> Who else can we ask to have a look? Looking at the git log you seem to be
> one of the most common contributors to gold/, is there another maintainer we
> can ask?

Try asking Ian Taylor - he is one of the maintainers for gold.

Comment 7 Luca Boccassi 2022-08-04 13:23:01 UTC
(In reply to Nick Clifton from comment #6)
> Fixed in binutils-2.38-23.fc37.
> 
> We are working on updating the f36 and f35 binutils with the patch and they
> should be ready soon.

Thank you - does that include the corresponding change in ld.bfd as well?

> (In reply to Luca Boccassi from comment #5)
> > Thanks Nick, sounds good - there was already a review from Cary Coutant:
> > https://sourceware.org/pipermail/binutils/2022-July/122093.html
> > Who else can we ask to have a look? Looking at the git log you seem to be
> > one of the most common contributors to gold/, is there another maintainer we
> > can ask?
> 
> Try asking Ian Taylor - he is one of the maintainers for gold.

Will do, thanks.

Comment 8 Zbigniew Jędrzejewski-Szmek 2022-08-09 09:27:17 UTC
https://src.fedoraproject.org/rpms/package-notes/pull-request/4

Comment 9 Luca Boccassi 2022-08-09 09:35:26 UTC
(In reply to Luca Boccassi from comment #7)
> (In reply to Nick Clifton from comment #6)
> > (In reply to Luca Boccassi from comment #5)
> > > Thanks Nick, sounds good - there was already a review from Cary Coutant:
> > > https://sourceware.org/pipermail/binutils/2022-July/122093.html
> > > Who else can we ask to have a look? Looking at the git log you seem to be
> > > one of the most common contributors to gold/, is there another maintainer we
> > > can ask?
> > 
> > Try asking Ian Taylor - he is one of the maintainers for gold.
> 
> Will do, thanks.

To close the loop support in ld.gold was merged, so binutils 2.39 supports this in ld.gold and ld.bfd.

Comment 10 Nick Clifton 2022-08-09 14:31:25 UTC
FYI The patch has been backported to binutils-2.37-34.fc36 and binutils-2.37-23.fc35


Note You need to log in before you can comment on or make changes to this bug.