Spec URL: https://martinkg.fedorapeople.org/Review/SPECS/vdr-tvscraper.spec SRPM URL: https://martinkg.fedorapeople.org/Review/SRPMS/vdr-tvscraper-1.0.4-1.fc36.src.rpm Description: TVScraper runs in the background and collects metadata (posters, banners, fanart, actor thumbs and roles, descriptions) for all available EPG events on selectable channels and for recordings. Additionally the plugin provides the collected metadata via the VDR service interface to other plugins which deal with EPG information. TVScraper uses the thetvdb.com API for collecting series metadata and themoviedb.org API for movies. Check the websites of both services for the terms of use. Important: To avoid unnecessary traffic, only activate these channels to be scrapped which are reasonable. After plugin installation all channels are deactivated by default, so please consider this point when you activate the channels you are interested in ;) Additionally you are invited to contribute to the used web services with providing missing data for your favorite movies and series. Fedora Account System Username: martinkg rawhide koji build: https://koji.fedoraproject.org/koji/taskinfo?taskID=88592680 rpmlint -v vdr-tvscraper.spec /home/martin/rpmbuild/SRPMS/vdr-tvscraper-1.0.4-1.fc36.src.rpm /home/martin/rpmbuild/RPMS/x86_64/vdr-tvscraper-1.0.4-1.fc36.x86_64.rpm /home/martin/rpmbuild/RPMS/x86_64/vdr-tvscraper-debugsource-1.0.4-1.fc36.x86_64.rpm /home/martin/rpmbuild/RPMS/x86_64/vdr-tvscraper-debuginfo-1.0.4-1.fc36.x86_64.rpm 886 blocks 7235 blocks 623 blocks 158 blocks =========================================================================================================== rpmlint session starts =========================================================================================================== rpmlint: 2.2.0 configuration: /usr/lib/python3.10/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/licenses.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 32, packages: 5 vdr-tvscraper-debuginfo.x86_64: W: unstripped-binary-or-object /usr/lib/debug/usr/lib64/vdr/libvdr-tvscraper.so.2.6.1-1.0.4-1.fc36.x86_64.debug This executable should be stripped from debugging symbols, in order to take less space and be loaded faster. This is usually done automatically at buildtime by rpm. vdr-tvscraper-debuginfo.x86_64: E: shared-library-without-dependency-information /usr/lib/debug/usr/lib64/vdr/libvdr-tvscraper.so.2.6.1-1.0.4-1.fc36.x86_64.debug The listed shared library doesn't include information about which other libraries the library was linked against. vdr-tvscraper-debuginfo.x86_64: W: no-documentation vdr-tvscraper-debugsource.x86_64: W: no-documentation The package contains no documentation (README, doc, etc). You have to include documentation files. vdr-tvscraper-debuginfo.x86_64: W: dangling-relative-symlink /usr/lib/debug/.build-id/59/2317133b2893d61edb02d586ae338f03df02c1 ../../../.build-id/59/2317133b2893d61edb02d586ae338f03df02c1 The target of the symbolic link does not exist within this package or its file based dependencies. Verify spelling of the link target and that the target is included in a package in this package's dependency chain. ============================================================================ 4 packages and 1 specfiles checked; 1 errors, 4 warnings, 1 badness; has taken 1.3 s ============================================================================
I could review this one, I'll not set the flag just yet. Two things I noticed after going through the package for the first time: - After you submitted the package for review, 1.1.0 has been tagged. If there's no specific reason for staying with 1.0.4, please update the package. - fedora-review found out that the package does not own the directory /etc/vdr/plugins/tvscraper (I use VDR but not on Fedora, so I know quite a bit about how it works, but I won't be able to set up an installation to actually test the plugin. That's not required by the review guidelines, though.)
Thanks for your coment: > (...but I won't be able to set up an installation to actually test the plugin. That's not required by the review guidelines, though.) That's correct. New package: Spec URL: https://martinkg.fedorapeople.org/Review/SPECS/vdr-tvscraper.spec SRPM URL: https://martinkg.fedorapeople.org/Review/SRPMS/vdr-tvscraper-1.1.1-1.fc36.src.rpm %changelog * Sun Aug 07 2022 Martin Gansser <martinkg> - 1.1.1-1 - Update to 1.1.1-1 - Added %%dir %%{vdr_configdir}/plugins/%%{pname} because it's owned by the package
Two things I found: - Please change the License field to SPDX, so I believe it should be "GPL-2.0-or-later AND MIT". - I think you should add "BuildRequires: gettext" even though the build seems to work without it.
new package: Spec URL: https://martinkg.fedorapeople.org/Review/SPECS/vdr-tvscraper.spec SRPM URL: https://martinkg.fedorapeople.org/Review/SRPMS/vdr-tvscraper-1.1.1-1.fc36.src.rpm %changelog * Tue Aug 09 2022 Martin Gansser <martinkg> - 1.1.1-2 - Update license tag to "GPL-2.0-or-later AND MIT" - Add BR gettext
The SRPM and the .spec don't match but that's not a problem really. Please remember to use the new spec/SRPM when committing the package to dist-git. Package approved! Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated ===== MUST items ===== C/C++: [x]: Package does not contain kernel modules. [x]: Package contains no static executables. [x]: If your application is a C or C++ application you must list a BuildRequires against gcc, gcc-c++ or clang. [x]: Header files in -devel subpackage, if present. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: I think licensing is clear with this package. By following its development I've seen that upstream has a bit of a cowboy coding style. I will not require adding license headers to every file. [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [x]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: The spec file handles locales properly. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [x]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: %config files are marked noreplace or the reason is justified. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: No %config files under /usr. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [x]: Final provides and requires are sane (see attachments). [?]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [?]: Package should compile and build into binary rpms on all supported architectures. [-]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Fully versioned dependency in subpackages if applicable. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on debuginfo package(s). [x]: Rpmlint is run on all installed packages. [x]: Spec file according to URL is the same as in SRPM. Source checksums ---------------- https://github.com/MarkusEh/vdr-plugin-tvscraper/archive/refs/tags/v1.1.1.tar.gz#/tvscraper-1.1.1.tar.gz : CHECKSUM(SHA256) this package : fb604e3eeb745fb90ab7cb7ddefb95471eef663e14093c590677bb3b7f803dbc CHECKSUM(SHA256) upstream package : fb604e3eeb745fb90ab7cb7ddefb95471eef663e14093c590677bb3b7f803dbc Requires -------- vdr-tvscraper (rpmlib, GLIBC filtered): config(vdr-tvscraper) libc.so.6()(64bit) libcurl.so.4()(64bit) libgcc_s.so.1()(64bit) libgcc_s.so.1(GCC_3.0)(64bit) libgcc_s.so.1(GCC_3.3.1)(64bit) libjansson.so.4()(64bit) libm.so.6()(64bit) libsqlite3.so.0()(64bit) libstdc++.so.6()(64bit) libstdc++.so.6(CXXABI_1.3)(64bit) libstdc++.so.6(CXXABI_1.3.9)(64bit) libxml2.so.2()(64bit) libxml2.so.2(LIBXML2_2.4.30)(64bit) libxml2.so.2(LIBXML2_2.6.0)(64bit) rtld(GNU_HASH) vdr(abi)(x86-64) vdr-tvscraper-debuginfo (rpmlib, GLIBC filtered): vdr-tvscraper-debugsource (rpmlib, GLIBC filtered): Provides -------- vdr-tvscraper: config(vdr-tvscraper) libvdr-tvscraper.so.2.6.1()(64bit) vdr-tvscraper vdr-tvscraper(x86-64) vdr-tvscraper-debuginfo: debuginfo(build-id) libvdr-tvscraper.so.2.6.1-1.1.1-1.fc37.x86_64.debug()(64bit) vdr-tvscraper-debuginfo vdr-tvscraper-debuginfo(x86-64) vdr-tvscraper-debugsource: vdr-tvscraper-debugsource vdr-tvscraper-debugsource(x86-64) Generated by fedora-review 0.8.0 (e988316) last change: 2022-04-07 Command line :/usr/bin/fedora-review -b 2100141 Buildroot used: fedora-rawhide-x86_64 Active plugins: Generic, Shell-api, C/C++ Disabled plugins: fonts, PHP, R, Haskell, Perl, Java, Python, Ocaml, SugarActivity Disabled flags: EPEL6, EPEL7, DISTTAG, BATCH, EXARCH
Thanks for reviewing the ticket.
(fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/vdr-tvscraper
successfully built on f35-rawhide.