Bug 2100908 - Backport 1.3.1 or higher to Fedora 36
Summary: Backport 1.3.1 or higher to Fedora 36
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: python-websocket-client
Version: 36
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Major Hayden 🤠
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2022-06-24 16:11 UTC by Major Hayden 🤠
Modified: 2022-07-28 01:26 UTC (History)
3 users (show)

Fixed In Version: python-websocket-client-1.3.2-2.fc36
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2022-07-28 01:26:48 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)

Description Major Hayden 🤠 2022-06-24 16:11:03 UTC
azure-cli now requires websocket-client >= 1.3.1 in the latest releases. Would it be possible to backport a newer version of websocket-client to Fedora 36?

Comment 1 Carl George 🤠 2022-06-29 18:10:00 UTC
That would involve an update from 1.2.3 to 1.3.2.  Upstream says 1.3.0 contains a breaking change.

- BREAKING: Set Origin header to use https:// scheme when wss:// WebSocket URL is passed (#787)

https://github.com/websocket-client/websocket-client/blob/v1.3.2/ChangeLog#L16
https://github.com/websocket-client/websocket-client/commit/330e43ae07e23eadd654c86a0a7b3554b68b1999

Looking over the change it doesn't seem like a big deal to me, but I'm not that familiar with the code base.  Checking other packages in F36, there is only one that has an upper limited dependency on websocket-client.  Updating to 1.3.2 would still be compatible with that requirement.

[root@f36-container:~]# repoquery -q --requires python3-streamlink | grep websocket
(python3.10dist(websocket-client) < 2~~ with python3.10dist(websocket-client) >= 1.2.1)

What do you think, should we go forward with this potentially breaking update?

Comment 2 Major Hayden 🤠 2022-06-29 19:13:18 UTC
That's a good question. Just to be a little more confident, I chucked the rawhide version of websocket-client into COPR and built all of the packages that require websocket-client. They all seem to be building/testing okay.

https://copr.fedorainfracloud.org/coprs/mhayden/rhbz2100908/monitor/

Comment 3 Carl George 🤠 2022-06-29 20:54:05 UTC
Excellent.  You're already a maintainer on that package, so feel free to proceed and merge the rawhide branch back to f36, build it, and create an update.  I would suggest disabling auto-push so it stays in testing for at least a week, if not two.

Comment 4 Major Hayden 🤠 2022-06-30 12:26:12 UTC
Can do. Thanks, Carl!

Comment 5 Major Hayden 🤠 2022-06-30 12:28:58 UTC
Waiting on CI in PR: https://src.fedoraproject.org/rpms/python-websocket-client/pull-request/10

Comment 6 Fedora Update System 2022-06-30 12:42:22 UTC
FEDORA-2022-1a05348b42 has been submitted as an update to Fedora 36. https://bodhi.fedoraproject.org/updates/FEDORA-2022-1a05348b42

Comment 7 Fedora Update System 2022-07-01 02:10:09 UTC
FEDORA-2022-1a05348b42 has been pushed to the Fedora 36 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf upgrade --enablerepo=updates-testing --refresh --advisory=FEDORA-2022-1a05348b42`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2022-1a05348b42

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 8 Fedora Update System 2022-07-28 01:26:48 UTC
FEDORA-2022-1a05348b42 has been pushed to the Fedora 36 stable repository.
If problem still persists, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.