Red Hat Bugzilla – Bug 210117
Review Request: perl-aliased - Use shorter versions of class names
Last modified: 2007-11-30 17:11:45 EST
SRPM URL: http://home.comcast.net/~ckweyl/perl-aliased-0.20-1.fc5.src.rpm
SPEC URL: http://home.comcast.net/~ckweyl/perl-aliased.spec
aliased is simple in concept but is a rather handy module. It loads the
class you specify and exports into your namespace a subroutine that returns
the class name. You can explicitly alias the class to another name or, if
you prefer, you can do so implicitly. In the latter case, the name of the
subroutine is the last part of the class name.
My apologies for taking so long with this; the past couple of days have been
* source files match upstream:
* package meets naming and packaging guidelines.
* specfile is properly named, is cleanly written and uses macros consistently.
* dist tag is present.
* build root is correct.
* license field matches the actual license.
* license is open source-compatible. License text not included upstream.
* latest version is being packaged.
* BuildRequires are proper.
* %clean is present.
* package builds in mock (development, x86_64).
* package installs properly
* rpmlint is silent.
* final provides and requires are sane:
perl(aliased) = 0.20
perl-aliased = 0.20-1.fc6
* %check is present and all tests pass:
All tests successful.
Files=4, Tests=23, 0 wallclock secs ( 0.17 cusr + 0.05 csys = 0.22 CPU)
* owns the directories it creates.
* doesn't own any directories it shouldn't.
* no duplicates in %files.
* file permissions are appropriate.
* no scriptlets present.
* code, not content.
* documentation is small, so no -docs subpackage is necessary.
* %docs are not necessary for the proper functioning of the package.
Imported and built for devel. Branch request for FC-5...
Thanks for the review! :)