Bug 2101501 - NAME parameter in VM template has no effect.
Summary: NAME parameter in VM template has no effect.
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Container Native Virtualization (CNV)
Classification: Red Hat
Component: User Experience
Version: 4.11.0
Hardware: Unspecified
OS: Unspecified
unspecified
medium
Target Milestone: ---
: 4.12.0
Assignee: Hilda Stastna
QA Contact: Leon Kladnitsky
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2022-06-27 15:54 UTC by Leon Kladnitsky
Modified: 2023-01-24 13:37 UTC (History)
2 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2023-01-24 13:37:24 UTC
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)
remove value from template name parameter (151.24 KB, image/png)
2022-06-30 07:36 UTC, Guohua Ouyang
no flags Details


Links
System ID Private Priority Status Summary Last Updated
Github kubevirt-ui kubevirt-plugin pull 787 0 None open [WIP] Bug 2101501: Display VM name in Create VM drawer according to the NAME 2022-07-25 21:37:31 UTC
Red Hat Issue Tracker CNV-19386 0 None None None 2022-10-26 20:30:31 UTC
Red Hat Product Errata RHSA-2023:0408 0 None None None 2023-01-24 13:37:37 UTC

Description Leon Kladnitsky 2022-06-27 15:54:15 UTC
Description of problem: When custom template is created and NAME parameter is set to some value or None it has no effect - the VM name is still randomized


Version-Release number of selected component (if applicable):


How reproducible:


Steps to Reproduce:
1. Clone any RHEL template to default NS. Edit cloned template Parameters tab
2. Check NAME and set to some Value to whatever
3. Go to Virtualization Catalog and select cloned template.

Actual results: VM name is randomized


Expected results: VM name should be set to value of template NAME parameter


Additional info:

Comment 1 Guohua Ouyang 2022-06-30 07:36:01 UTC
Created attachment 1893553 [details]
remove value from template name parameter

The fix of this bug is removing option "value" from template name parameter

Comment 3 Guohua Ouyang 2022-07-12 12:51:26 UTC
(In reply to Hilda Stastna from comment #2)
> Hi Guohua,
> 
> are you sure that the fix is to remove option "Value" from template name
> parameter?
> I think this option makes sense to be there to set the specific name for the
> VM
> that will be created from that template, and removing that option solves
> nothing,
> as I've found that none of the options work as expected. Did you try to
> choose
> also the "Generated" or "None" option? Did you try to put there some
> expression?
> Did it work for you as expected? Thank you!


It does not make sense to set the VM name in the template, the result is user can create only one VM from this template.
I think the best solution is disabling or removing the value option here, options "Generated" and "None" are fine as the catalog generate vm name. But if you can come up with a better solution, I have no problem at all. Comment #1 is my suggestion.

Comment 4 Hilda Stastna 2022-07-13 12:50:04 UTC
Options "Generated" and "None" do the same thing (or better said, choosing any of those options has no any effect on the VM name),
so I think this feature won't work correctly even without the "Value" option. And so this "Value" option to set the specific VM
name in the template still makes sense to me to be there. There must be a reason why it is there, in the new UI. I think it was
a part of the new UI design, so probably we don't want to remove it (but I'll check that to make sure). And if the user set the same
VM name as the name of some other already existing VM, they could be warned and forced to set some different name. I don't see any
problem here. But I will reconsider this all.
Thank you for your notes and suggestions, Guohua.

Comment 5 Leon Kladnitsky 2022-10-26 20:18:14 UTC
The bug is fixed, you need to manually move this bug to ON_QA, so it can be verified.

Comment 6 Leon Kladnitsky 2022-10-27 08:37:17 UTC
Verified on v4.12.0-147

Comment 10 errata-xmlrpc 2023-01-24 13:37:24 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (Important: OpenShift Virtualization 4.12.0 Images security update), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHSA-2023:0408


Note You need to log in before you can comment on or make changes to this bug.