Note: This bug is displayed in read-only format because the product is no longer active in Red Hat Bugzilla.

Bug 2101525

Summary: [4.12] add Intel E810 NIC model (1591) support in SR-IOV Operator
Product: OpenShift Container Platform Reporter: Dave Cain <dcain>
Component: NetworkingAssignee: Dave Cain <dcain>
Networking sub component: SR-IOV QA Contact: zhaozhanqi <zzhao>
Status: CLOSED ERRATA Docs Contact:
Severity: high    
Priority: high CC: bnemeth, dbatliwa, ealcaniz, eglottma, jboxman, jjung, jnunez, sscheink, tvvcox, yiwwang, zshi
Version: 4.12   
Target Milestone: ---   
Target Release: 4.12.0   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2023-01-17 19:45:58 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Dave Cain 2022-06-27 17:28:04 UTC
Description of problem:
The Intel series of E810 cards with a 1591 PF ID need to be added to the supported card listing in OpenShift. This PCI ID belongs to Intel (https://www.pcilookup.com/?ven=8086&dev=1591&action=submit).

Cards have Vendor ID 8086, PF 1591, and VF of 1889.

Note: Silicom TimeSync cards (STS2, STS4, etc) contain this embedded E810 in those particular network adapters.

Cards were tested internally in Red Hat and found to be passing. Request of this PR is to get them to the supported list of devices.


Actual results:
Card is currently not on the supported device list.


Expected results:
Card on the supported device list.


Additional info:
https://www.silicom-usa.com/pr/server-adapters/networking-adapters/10-gigabit-ethernet-networking-adapters/p410g8ts81-timesync-server-adapter/
https://www.silicom-usa.com/pr/server-adapters/networking-adapters/25-gigabit-ethernet-networking-server-adapters/p425g410g8ts81-timesync-card-sts4/

Comment 1 Balazs Nemeth 2022-06-29 08:47:53 UTC
I've added comments to the PR. I don't see any issues with backporting this. Once the comments have been resolved, the PR can be merged.

Comment 2 Dave Cain 2022-06-29 10:47:00 UTC
(In reply to Balazs Nemeth from comment #1)
> I've added comments to the PR. I don't see any issues with backporting this.
> Once the comments have been resolved, the PR can be merged.

Thanks much Balazs.

Comment 4 Dave Cain 2022-07-06 14:39:11 UTC
Will OpenShift documentation be taken care of here (adding this PF ID so documentation is accurate), or is there separate work (doc PR, etc) that needs to be done?

Found this PR:
https://github.com/openshift/openshift-docs/pull/43206/files

Adding Jason Boxman from Red Hat here.  Jason, could you help advise how doc should be updated here?

Comment 5 Jason Boxman 2022-07-11 16:29:53 UTC
Interesting; I can add this to our list of epics[0] for 4.12.

[0] https://issues.redhat.com/browse/OSDOCS-3820

Comment 6 zhaozhanqi 2022-08-11 05:35:22 UTC
QE do not have this card for verifying this bug. However base on `Cards were tested internally in Red Hat and found to be passing. Request of this PR is to get them to the supported list of devices.`

Move this bug to verified.

Comment 7 Jason Boxman 2022-09-12 16:00:15 UTC
Does this card have a particular friendly name, such as for example E810-2CQDA2 or E810-XXVDA2? If we list it as just 'E810' it will probably be a bit confusing, because we fully qualify the other variants of this chipset. Or is this actually a Silicom TimeSync card(s)?

Thanks!

Comment 8 Dave Cain 2022-09-15 12:06:48 UTC
Hi Jason, these cards are indeed Silicom cards, which are available products in the market that can be purchased direct from Silicom or through authorized third party sellers.  If you are asking about what to put in https://docs.openshift.com/container-platform/4.12/networking/hardware_networks/about-sriov.html#supported-devices_about-sriov, I would suggest either

Manufacturer	Model			Vendor ID	Device ID
Silicom		STS2 P410G8TS81		8086		1591
Silicom		STS4 P425G410G8TS81	8086		1591

-or-

Manufacturer	Model			Vendor ID	Device ID
Silicom		STS Family		8086		1591

I would lean more towards the second option in terms of granularity, but the first is also technically accurate.  What is critical for SR-IOV is (my understanding) the Vendor and PF (Device ID) for SR-IOV functionality.  Please do reach out if I can help clarify further.

Comment 11 errata-xmlrpc 2023-01-17 19:45:58 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (OpenShift Container Platform 4.12.0 extras update), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2022:7400

Comment 12 Red Hat Bugzilla 2023-09-18 04:40:23 UTC
The needinfo request[s] on this closed bug have been removed as they have been unresolved for 120 days