Bug 2103007 - Review Request: perl-Type-Tiny-XS - Provides an XS boost for some of Type::Tiny's built-in type constraints
Summary: Review Request: perl-Type-Tiny-XS - Provides an XS boost for some of Type::T...
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Jitka Plesnikova
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2022-07-01 07:14 UTC by Ralf Corsepius
Modified: 2022-11-27 02:13 UTC (History)
3 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2022-11-18 07:53:38 UTC
Type: ---
Embargoed:
jplesnik: fedora-review+


Attachments (Terms of Use)

Description Ralf Corsepius 2022-07-01 07:14:49 UTC
Spec URL: https://corsepiu.fedorapeople.org/packages/perl-Type-Tiny-XS.spec
SRPM URL: https://corsepiu.fedorapeople.org/packages/perl-Type-Tiny-XS-0.022-1.fc37.src.rpm
Description:
This module is optionally used by Type::Tiny 0.045_03 and above to provide
faster, C-based implementations of some type constraints. (This package has
only core dependencies, and does not depend on Type::Tiny, so other data
validation frameworks might also consider using it!

Fedora Account System Username: corsepiu

Comment 1 Jitka Plesnikova 2022-11-08 14:59:18 UTC
Please update the package to version 0.025 and also update the license tag. Then I'll start the review.

Comment 3 Jitka Plesnikova 2022-11-11 12:28:25 UTC
Source file is ok
Summary is ok
License is ok
Description is ok
URL and Source0 are ok
All tests passed

BuildRequires
FIX: Please add build-requires:
     perl(File::Copy) - Makefile.PL:75
     perl(File::Spec) - Makefile.PL:76
     perl(overload) - Type-Tiny-XS-0.025/t/10bool.t:37

$ rpm -qp --requires perl-Type-Tiny-XS-0.025-1.fc38.x86_64.rpm | sort | uniq -c | grep -v rpmlib
      1 ld-linux-x86-64.so.2()(64bit)
      1 ld-linux-x86-64.so.2(GLIBC_2.3)(64bit)
      1 libc.so.6()(64bit)
      1 libc.so.6(GLIBC_2.2.5)(64bit)
      1 libc.so.6(GLIBC_2.3.4)(64bit)
      1 libc.so.6(GLIBC_2.4)(64bit)
      1 libperl.so.5.36()(64bit)
      1 perl(:MODULE_COMPAT_5.36.0)
      1 perl(Scalar::Util)
      1 perl(strict)
      1 perl(Type::Tiny::XS)
      1 perl(:VERSION) >= 5.8.5
      1 perl(warnings)
      1 perl(XSLoader)
      1 rtld(GNU_HASH)
Binary requires are Ok.
TODO: Please consider to add run-requires 'perl(Type::Parser)'

$ rpm -qp --provides perl-Type-Tiny-XS-0.025-1.fc38.x86_64.rpm | sort | uniq -c
      1 perl(Type::Tiny::XS) = 0.025
      1 perl-Type-Tiny-XS = 0.025-1.fc38
      1 perl(Type::Tiny::XS::Util) = 0.025
      1 perl-Type-Tiny-XS(x86-64) = 0.025-1.fc38
Binary provides are Ok.

$ rpmlint ./perl-Type-Tiny-XS*
========================= rpmlint session starts =======================================
rpmlint: 2.2.0
configuration:
    /usr/lib/python3.10/site-packages/rpmlint/configdefaults.toml
    /etc/xdg/rpmlint/fedora-legacy-licenses.toml
    /etc/xdg/rpmlint/fedora-spdx-licenses.toml
    /etc/xdg/rpmlint/fedora.toml
    /etc/xdg/rpmlint/licenses.toml
    /etc/xdg/rpmlint/scoring.toml
    /etc/xdg/rpmlint/users-groups.toml
    /etc/xdg/rpmlint/warn-on-functions.toml
checks: 32, packages: 3
= 2 packages and 1 specfiles checked; 0 errors, 0 warnings, 0 badness; has taken 0.9 s =
Rpmlint is ok

Otherwise the package is in line with Fedora and Perl packaging guide lines.
Please correct all 'FIX' items, consider fixing 'TODO' item.

Resolution:
Approved

Comment 4 Gwyn Ciesla 2022-11-14 15:01:31 UTC
(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/perl-Type-Tiny-XS

Comment 5 Paul Howarth 2022-11-17 10:29:06 UTC
Hi Ralf, could you please add me (FAS: pghmcfc) as contributor for epel branches of this package?

Comment 6 Ralf Corsepius 2022-11-18 07:53:10 UTC
(In reply to Paul Howarth from comment #5)
> Hi Ralf, could you please add me (FAS: pghmcfc) as contributor for epel
> branches of this package?

Done. I made you collaborator and BZ-contact for epel*.

Comment 7 Fedora Update System 2022-11-18 16:12:44 UTC
FEDORA-EPEL-2022-e93efcf19a has been submitted as an update to Fedora EPEL 9. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2022-e93efcf19a

Comment 8 Paul Howarth 2022-11-18 16:13:24 UTC
Thanks Ralf.

Comment 9 Fedora Update System 2022-11-19 03:09:55 UTC
FEDORA-EPEL-2022-e93efcf19a has been pushed to the Fedora EPEL 9 testing repository.

You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2022-e93efcf19a

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 10 Fedora Update System 2022-11-27 02:13:11 UTC
FEDORA-EPEL-2022-e93efcf19a has been pushed to the Fedora EPEL 9 stable repository.
If problem still persists, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.