Bug 2103401 - Review Request: magicmirror-module-airnow - MagicMirror² module to show air quality based on the US AirNow API
Summary: Review Request: magicmirror-module-airnow - MagicMirror² module to show air q...
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Michel Lind
QA Contact: Fedora Extras Quality Assurance
URL: %{forgeurl}
Whiteboard:
Depends On: 2103400
Blocks:
TreeView+ depends on / blocked
 
Reported: 2022-07-02 23:03 UTC by Davide Cavalca
Modified: 2023-07-28 02:40 UTC (History)
2 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2023-07-18 14:42:56 UTC
Type: ---
Embargoed:
michel: fedora-review+


Attachments (Terms of Use)

Description Davide Cavalca 2022-07-02 23:03:12 UTC
Spec URL: https://dcavalca.fedorapeople.org/review/magicmirror-module-airnow/magicmirror-module-airnow.spec
SRPM URL: https://dcavalca.fedorapeople.org/review/magicmirror-module-airnow/magicmirror-module-airnow-1.0.0^20200824gitefddeb3-1.fc37.src.rpm

Description:
This is a module for the MagicMirror. This module shows air quality based on
the US AirNow API.

Fedora Account System Username: dcavalca

Comment 1 Davide Cavalca 2023-03-21 02:56:38 UTC
Spec URL: https://dcavalca.fedorapeople.org/review/magicmirror-module-airnow/magicmirror-module-airnow.spec
SRPM URL: https://dcavalca.fedorapeople.org/review/magicmirror-module-airnow/magicmirror-module-airnow-1.0.0^20200824gitefddeb3-1.fc39.src.rpm

Changelog:
- convert License tag to SPDX
- drop usage of magicmirror-rpm-macros as they don't actually work

Comment 2 Jakub Kadlčík 2023-03-21 03:02:15 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/5687547
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2103401-magicmirror-module-airnow/fedora-rawhide-x86_64/05687547-magicmirror-module-airnow/fedora-review/review.txt

Please take a look if any issues were found.

---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 3 Michel Lind 2023-07-17 20:41:00 UTC
LGTM, APPROVED. Most of the issues are because of:

- bundling -- consider adding rpmlint configs to suppress these, but maybe we should bring this up in devel as it affects other NodeJS packages due to bundling being the norm
- fedora-review being done against F38 since it can't work with dnf5's repoquery right now

Consider adding explanation to how bundled-license.txt was created. Technically the license breakdown needs to describe which bundled modules is covered by which license (the same way the Rust dependency generator does) but since that's automated, the onus should be on the generator script to be fixed to do that correctly, not on this package.

Package Review
==============

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed


Issues:
=======
- If (and only if) the source package includes the text of the license(s)
  in its own file, then that file, containing the text of the license(s)
  for the package is included in %license.
  Note: License file LICENSE.txt is not marked as %license
  See: https://docs.fedoraproject.org/en-US/packaging-
  guidelines/LicensingGuidelines/#_license_text


===== MUST items =====

Generic:
[x]: Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
     Guidelines.
[x]: License field in the package spec file matches the actual license.
     Note: Checking patched sources after %prep for licenses. Licenses
     found: "MIT License", "Unknown or generated", "*No copyright* MIT
     License". 7 files have unknown license. Detailed output of
     licensecheck in
     /home/michel/src/fedora/reviews/davide/2103401-magicmirror-module-
     airnow/licensecheck.txt
[!]: If the package is under multiple licenses, the licensing breakdown
     must be documented in the spec.
     => probably document how bundled-licenses.txt was generated
[x]: Package requires other packages for directories it uses.
     Note: No known owner of /usr/lib/node_modules_18/magicmirror,
     /usr/lib/node_modules_18/magicmirror/modules
     => this is fine, had to build on F38 because of fedora-review repoquery issues with DNF5 but on Rawhide /usr/lib/node_modules_20/magicmirror exists
[x]: Package must own all directories that it creates.
     Note: Directories without known owners:
     /usr/lib/node_modules_18/magicmirror,
     /usr/lib/node_modules_18/magicmirror/modules
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
     names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
     Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Large documentation must go in a -doc subpackage. Large could be size
     (~1MB) or number of files.
     Note: Documentation size is 10240 bytes in 1 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
     one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
     Note: There are rpmlint messages (see attachment).
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package must not depend on deprecated() packages.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
     work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
     provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
     %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

===== SHOULD items =====

Generic:
[-]: If the source package does not include license text(s) as a separate
     file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[?]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[-]: Sources are verified with gpgverify first in %prep if upstream
     publishes signatures.
     Note: gpgverify is not used.
[x]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed
     files.
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
     $RPM_BUILD_ROOT)
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: SourceX is a working URL.
[x]: Package should compile and build into binary rpms on all supported
     architectures.
[x]: Spec use %global instead of %define unless justified.

===== EXTRA items =====

Generic:
[x]: Rpmlint is run on all installed packages.
     Note: There are rpmlint messages (see attachment).
[x]: Spec file according to URL is the same as in SRPM.


Rpmlint
-------
Checking: magicmirror-module-airnow-1.0.0^20200824gitefddeb3-1.fc38.noarch.rpm
          magicmirror-module-airnow-1.0.0^20200824gitefddeb3-1.fc38.src.rpm
====================================================== rpmlint session starts ======================================================
rpmlint: 2.4.0
configuration:
    /usr/lib/python3.11/site-packages/rpmlint/configdefaults.toml
    /etc/xdg/rpmlint/fedora-legacy-licenses.toml
    /etc/xdg/rpmlint/fedora-spdx-licenses.toml
    /etc/xdg/rpmlint/fedora.toml
    /etc/xdg/rpmlint/scoring.toml
    /etc/xdg/rpmlint/users-groups.toml
    /etc/xdg/rpmlint/warn-on-functions.toml
rpmlintrc: [PosixPath('/tmp/tmpt06fomjk')]
checks: 31, packages: 2

magicmirror-module-airnow.noarch: E: zero-length /usr/lib/node_modules_18/magicmirror/modules/MMM-AirNow/node_modules_prod/extsprintf/.gitmodules
magicmirror-module-airnow.noarch: E: script-without-shebang /usr/lib/node_modules_18/magicmirror/modules/MMM-AirNow/node_modules_prod/ecc-jsbn/package.json
magicmirror-module-airnow.noarch: E: script-without-shebang /usr/lib/node_modules_18/magicmirror/modules/MMM-AirNow/node_modules_prod/uri-js/dist/es5/uri.all.js.map
magicmirror-module-airnow.noarch: E: script-without-shebang /usr/lib/node_modules_18/magicmirror/modules/MMM-AirNow/node_modules_prod/uri-js/dist/es5/uri.all.min.js.map
magicmirror-module-airnow.noarch: E: script-without-shebang /usr/lib/node_modules_18/magicmirror/modules/MMM-AirNow/node_modules_prod/uri-js/dist/esnext/index.js.map
magicmirror-module-airnow.noarch: E: script-without-shebang /usr/lib/node_modules_18/magicmirror/modules/MMM-AirNow/node_modules_prod/uri-js/dist/esnext/regexps-iri.js.map
magicmirror-module-airnow.noarch: E: script-without-shebang /usr/lib/node_modules_18/magicmirror/modules/MMM-AirNow/node_modules_prod/uri-js/dist/esnext/regexps-uri.js.map
magicmirror-module-airnow.noarch: E: script-without-shebang /usr/lib/node_modules_18/magicmirror/modules/MMM-AirNow/node_modules_prod/uri-js/dist/esnext/schemes/http.js.map
magicmirror-module-airnow.noarch: E: script-without-shebang /usr/lib/node_modules_18/magicmirror/modules/MMM-AirNow/node_modules_prod/uri-js/dist/esnext/schemes/https.js.map
magicmirror-module-airnow.noarch: E: script-without-shebang /usr/lib/node_modules_18/magicmirror/modules/MMM-AirNow/node_modules_prod/uri-js/dist/esnext/schemes/mailto.js.map
magicmirror-module-airnow.noarch: E: script-without-shebang /usr/lib/node_modules_18/magicmirror/modules/MMM-AirNow/node_modules_prod/uri-js/dist/esnext/schemes/urn-uuid.js.map
magicmirror-module-airnow.noarch: E: script-without-shebang /usr/lib/node_modules_18/magicmirror/modules/MMM-AirNow/node_modules_prod/uri-js/dist/esnext/schemes/urn.js.map
magicmirror-module-airnow.noarch: E: script-without-shebang /usr/lib/node_modules_18/magicmirror/modules/MMM-AirNow/node_modules_prod/uri-js/dist/esnext/schemes/ws.js.map
magicmirror-module-airnow.noarch: E: script-without-shebang /usr/lib/node_modules_18/magicmirror/modules/MMM-AirNow/node_modules_prod/uri-js/dist/esnext/schemes/wss.js.map
magicmirror-module-airnow.noarch: E: script-without-shebang /usr/lib/node_modules_18/magicmirror/modules/MMM-AirNow/node_modules_prod/uri-js/dist/esnext/uri.js.map
magicmirror-module-airnow.noarch: E: script-without-shebang /usr/lib/node_modules_18/magicmirror/modules/MMM-AirNow/node_modules_prod/uri-js/dist/esnext/util.js.map
magicmirror-module-airnow.noarch: E: script-without-shebang /usr/lib/node_modules_18/magicmirror/modules/MMM-AirNow/node_modules_prod/uri-js/package.json
magicmirror-module-airnow.noarch: W: only-non-binary-in-usr-lib
magicmirror-module-airnow.noarch: E: non-executable-script /usr/lib/node_modules_18/magicmirror/modules/MMM-AirNow/node_modules_prod/ajv/scripts/info 644 /usr/bin/env node
magicmirror-module-airnow.noarch: E: non-executable-script /usr/lib/node_modules_18/magicmirror/modules/MMM-AirNow/node_modules_prod/ajv/scripts/prepare-tests 644 /usr/bin/env sh
magicmirror-module-airnow.noarch: E: non-executable-script /usr/lib/node_modules_18/magicmirror/modules/MMM-AirNow/node_modules_prod/ajv/scripts/publish-built-version 644 /usr/bin/env bash
magicmirror-module-airnow.noarch: E: non-executable-script /usr/lib/node_modules_18/magicmirror/modules/MMM-AirNow/node_modules_prod/ajv/scripts/travis-gh-pages 644 /usr/bin/env bash
magicmirror-module-airnow.noarch: E: non-executable-script /usr/lib/node_modules_18/magicmirror/modules/MMM-AirNow/node_modules_prod/dashdash/etc/dashdash.bash_completion.in 644 /bin/bash
magicmirror-module-airnow.spec: W: invalid-url Source1: MMM-AirNow-1.0.0-nm-prod.tgz
magicmirror-module-airnow.noarch: W: hidden-file-or-dir /usr/lib/node_modules_18/magicmirror/modules/MMM-AirNow/node_modules/.bin
magicmirror-module-airnow.noarch: W: hidden-file-or-dir /usr/lib/node_modules_18/magicmirror/modules/MMM-AirNow/node_modules_prod/.bin
magicmirror-module-airnow.noarch: W: hidden-file-or-dir /usr/lib/node_modules_18/magicmirror/modules/MMM-AirNow/node_modules_prod/.bin
magicmirror-module-airnow.noarch: W: hidden-file-or-dir /usr/lib/node_modules_18/magicmirror/modules/MMM-AirNow/node_modules_prod/.package-lock.json
magicmirror-module-airnow.noarch: W: hidden-file-or-dir /usr/lib/node_modules_18/magicmirror/modules/MMM-AirNow/node_modules_prod/ajv/.tonic_example.js
magicmirror-module-airnow.noarch: W: hidden-file-or-dir /usr/lib/node_modules_18/magicmirror/modules/MMM-AirNow/node_modules_prod/ajv/scripts/.eslintrc.yml
magicmirror-module-airnow.noarch: W: hidden-file-or-dir /usr/lib/node_modules_18/magicmirror/modules/MMM-AirNow/node_modules_prod/aws4/.github
magicmirror-module-airnow.noarch: W: hidden-file-or-dir /usr/lib/node_modules_18/magicmirror/modules/MMM-AirNow/node_modules_prod/aws4/.github
magicmirror-module-airnow.noarch: W: hidden-file-or-dir /usr/lib/node_modules_18/magicmirror/modules/MMM-AirNow/node_modules_prod/aws4/.travis.yml
magicmirror-module-airnow.noarch: W: hidden-file-or-dir /usr/lib/node_modules_18/magicmirror/modules/MMM-AirNow/node_modules_prod/delayed-stream/.npmignore
magicmirror-module-airnow.noarch: W: hidden-file-or-dir /usr/lib/node_modules_18/magicmirror/modules/MMM-AirNow/node_modules_prod/extend/.editorconfig
magicmirror-module-airnow.noarch: W: hidden-file-or-dir /usr/lib/node_modules_18/magicmirror/modules/MMM-AirNow/node_modules_prod/extend/.eslintrc
magicmirror-module-airnow.noarch: W: hidden-file-or-dir /usr/lib/node_modules_18/magicmirror/modules/MMM-AirNow/node_modules_prod/extend/.jscs.json
magicmirror-module-airnow.noarch: W: hidden-file-or-dir /usr/lib/node_modules_18/magicmirror/modules/MMM-AirNow/node_modules_prod/extend/.travis.yml
magicmirror-module-airnow.noarch: W: hidden-file-or-dir /usr/lib/node_modules_18/magicmirror/modules/MMM-AirNow/node_modules_prod/extsprintf/.gitmodules
magicmirror-module-airnow.noarch: W: hidden-file-or-dir /usr/lib/node_modules_18/magicmirror/modules/MMM-AirNow/node_modules_prod/extsprintf/.npmignore
magicmirror-module-airnow.noarch: W: hidden-file-or-dir /usr/lib/node_modules_18/magicmirror/modules/MMM-AirNow/node_modules_prod/fast-json-stable-stringify/.eslintrc.yml
magicmirror-module-airnow.noarch: W: hidden-file-or-dir /usr/lib/node_modules_18/magicmirror/modules/MMM-AirNow/node_modules_prod/fast-json-stable-stringify/.github
magicmirror-module-airnow.noarch: W: hidden-file-or-dir /usr/lib/node_modules_18/magicmirror/modules/MMM-AirNow/node_modules_prod/fast-json-stable-stringify/.github
magicmirror-module-airnow.noarch: W: hidden-file-or-dir /usr/lib/node_modules_18/magicmirror/modules/MMM-AirNow/node_modules_prod/fast-json-stable-stringify/.travis.yml
magicmirror-module-airnow.noarch: W: hidden-file-or-dir /usr/lib/node_modules_18/magicmirror/modules/MMM-AirNow/node_modules_prod/getpass/.npmignore
magicmirror-module-airnow.noarch: W: hidden-file-or-dir /usr/lib/node_modules_18/magicmirror/modules/MMM-AirNow/node_modules_prod/getpass/.travis.yml
magicmirror-module-airnow.noarch: W: hidden-file-or-dir /usr/lib/node_modules_18/magicmirror/modules/MMM-AirNow/node_modules_prod/http-signature/.dir-locals.el
magicmirror-module-airnow.noarch: W: hidden-file-or-dir /usr/lib/node_modules_18/magicmirror/modules/MMM-AirNow/node_modules_prod/http-signature/.npmignore
magicmirror-module-airnow.noarch: W: hidden-file-or-dir /usr/lib/node_modules_18/magicmirror/modules/MMM-AirNow/node_modules_prod/isstream/.jshintrc
magicmirror-module-airnow.noarch: W: hidden-file-or-dir /usr/lib/node_modules_18/magicmirror/modules/MMM-AirNow/node_modules_prod/isstream/.npmignore
magicmirror-module-airnow.noarch: W: hidden-file-or-dir /usr/lib/node_modules_18/magicmirror/modules/MMM-AirNow/node_modules_prod/isstream/.travis.yml
magicmirror-module-airnow.noarch: W: hidden-file-or-dir /usr/lib/node_modules_18/magicmirror/modules/MMM-AirNow/node_modules_prod/jsbn/.npmignore
magicmirror-module-airnow.noarch: W: hidden-file-or-dir /usr/lib/node_modules_18/magicmirror/modules/MMM-AirNow/node_modules_prod/json-schema-traverse/.eslintrc.yml
magicmirror-module-airnow.noarch: W: hidden-file-or-dir /usr/lib/node_modules_18/magicmirror/modules/MMM-AirNow/node_modules_prod/json-schema-traverse/.travis.yml
magicmirror-module-airnow.noarch: W: hidden-file-or-dir /usr/lib/node_modules_18/magicmirror/modules/MMM-AirNow/node_modules_prod/json-schema-traverse/spec/.eslintrc.yml
magicmirror-module-airnow.noarch: W: hidden-file-or-dir /usr/lib/node_modules_18/magicmirror/modules/MMM-AirNow/node_modules_prod/json-stringify-safe/.npmignore
magicmirror-module-airnow.noarch: W: hidden-file-or-dir /usr/lib/node_modules_18/magicmirror/modules/MMM-AirNow/node_modules_prod/performance-now/.npmignore
magicmirror-module-airnow.noarch: W: hidden-file-or-dir /usr/lib/node_modules_18/magicmirror/modules/MMM-AirNow/node_modules_prod/performance-now/.tm_properties
magicmirror-module-airnow.noarch: W: hidden-file-or-dir /usr/lib/node_modules_18/magicmirror/modules/MMM-AirNow/node_modules_prod/performance-now/.travis.yml
magicmirror-module-airnow.noarch: W: hidden-file-or-dir /usr/lib/node_modules_18/magicmirror/modules/MMM-AirNow/node_modules_prod/qs/.editorconfig
magicmirror-module-airnow.noarch: W: hidden-file-or-dir /usr/lib/node_modules_18/magicmirror/modules/MMM-AirNow/node_modules_prod/qs/.eslintrc
magicmirror-module-airnow.noarch: W: hidden-file-or-dir /usr/lib/node_modules_18/magicmirror/modules/MMM-AirNow/node_modules_prod/qs/.github
magicmirror-module-airnow.noarch: W: hidden-file-or-dir /usr/lib/node_modules_18/magicmirror/modules/MMM-AirNow/node_modules_prod/qs/.github
magicmirror-module-airnow.noarch: W: hidden-file-or-dir /usr/lib/node_modules_18/magicmirror/modules/MMM-AirNow/node_modules_prod/qs/.nycrc
magicmirror-module-airnow.noarch: W: hidden-file-or-dir /usr/lib/node_modules_18/magicmirror/modules/MMM-AirNow/node_modules_prod/sshpk/.travis.yml
magicmirror-module-airnow.noarch: W: hidden-file-or-dir /usr/lib/node_modules_18/magicmirror/modules/MMM-AirNow/node_modules_prod/tweetnacl/.npmignore
magicmirror-module-airnow.noarch: W: hidden-file-or-dir /usr/lib/node_modules_18/magicmirror/modules/MMM-AirNow/node_modules_prod/verror/.npmignore
magicmirror-module-airnow.noarch: W: files-duplicate /usr/lib/node_modules_18/magicmirror/modules/MMM-AirNow/node_modules_prod/tunnel-agent/LICENSE /usr/lib/node_modules_18/magicmirror/modules/MMM-AirNow/node_modules_prod/aws-sign2/LICENSE:/usr/lib/node_modules_18/magicmirror/modules/MMM-AirNow/node_modules_prod/forever-agent/LICENSE:/usr/lib/node_modules_18/magicmirror/modules/MMM-AirNow/node_modules_prod/oauth-sign/LICENSE:/usr/lib/node_modules_18/magicmirror/modules/MMM-AirNow/node_modules_prod/request/LICENSE
magicmirror-module-airnow.noarch: W: files-duplicate /usr/lib/node_modules_18/magicmirror/modules/MMM-AirNow/node_modules_prod/delayed-stream/License /usr/lib/node_modules_18/magicmirror/modules/MMM-AirNow/node_modules_prod/combined-stream/License
magicmirror-module-airnow.noarch: W: files-duplicate /usr/lib/node_modules_18/magicmirror/modules/MMM-AirNow/node_modules_prod/jsprim/LICENSE /usr/lib/node_modules_18/magicmirror/modules/MMM-AirNow/node_modules_prod/extsprintf/LICENSE
magicmirror-module-airnow.noarch: W: files-duplicate /usr/lib/node_modules_18/magicmirror/modules/MMM-AirNow/node_modules_prod/json-schema-traverse/LICENSE /usr/lib/node_modules_18/magicmirror/modules/MMM-AirNow/node_modules_prod/fast-deep-equal/LICENSE
magicmirror-module-airnow.noarch: W: files-duplicate /usr/lib/node_modules_18/magicmirror/modules/MMM-AirNow/node_modules_prod/fast-deep-equal/react.d.ts /usr/lib/node_modules_18/magicmirror/modules/MMM-AirNow/node_modules_prod/fast-deep-equal/es6/index.d.ts:/usr/lib/node_modules_18/magicmirror/modules/MMM-AirNow/node_modules_prod/fast-deep-equal/es6/react.d.ts
magicmirror-module-airnow.noarch: W: files-duplicate /usr/lib/node_modules_18/magicmirror/modules/MMM-AirNow/node_modules_prod/sshpk/LICENSE /usr/lib/node_modules_18/magicmirror/modules/MMM-AirNow/node_modules_prod/getpass/LICENSE:/usr/lib/node_modules_18/magicmirror/modules/MMM-AirNow/node_modules_prod/http-signature/LICENSE
magicmirror-module-airnow.noarch: W: files-duplicate /usr/lib/node_modules_18/magicmirror/modules/MMM-AirNow/node_modules_prod/verror/CONTRIBUTING.md /usr/lib/node_modules_18/magicmirror/modules/MMM-AirNow/node_modules_prod/jsprim/CONTRIBUTING.md
magicmirror-module-airnow.noarch: W: files-duplicate /usr/lib/node_modules_18/magicmirror/modules/MMM-AirNow/node_modules_prod/uri-js/dist/esnext/uri.d.ts /usr/lib/node_modules_18/magicmirror/modules/MMM-AirNow/node_modules_prod/uri-js/dist/es5/uri.all.d.ts:/usr/lib/node_modules_18/magicmirror/modules/MMM-AirNow/node_modules_prod/uri-js/dist/es5/uri.all.min.d.ts
magicmirror-module-airnow.noarch: W: files-duplicate /usr/lib/node_modules_18/magicmirror/modules/MMM-AirNow/node_modules_prod/uri-js/dist/esnext/schemes/wss.d.ts /usr/lib/node_modules_18/magicmirror/modules/MMM-AirNow/node_modules_prod/uri-js/dist/esnext/schemes/http.d.ts:/usr/lib/node_modules_18/magicmirror/modules/MMM-AirNow/node_modules_prod/uri-js/dist/esnext/schemes/https.d.ts
===================== 2 packages and 0 specfiles checked; 22 errors, 54 warnings, 22 badness; has taken 0.4 s ======================




Rpmlint (installed packages)
----------------------------
============================ rpmlint session starts ============================
rpmlint: 2.4.0
configuration:
    /usr/lib/python3.11/site-packages/rpmlint/configdefaults.toml
    /etc/xdg/rpmlint/fedora-legacy-licenses.toml
    /etc/xdg/rpmlint/fedora-spdx-licenses.toml
    /etc/xdg/rpmlint/fedora.toml
    /etc/xdg/rpmlint/scoring.toml
    /etc/xdg/rpmlint/users-groups.toml
    /etc/xdg/rpmlint/warn-on-functions.toml
checks: 31, packages: 1

magicmirror-module-airnow.noarch: E: zero-length /usr/lib/node_modules_18/magicmirror/modules/MMM-AirNow/node_modules_prod/extsprintf/.gitmodules
magicmirror-module-airnow.noarch: E: script-without-shebang /usr/lib/node_modules_18/magicmirror/modules/MMM-AirNow/node_modules_prod/ecc-jsbn/package.json
magicmirror-module-airnow.noarch: E: script-without-shebang /usr/lib/node_modules_18/magicmirror/modules/MMM-AirNow/node_modules_prod/uri-js/dist/es5/uri.all.js.map
magicmirror-module-airnow.noarch: E: script-without-shebang /usr/lib/node_modules_18/magicmirror/modules/MMM-AirNow/node_modules_prod/uri-js/dist/es5/uri.all.min.js.map
magicmirror-module-airnow.noarch: E: script-without-shebang /usr/lib/node_modules_18/magicmirror/modules/MMM-AirNow/node_modules_prod/uri-js/dist/esnext/index.js.map
magicmirror-module-airnow.noarch: E: script-without-shebang /usr/lib/node_modules_18/magicmirror/modules/MMM-AirNow/node_modules_prod/uri-js/dist/esnext/regexps-iri.js.map
magicmirror-module-airnow.noarch: E: script-without-shebang /usr/lib/node_modules_18/magicmirror/modules/MMM-AirNow/node_modules_prod/uri-js/dist/esnext/regexps-uri.js.map
magicmirror-module-airnow.noarch: E: script-without-shebang /usr/lib/node_modules_18/magicmirror/modules/MMM-AirNow/node_modules_prod/uri-js/dist/esnext/schemes/http.js.map
magicmirror-module-airnow.noarch: E: script-without-shebang /usr/lib/node_modules_18/magicmirror/modules/MMM-AirNow/node_modules_prod/uri-js/dist/esnext/schemes/https.js.map
magicmirror-module-airnow.noarch: E: script-without-shebang /usr/lib/node_modules_18/magicmirror/modules/MMM-AirNow/node_modules_prod/uri-js/dist/esnext/schemes/mailto.js.map
magicmirror-module-airnow.noarch: E: script-without-shebang /usr/lib/node_modules_18/magicmirror/modules/MMM-AirNow/node_modules_prod/uri-js/dist/esnext/schemes/urn-uuid.js.map
magicmirror-module-airnow.noarch: E: script-without-shebang /usr/lib/node_modules_18/magicmirror/modules/MMM-AirNow/node_modules_prod/uri-js/dist/esnext/schemes/urn.js.map
magicmirror-module-airnow.noarch: E: script-without-shebang /usr/lib/node_modules_18/magicmirror/modules/MMM-AirNow/node_modules_prod/uri-js/dist/esnext/schemes/ws.js.map
magicmirror-module-airnow.noarch: E: script-without-shebang /usr/lib/node_modules_18/magicmirror/modules/MMM-AirNow/node_modules_prod/uri-js/dist/esnext/schemes/wss.js.map
magicmirror-module-airnow.noarch: E: script-without-shebang /usr/lib/node_modules_18/magicmirror/modules/MMM-AirNow/node_modules_prod/uri-js/dist/esnext/uri.js.map
magicmirror-module-airnow.noarch: E: script-without-shebang /usr/lib/node_modules_18/magicmirror/modules/MMM-AirNow/node_modules_prod/uri-js/dist/esnext/util.js.map
magicmirror-module-airnow.noarch: E: script-without-shebang /usr/lib/node_modules_18/magicmirror/modules/MMM-AirNow/node_modules_prod/uri-js/package.json
magicmirror-module-airnow.noarch: W: only-non-binary-in-usr-lib
magicmirror-module-airnow.noarch: E: non-executable-script /usr/lib/node_modules_18/magicmirror/modules/MMM-AirNow/node_modules_prod/ajv/scripts/info 644 /usr/bin/env node
magicmirror-module-airnow.noarch: E: non-executable-script /usr/lib/node_modules_18/magicmirror/modules/MMM-AirNow/node_modules_prod/ajv/scripts/prepare-tests 644 /usr/bin/env sh
magicmirror-module-airnow.noarch: E: non-executable-script /usr/lib/node_modules_18/magicmirror/modules/MMM-AirNow/node_modules_prod/ajv/scripts/publish-built-version 644 /usr/bin/env bash
magicmirror-module-airnow.noarch: E: non-executable-script /usr/lib/node_modules_18/magicmirror/modules/MMM-AirNow/node_modules_prod/ajv/scripts/travis-gh-pages 644 /usr/bin/env bash
magicmirror-module-airnow.noarch: E: non-executable-script /usr/lib/node_modules_18/magicmirror/modules/MMM-AirNow/node_modules_prod/dashdash/etc/dashdash.bash_completion.in 644 /bin/bash
magicmirror-module-airnow.noarch: W: hidden-file-or-dir /usr/lib/node_modules_18/magicmirror/modules/MMM-AirNow/node_modules/.bin
magicmirror-module-airnow.noarch: W: hidden-file-or-dir /usr/lib/node_modules_18/magicmirror/modules/MMM-AirNow/node_modules_prod/.bin
magicmirror-module-airnow.noarch: W: hidden-file-or-dir /usr/lib/node_modules_18/magicmirror/modules/MMM-AirNow/node_modules_prod/.bin
magicmirror-module-airnow.noarch: W: hidden-file-or-dir /usr/lib/node_modules_18/magicmirror/modules/MMM-AirNow/node_modules_prod/.package-lock.json
magicmirror-module-airnow.noarch: W: hidden-file-or-dir /usr/lib/node_modules_18/magicmirror/modules/MMM-AirNow/node_modules_prod/ajv/.tonic_example.js
magicmirror-module-airnow.noarch: W: hidden-file-or-dir /usr/lib/node_modules_18/magicmirror/modules/MMM-AirNow/node_modules_prod/ajv/scripts/.eslintrc.yml
magicmirror-module-airnow.noarch: W: hidden-file-or-dir /usr/lib/node_modules_18/magicmirror/modules/MMM-AirNow/node_modules_prod/aws4/.github
magicmirror-module-airnow.noarch: W: hidden-file-or-dir /usr/lib/node_modules_18/magicmirror/modules/MMM-AirNow/node_modules_prod/aws4/.github
magicmirror-module-airnow.noarch: W: hidden-file-or-dir /usr/lib/node_modules_18/magicmirror/modules/MMM-AirNow/node_modules_prod/aws4/.travis.yml
magicmirror-module-airnow.noarch: W: hidden-file-or-dir /usr/lib/node_modules_18/magicmirror/modules/MMM-AirNow/node_modules_prod/delayed-stream/.npmignore
magicmirror-module-airnow.noarch: W: hidden-file-or-dir /usr/lib/node_modules_18/magicmirror/modules/MMM-AirNow/node_modules_prod/extend/.editorconfig
magicmirror-module-airnow.noarch: W: hidden-file-or-dir /usr/lib/node_modules_18/magicmirror/modules/MMM-AirNow/node_modules_prod/extend/.eslintrc
magicmirror-module-airnow.noarch: W: hidden-file-or-dir /usr/lib/node_modules_18/magicmirror/modules/MMM-AirNow/node_modules_prod/extend/.jscs.json
magicmirror-module-airnow.noarch: W: hidden-file-or-dir /usr/lib/node_modules_18/magicmirror/modules/MMM-AirNow/node_modules_prod/extend/.travis.yml
magicmirror-module-airnow.noarch: W: hidden-file-or-dir /usr/lib/node_modules_18/magicmirror/modules/MMM-AirNow/node_modules_prod/extsprintf/.gitmodules
magicmirror-module-airnow.noarch: W: hidden-file-or-dir /usr/lib/node_modules_18/magicmirror/modules/MMM-AirNow/node_modules_prod/extsprintf/.npmignore
magicmirror-module-airnow.noarch: W: hidden-file-or-dir /usr/lib/node_modules_18/magicmirror/modules/MMM-AirNow/node_modules_prod/fast-json-stable-stringify/.eslintrc.yml
magicmirror-module-airnow.noarch: W: hidden-file-or-dir /usr/lib/node_modules_18/magicmirror/modules/MMM-AirNow/node_modules_prod/fast-json-stable-stringify/.github
magicmirror-module-airnow.noarch: W: hidden-file-or-dir /usr/lib/node_modules_18/magicmirror/modules/MMM-AirNow/node_modules_prod/fast-json-stable-stringify/.github
magicmirror-module-airnow.noarch: W: hidden-file-or-dir /usr/lib/node_modules_18/magicmirror/modules/MMM-AirNow/node_modules_prod/fast-json-stable-stringify/.travis.yml
magicmirror-module-airnow.noarch: W: hidden-file-or-dir /usr/lib/node_modules_18/magicmirror/modules/MMM-AirNow/node_modules_prod/getpass/.npmignore
magicmirror-module-airnow.noarch: W: hidden-file-or-dir /usr/lib/node_modules_18/magicmirror/modules/MMM-AirNow/node_modules_prod/getpass/.travis.yml
magicmirror-module-airnow.noarch: W: hidden-file-or-dir /usr/lib/node_modules_18/magicmirror/modules/MMM-AirNow/node_modules_prod/http-signature/.dir-locals.el
magicmirror-module-airnow.noarch: W: hidden-file-or-dir /usr/lib/node_modules_18/magicmirror/modules/MMM-AirNow/node_modules_prod/http-signature/.npmignore
magicmirror-module-airnow.noarch: W: hidden-file-or-dir /usr/lib/node_modules_18/magicmirror/modules/MMM-AirNow/node_modules_prod/isstream/.jshintrc
magicmirror-module-airnow.noarch: W: hidden-file-or-dir /usr/lib/node_modules_18/magicmirror/modules/MMM-AirNow/node_modules_prod/isstream/.npmignore
magicmirror-module-airnow.noarch: W: hidden-file-or-dir /usr/lib/node_modules_18/magicmirror/modules/MMM-AirNow/node_modules_prod/isstream/.travis.yml
magicmirror-module-airnow.noarch: W: hidden-file-or-dir /usr/lib/node_modules_18/magicmirror/modules/MMM-AirNow/node_modules_prod/jsbn/.npmignore
magicmirror-module-airnow.noarch: W: hidden-file-or-dir /usr/lib/node_modules_18/magicmirror/modules/MMM-AirNow/node_modules_prod/json-schema-traverse/.eslintrc.yml
magicmirror-module-airnow.noarch: W: hidden-file-or-dir /usr/lib/node_modules_18/magicmirror/modules/MMM-AirNow/node_modules_prod/json-schema-traverse/.travis.yml
magicmirror-module-airnow.noarch: W: hidden-file-or-dir /usr/lib/node_modules_18/magicmirror/modules/MMM-AirNow/node_modules_prod/json-schema-traverse/spec/.eslintrc.yml
magicmirror-module-airnow.noarch: W: hidden-file-or-dir /usr/lib/node_modules_18/magicmirror/modules/MMM-AirNow/node_modules_prod/json-stringify-safe/.npmignore
magicmirror-module-airnow.noarch: W: hidden-file-or-dir /usr/lib/node_modules_18/magicmirror/modules/MMM-AirNow/node_modules_prod/performance-now/.npmignore
magicmirror-module-airnow.noarch: W: hidden-file-or-dir /usr/lib/node_modules_18/magicmirror/modules/MMM-AirNow/node_modules_prod/performance-now/.tm_properties
magicmirror-module-airnow.noarch: W: hidden-file-or-dir /usr/lib/node_modules_18/magicmirror/modules/MMM-AirNow/node_modules_prod/performance-now/.travis.yml
magicmirror-module-airnow.noarch: W: hidden-file-or-dir /usr/lib/node_modules_18/magicmirror/modules/MMM-AirNow/node_modules_prod/qs/.editorconfig
magicmirror-module-airnow.noarch: W: hidden-file-or-dir /usr/lib/node_modules_18/magicmirror/modules/MMM-AirNow/node_modules_prod/qs/.eslintrc
magicmirror-module-airnow.noarch: W: hidden-file-or-dir /usr/lib/node_modules_18/magicmirror/modules/MMM-AirNow/node_modules_prod/qs/.github
magicmirror-module-airnow.noarch: W: hidden-file-or-dir /usr/lib/node_modules_18/magicmirror/modules/MMM-AirNow/node_modules_prod/qs/.github
magicmirror-module-airnow.noarch: W: hidden-file-or-dir /usr/lib/node_modules_18/magicmirror/modules/MMM-AirNow/node_modules_prod/qs/.nycrc
magicmirror-module-airnow.noarch: W: hidden-file-or-dir /usr/lib/node_modules_18/magicmirror/modules/MMM-AirNow/node_modules_prod/sshpk/.travis.yml
magicmirror-module-airnow.noarch: W: hidden-file-or-dir /usr/lib/node_modules_18/magicmirror/modules/MMM-AirNow/node_modules_prod/tweetnacl/.npmignore
magicmirror-module-airnow.noarch: W: hidden-file-or-dir /usr/lib/node_modules_18/magicmirror/modules/MMM-AirNow/node_modules_prod/verror/.npmignore
magicmirror-module-airnow.noarch: W: files-duplicate /usr/lib/node_modules_18/magicmirror/modules/MMM-AirNow/node_modules_prod/tunnel-agent/LICENSE /usr/lib/node_modules_18/magicmirror/modules/MMM-AirNow/node_modules_prod/aws-sign2/LICENSE:/usr/lib/node_modules_18/magicmirror/modules/MMM-AirNow/node_modules_prod/forever-agent/LICENSE:/usr/lib/node_modules_18/magicmirror/modules/MMM-AirNow/node_modules_prod/oauth-sign/LICENSE:/usr/lib/node_modules_18/magicmirror/modules/MMM-AirNow/node_modules_prod/request/LICENSE
magicmirror-module-airnow.noarch: W: files-duplicate /usr/lib/node_modules_18/magicmirror/modules/MMM-AirNow/node_modules_prod/delayed-stream/License /usr/lib/node_modules_18/magicmirror/modules/MMM-AirNow/node_modules_prod/combined-stream/License
magicmirror-module-airnow.noarch: W: files-duplicate /usr/lib/node_modules_18/magicmirror/modules/MMM-AirNow/node_modules_prod/jsprim/LICENSE /usr/lib/node_modules_18/magicmirror/modules/MMM-AirNow/node_modules_prod/extsprintf/LICENSE
magicmirror-module-airnow.noarch: W: files-duplicate /usr/lib/node_modules_18/magicmirror/modules/MMM-AirNow/node_modules_prod/json-schema-traverse/LICENSE /usr/lib/node_modules_18/magicmirror/modules/MMM-AirNow/node_modules_prod/fast-deep-equal/LICENSE
magicmirror-module-airnow.noarch: W: files-duplicate /usr/lib/node_modules_18/magicmirror/modules/MMM-AirNow/node_modules_prod/fast-deep-equal/react.d.ts /usr/lib/node_modules_18/magicmirror/modules/MMM-AirNow/node_modules_prod/fast-deep-equal/es6/index.d.ts:/usr/lib/node_modules_18/magicmirror/modules/MMM-AirNow/node_modules_prod/fast-deep-equal/es6/react.d.ts
magicmirror-module-airnow.noarch: W: files-duplicate /usr/lib/node_modules_18/magicmirror/modules/MMM-AirNow/node_modules_prod/sshpk/LICENSE /usr/lib/node_modules_18/magicmirror/modules/MMM-AirNow/node_modules_prod/getpass/LICENSE:/usr/lib/node_modules_18/magicmirror/modules/MMM-AirNow/node_modules_prod/http-signature/LICENSE
magicmirror-module-airnow.noarch: W: files-duplicate /usr/lib/node_modules_18/magicmirror/modules/MMM-AirNow/node_modules_prod/verror/CONTRIBUTING.md /usr/lib/node_modules_18/magicmirror/modules/MMM-AirNow/node_modules_prod/jsprim/CONTRIBUTING.md
magicmirror-module-airnow.noarch: W: files-duplicate /usr/lib/node_modules_18/magicmirror/modules/MMM-AirNow/node_modules_prod/uri-js/dist/esnext/uri.d.ts /usr/lib/node_modules_18/magicmirror/modules/MMM-AirNow/node_modules_prod/uri-js/dist/es5/uri.all.d.ts:/usr/lib/node_modules_18/magicmirror/modules/MMM-AirNow/node_modules_prod/uri-js/dist/es5/uri.all.min.d.ts
magicmirror-module-airnow.noarch: W: files-duplicate /usr/lib/node_modules_18/magicmirror/modules/MMM-AirNow/node_modules_prod/uri-js/dist/esnext/schemes/wss.d.ts /usr/lib/node_modules_18/magicmirror/modules/MMM-AirNow/node_modules_prod/uri-js/dist/esnext/schemes/http.d.ts:/usr/lib/node_modules_18/magicmirror/modules/MMM-AirNow/node_modules_prod/uri-js/dist/esnext/schemes/https.d.ts
 1 packages and 0 specfiles checked; 22 errors, 53 warnings, 22 badness; has taken 0.1 s 



Source checksums
----------------
https://github.com/nigel-daniels/MMM-AirNow/archive/efddeb369d4bb454194e7ed5bb48d38f06c890a9/MMM-AirNow-efddeb369d4bb454194e7ed5bb48d38f06c890a9.tar.gz :
  CHECKSUM(SHA256) this package     : 6c9e3addef7a755d0f0431a09e9719c3d57c17a52d1d743b184681bbf9ab3bc8
  CHECKSUM(SHA256) upstream package : 6c9e3addef7a755d0f0431a09e9719c3d57c17a52d1d743b184681bbf9ab3bc8


Requires
--------
magicmirror-module-airnow (rpmlib, GLIBC filtered):
    /usr/bin/node
    magicmirror



Provides
--------
magicmirror-module-airnow:
    magicmirror-module-airnow



Generated by fedora-review 0.9.0 (6761b6c) last change: 2022-08-23
Command line :/usr/bin/fedora-review -b 2103401 -m fedora-38-x86_64
Buildroot used: fedora-38-x86_64
Active plugins: Shell-api, Generic
Disabled plugins: PHP, R, Python, Perl, C/C++, Haskell, Java, Ocaml, SugarActivity, fonts
Disabled flags: EPEL6, EPEL7, DISTTAG, BATCH, EXARCH

Comment 4 Fedora Admin user for bugzilla script actions 2023-07-18 02:07:24 UTC
The Pagure repository was created at https://src.fedoraproject.org/rpms/magicmirror-module-airnow

Comment 5 Fedora Update System 2023-07-18 14:40:29 UTC
FEDORA-2023-a175ffc536 has been submitted as an update to Fedora 39. https://bodhi.fedoraproject.org/updates/FEDORA-2023-a175ffc536

Comment 6 Fedora Update System 2023-07-18 14:42:56 UTC
FEDORA-2023-a175ffc536 has been pushed to the Fedora 39 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 7 Fedora Update System 2023-07-19 05:03:06 UTC
FEDORA-2023-a6637026ad has been submitted as an update to Fedora 38. https://bodhi.fedoraproject.org/updates/FEDORA-2023-a6637026ad

Comment 8 Fedora Update System 2023-07-20 05:28:13 UTC
FEDORA-2023-a6637026ad has been pushed to the Fedora 38 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf upgrade --enablerepo=updates-testing --refresh --advisory=FEDORA-2023-a6637026ad`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2023-a6637026ad

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 9 Fedora Update System 2023-07-28 02:40:47 UTC
FEDORA-2023-a6637026ad has been pushed to the Fedora 38 stable repository.
If problem still persists, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.