Spec URL: https://corsepiu.fedorapeople.org/packages/perl-Role-Hooks.spec SRPM URL: https://corsepiu.fedorapeople.org/packages/perl-Role-Hooks-0.006-1.fc37.src.rpm Description: This module allows a role to run a callback when it is applied to a class or to another role. Fedora Account System Username: corsepiu
Update: Spec URL: https://corsepiu.fedorapeople.org/packages/perl-Role-Hooks.spec SRPM URL: https://corsepiu.fedorapeople.org/packages/perl-Role-Hooks-0.008-1.fc37.src.rpm
Source file is ok Summary is ok License FIX: We have new licensing guidelines. Please write a license tag value in SPDX syntax https://docs.fedoraproject.org/en-US/legal/license-field/#_perl_packages $ license-fedora2spdx "GPL+ or Artistic" GPL-1.0-or-later OR Artistic-1.0-Perl Description is ok URL and Source0 are ok All tests passed BuildRequires FIX: Please add build-requires: coreutils - needed for macro %{_fixperms} perl(Class::Tiny) - t/02roletiny.t:6, t/06rolebasic.t:6 perl(lib) - t/07mite.t:10 perl(Moo::Role) - t/03moorole.t:6 perl(Moose::Role) - t/04mooserole.t:6 perl(Mouse::Role) - t/05mouserole.t:6 perl(Role::Tiny) - t/02roletiny.t:5 perl(Role::Tiny::With) - t/02roletiny.t:42 TODO: Please add version restriction for perl(ExtUtils::MakeMaker) >= 6.76 NO_PACKLIST is provided since this version. $ rpm -qp --requires perl-Role-Hooks-0.008-1.fc38.noarch.rpm | sort | uniq -c | grep -v rpmlib 1 perl(Class::Method::Modifiers) 1 perl(:MODULE_COMPAT_5.36.0) 1 perl(strict) 1 perl(:VERSION) >= 5.8.1 1 perl(warnings) Binary requires FIX: Please add run-require: perl(Carp) - lib/Role/Hooks.pm:24,30,36 $ rpm -qp --provides perl-Role-Hooks-0.008-1.fc38.noarch.rpm | sort | uniq -c 1 perl(Role::Hooks) = 0.008 1 perl-Role-Hooks = 0.008-1.fc38 Binary provides are Ok. $ rpmlint ./perl-Role-Hooks* ============================ rpmlint session starts ============================ rpmlint: 2.2.0 configuration: /usr/lib/python3.10/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/licenses.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 32, packages: 3 2 packages and 1 specfiles checked; 0 errors, 0 warnings, 0 badness; has taken 0.2 s Rpmlint is ok Otherwise the package is in line with Fedora and Perl packaging guide lines. Please correct all 'FIX' items, consider fixing 'TODO' item and provide a new spec file. Resolution: Not Approved
(In reply to Jitka Plesnikova from comment #2) > FIX: We have new licensing guidelines. Please write a license tag value in > SPDX syntax > https://docs.fedoraproject.org/en-US/legal/license-field/#_perl_packages > $ license-fedora2spdx "GPL+ or Artistic" > GPL-1.0-or-later OR Artistic-1.0-Perl FWIW: If you want to enforce the new rules, rpmlint in released Fedoras would need to be updated: ATM, on Fedora 36, I am seeing this: # rpmlint perl-Role-Hooks-0.008-2.fc38.noarch.rpm ... perl-Role-Hooks.noarch: W: invalid-license GPL-1.0-or-later perl-Role-Hooks.noarch: W: invalid-license Artistic-1.0-Perl > FIX: Please add run-require: > perl(Carp) - lib/Role/Hooks.pm:24,30,36 I am not sure what to do about this, because it seems an optional run-time requirement to me. Therefore, for now, I've added "Recommends: perl(Carp)" Update: Spec URL: https://corsepiu.fedorapeople.org/packages/perl-Role-Hooks.spec SRPM URL: https://corsepiu.fedorapeople.org/packages/perl-Role-Hooks-0.006-2.fc38.src.rpm
> License > FIX: We have new licensing guidelines. Please write a license tag value in > SPDX syntax > https://docs.fedoraproject.org/en-US/legal/license-field/#_perl_packages > $ license-fedora2spdx "GPL+ or Artistic" > GPL-1.0-or-later OR Artistic-1.0-Perl -License: GPL+ or Artistic +License: GPL-1.0-or-later OR Artistic-1.0-Perl Done > BuildRequires > FIX: Please add build-requires: > coreutils - needed for macro %{_fixperms} > perl(Class::Tiny) - t/02roletiny.t:6, t/06rolebasic.t:6 > perl(lib) - t/07mite.t:10 > perl(Moo::Role) - t/03moorole.t:6 > perl(Moose::Role) - t/04mooserole.t:6 > perl(Mouse::Role) - t/05mouserole.t:6 > perl(Role::Tiny) - t/02roletiny.t:5 > perl(Role::Tiny::With) - t/02roletiny.t:42 Done > TODO: Please add version restriction for perl(ExtUtils::MakeMaker) >= 6.76 > NO_PACKLIST is provided since this version. -BuildRequires: perl(ExtUtils::MakeMaker) +BuildRequires: perl(ExtUtils::MakeMaker) >= 6.76 Done > Binary requires > FIX: Please add run-require: > perl(Carp) - lib/Role/Hooks.pm:24,30,36 +# Not sure, if this dep should be mandatory +Recommends: perl(Carp) Done The package is in line with Fedora and Perl packaging guide lines. Resolution: Approved
(fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/perl-Role-Hooks