Bug 2103909 - native subversion depends on to be removed i686 java-openjdk packages
Summary: native subversion depends on to be removed i686 java-openjdk packages
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: subversion
Version: rawhide
Hardware: Unspecified
OS: Unspecified
urgent
high
Target Milestone: ---
Assignee: Joe Orton
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
: 2104204 2104210 2104212 2104214 2104220 2104228 2104234 2104237 2104238 2104256 2104260 2104263 (view as bug list)
Depends On:
Blocks: 2083750 2104259
TreeView+ depends on / blocked
 
Reported: 2022-07-05 09:13 UTC by jiri vanek
Modified: 2022-07-13 10:36 UTC (History)
4 users (show)

Fixed In Version: subversion-1.14.2-4.fc37
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2022-07-06 08:18:49 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)

Description jiri vanek 2022-07-05 09:13:15 UTC
Dear maintainer, we are going to drop i686 java packages in f37 - https://fedoraproject.org/wiki/Changes/Drop_i686_JDKs
your package (or maybe jsut some subpackage)  is directly depending on java and is native.

Please take care, and adapt  your package to exclude java on i686. For  your convenience, there was added macro %{java_arches}, including all arches java is available on,  which you can use to ifarch-out java specific features out in i686 (on non-java arches). Although for plain java package, the change is as simple as https://src.fedoraproject.org/rpms/maven/c/520942645bfd1e4721dacd536a6ccbf80495a8ae?branch=rawhide, you can not use it. The ExclusiveArch: %{java_arches} is not going to work for you, because your package is not simple java application, and also non-java world depends on it.

See exemplar PR: https://src.fedoraproject.org/rpms/graphviz/pull-request/9#request_diff
See more details eg in:: https://bugzilla.redhat.com/show_bug.cgi?id=2102298
See why in : https://pagure.io/fesco/issue/2772
Please read carefully proposal: https://fedoraproject.org/wiki/Changes/Drop_i686_JDKs
Please see tracking bug for most up to date informations: https://bugzilla.redhat.com/show_bug.cgi?id=2083750

I'm terribly sorry to report this bug so late in f37 lifecycle. If you can, please handle this with priority.


This is not autogenerated. It appeared, that half of the native universe depends transitively on subersion and thus on java, that subverssion is one of the most important (with autoconf and automake) packages to correctly adapt to this change

I had already checked your specfile, and it seesm you already have  "no-java" arches in place. Can you please elaborate?

Comment 1 jiri vanek 2022-07-05 09:45:23 UTC
Plese note, that subversion should strenghten its depndece on system jdk (it is sitll stuck on jdk11, which pulls jd11 with other javas)

Comment 2 Joe Orton 2022-07-05 12:10:30 UTC
It looks trivial to adjust this to use %{java_arches}, scratch build in progress.

Is %{java_arches} also available in older Fedora releases, so the spec file can stay the same across Fedora 35/6/7?

(In reply to jiri vanek from comment #1)
> Plese note, that subversion should strenghten its depndece on system jdk (it
> is sitll stuck on jdk11, which pulls jd11 with other javas)

What do you mean exactly here? I'm testing the build with OpenJDK 17.

Comment 4 jiri vanek 2022-07-05 14:03:25 UTC
(In reply to Joe Orton from comment #2)
> It looks trivial to adjust this to use %{java_arches}, scratch build in
> progress.

Thanx a lot!
> 
> Is %{java_arches} also available in older Fedora releases, so the spec file
> can stay the same across Fedora 35/6/7?

Not yet, but there is plan to backport it.
> 
> (In reply to jiri vanek from comment #1)
> > Plese note, that subversion should strenghten its depndece on system jdk (it
> > is sitll stuck on jdk11, which pulls jd11 with other javas)
> 
> What do you mean exactly here? I'm testing the build with OpenJDK 17.

- BuildRequires: java-11-openjdk-devel
+ BuildRequires: java-17-openjdk-devel 

exactly this :)

Thanx a lot!

Comment 5 jiri vanek 2022-07-05 14:04:32 UTC
> > What do you mean exactly here? I'm testing the build with OpenJDK 17.
> 
> - BuildRequires: java-11-openjdk-devel
> + BuildRequires: java-17-openjdk-devel 
> 
> exactly this :)
> 
It may be better, if you just depend on java-devel. By doinf so, you will always get system jdk. As you have ti now, you are enforcing jdk on yours own responsibility.

Comment 6 Joe Orton 2022-07-05 14:39:34 UTC
Package: subversion-1.14.2-4.fc37
Build: https://koji.fedoraproject.org/koji/buildinfo?buildID=1996643

Comment 7 Miro Hrončok 2022-07-05 23:07:57 UTC
> > Is %{java_arches} also available in older Fedora releases, so the spec file
> > can stay the same across Fedora 35/6/7?
> 
> Not yet, but there is plan to backport it.

Actually, it is available in all supported Fedoras and EPELs.

Comment 8 Miro Hrončok 2022-07-05 23:19:44 UTC
*** Bug 2104204 has been marked as a duplicate of this bug. ***

Comment 9 Miro Hrončok 2022-07-05 23:19:52 UTC
*** Bug 2104210 has been marked as a duplicate of this bug. ***

Comment 10 Miro Hrončok 2022-07-05 23:20:40 UTC
*** Bug 2104212 has been marked as a duplicate of this bug. ***

Comment 11 Miro Hrončok 2022-07-05 23:20:42 UTC
*** Bug 2104214 has been marked as a duplicate of this bug. ***

Comment 12 Miro Hrončok 2022-07-05 23:21:38 UTC
*** Bug 2104220 has been marked as a duplicate of this bug. ***

Comment 13 Miro Hrončok 2022-07-05 23:21:51 UTC
*** Bug 2104238 has been marked as a duplicate of this bug. ***

Comment 14 Miro Hrončok 2022-07-05 23:23:24 UTC
*** Bug 2104263 has been marked as a duplicate of this bug. ***

Comment 15 Miro Hrončok 2022-07-05 23:23:28 UTC
*** Bug 2104256 has been marked as a duplicate of this bug. ***

Comment 16 Joe Orton 2022-07-06 08:18:49 UTC
(In reply to jiri vanek from comment #5)
> > > What do you mean exactly here? I'm testing the build with OpenJDK 17.
> > 
> > - BuildRequires: java-11-openjdk-devel
> > + BuildRequires: java-17-openjdk-devel 
> > 
> > exactly this :)
> > 
> It may be better, if you just depend on java-devel. By doinf so, you will
> always get system jdk. As you have ti now, you are enforcing jdk on yours
> own responsibility.

IIRC, this has burnt us in the past since newer JDKs may break the Subversion build.

Thanks Miro for confirming java_arches works everywhere.

Comment 17 Joe Orton 2022-07-06 09:10:28 UTC
*** Bug 2104260 has been marked as a duplicate of this bug. ***

Comment 18 Miro Hrončok 2022-07-13 07:14:31 UTC
*** Bug 2104237 has been marked as a duplicate of this bug. ***

Comment 19 Parag Nemade 2022-07-13 09:53:57 UTC
*** Bug 2104228 has been marked as a duplicate of this bug. ***

Comment 20 Peng Wu 2022-07-13 10:36:00 UTC
*** Bug 2104234 has been marked as a duplicate of this bug. ***


Note You need to log in before you can comment on or make changes to this bug.