Bug 2104424 - Enable descheduler or hide it on template's scheduling tab
Summary: Enable descheduler or hide it on template's scheduling tab
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Container Native Virtualization (CNV)
Classification: Red Hat
Component: User Experience
Version: 4.11.0
Hardware: Unspecified
OS: Unspecified
medium
medium
Target Milestone: ---
: 4.12.0
Assignee: Hilda Stastna
QA Contact: Guohua Ouyang
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2022-07-06 08:48 UTC by Guohua Ouyang
Modified: 2023-01-24 13:37 UTC (History)
4 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2023-01-24 13:37:41 UTC
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)
descheduler (130.17 KB, image/png)
2022-07-06 08:48 UTC, Guohua Ouyang
no flags Details


Links
System ID Private Priority Status Summary Last Updated
Github kubevirt-ui kubevirt-plugin pull 791 0 None open Bug 2104424: Check Descheduler Operator and enable/disable on pages 2022-07-26 15:08:30 UTC
Red Hat Issue Tracker CNV-19688 0 None None None 2022-11-29 09:54:15 UTC
Red Hat Product Errata RHSA-2023:0408 0 None None None 2023-01-24 13:37:54 UTC

Description Guohua Ouyang 2022-07-06 08:48:11 UTC
Created attachment 1894863 [details]
descheduler

Description of problem:
Currently, the descheduler option is disabled in template's scheduling tab, user may wonder why it's there and disabled. I cannot see a good reason to disable it, so let's  either enable it or hide it.

Version-Release number of selected component (if applicable):


How reproducible:


Steps to Reproduce:
1.
2.
3.

Actual results:


Expected results:


Additional info:

Comment 1 Ronen 2022-07-07 07:22:51 UTC
The Descheduler operator must be installed on the cluster for the option to be enabled.
Please verify that the operator is installed.
We may need to add an explanation in the case it is disabled

Comment 2 Hilda Stastna 2022-07-25 13:25:40 UTC
Hello,

we have already for some time the extra popover implemented:
"To enable the Descheduler, you must install the Kube Descheduler Operator from OperatorHub and enable one or more Descheduler profiles."
See also the attachment.
Is this text incorrect? Should we change it? IMO it is sufficient enough. Thanks!

Comment 4 Guohua Ouyang 2022-07-25 13:38:42 UTC
(In reply to Hilda Stastna from comment #2)
> Hello,
> 
> we have already for some time the extra popover implemented:
> "To enable the Descheduler, you must install the Kube Descheduler Operator
> from OperatorHub and enable one or more Descheduler profiles."
> See also the attachment.
> Is this text incorrect? Should we change it? IMO it is sufficient enough.
> Thanks!

The Kube Descheduler Operator is not related, after install the descheduler operator, the custom template still see the same thing in scheduling tab. And I believe the UI does not check the operator state to enable and disable it.

Since other fields are editable, there is no reason to just disable this field.

Comment 5 Hilda Stastna 2022-07-25 14:08:56 UTC
Hi Guohua,

the UI does check the operator state to enable and disable. Maybe there is some problem with the check.

The reason to disable this field is to provide the info for the user that there is this feature but to enable it the operator must be installed. By hiding this completely the user will lose the information entirely. Also it is a part of the new design to just disable this field if the operator is not installed.

Comment 6 Ronen 2022-07-25 14:14:26 UTC
If the operator is not installed the field is disabled just like Hilda said.
If the operator is installed and it's still disabled, it's a bug and we need to fix it.

Comment 7 Guohua Ouyang 2022-07-25 14:26:23 UTC
There should have no check about the descheduler operator.
1. the descheduler field is disabled on custom template
2. create a vm from this custom template, the field is editable

1 and 2 are conflict each other if there is a checking about the descheduler operator.

Comment 8 Hilda Stastna 2022-07-25 14:40:31 UTC
There has to be check about the operator, otherwise we won't know when to enable/disable it.

Regarding the rest, I agree, there is a conflict and it is there because the editability of the Descheduler field in the VM page is missing the check for the operator installed.

Comment 10 Guohua Ouyang 2022-08-19 03:29:02 UTC
Hi Hilda,
After uninstall the descheduler operator, should the descheduler option be disabled again?

Reproduce steps:
1. On a cluster has no descheduler operator installed, the descheduler option is disabled
2. Install the descheduler operator, the descheduler option is enabled
3. Delete the descheduler operator, the descheduler option is enabled

My question is on step 3, should it be disabled again?

Comment 11 Hilda Stastna 2022-08-23 11:21:47 UTC
If the Kube Descheduler Operator is not installed, Descheduler field should be disabled.
I've tried to reproduce your step 3, but was not able to reproduce. Works for me as expected.
Did you follow the steps https://docs.openshift.com/container-platform/4.10/nodes/scheduling/nodes-descheduler.html#nodes-descheduler-uninstalling_nodes-descheduler?

Comment 12 Hilda Stastna 2022-08-23 11:23:32 UTC
Guohua, where exactly is the Descheduler field enabled for you (step 3)?

Comment 14 Hilda Stastna 2022-08-24 10:55:56 UTC
Guohua,

you need to follow the whole procedure of uninstalling the descheduler:
https://docs.openshift.com/container-platform/4.10/nodes/scheduling/nodes-descheduler.html#nodes-descheduler-uninstalling_nodes-descheduler
From the attachment you've provided, I can see you've missed the steps 2, 4, 5 from the doc above. Thanks.

Comment 15 Guohua Ouyang 2022-08-24 12:16:57 UTC
(In reply to Hilda Stastna from comment #14)
> Guohua,
> 
> you need to follow the whole procedure of uninstalling the descheduler:
> https://docs.openshift.com/container-platform/4.10/nodes/scheduling/nodes-
> descheduler.html#nodes-descheduler-uninstalling_nodes-descheduler
> From the attachment you've provided, I can see you've missed the steps 2, 4,
> 5 from the doc above. Thanks.

Could you tell me why need to do that, I don't see any reason to do those steps as they're not related.
For step2, There is no instances created at all when the operator is installed, and the descheduler becomes enabled. So it seems no need to create the instance and of course no instances to be deleted.
For step 4 and 5, they're totally not related.

Comment 16 Hilda Stastna 2022-08-24 12:28:12 UTC
How can those steps not be related? They are part of the procedure, as the doc says. Did you try to do all the steps?
Also I remember you've sent me that doc and suggested me to follow that procedure when I asked you how to uninstall the Descheduler. 

> For step2, There is no instances created at all when the operator is installed, and the descheduler becomes enabled. 

I cannot reproduce that. The Descheduler is enabled after I follow the whole process of installing the Descheduler:
https://docs.openshift.com/container-platform/4.10/nodes/scheduling/nodes-descheduler.html#nodes-descheduler-installing_nodes-descheduler

Comment 17 Guohua Ouyang 2022-08-24 12:45:55 UTC
(In reply to Guohua Ouyang from comment #15)
> (In reply to Hilda Stastna from comment #14)
> > Guohua,
> > 
> > you need to follow the whole procedure of uninstalling the descheduler:
> > https://docs.openshift.com/container-platform/4.10/nodes/scheduling/nodes-
> > descheduler.html#nodes-descheduler-uninstalling_nodes-descheduler
> > From the attachment you've provided, I can see you've missed the steps 2, 4,
> > 5 from the doc above. Thanks.
> 
> Could you tell me why need to do that, I don't see any reason to do those
> steps as they're not related.
> For step2, There is no instances created at all when the operator is
> installed, and the descheduler becomes enabled. So it seems no need to
> create the instance and of course no instances to be deleted.
> For step 4 and 5, they're totally not related.

ah, so I did these steps and the problem in step 3 is not showing.

But I still don't understand why it checks so much, I think the checking of namespace and CRD are not correct behavior.
In my opinion, it should only check the operator status.

Comment 18 Guohua Ouyang 2022-09-23 03:04:54 UTC
Close the bug so far.

Comment 23 errata-xmlrpc 2023-01-24 13:37:41 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (Important: OpenShift Virtualization 4.12.0 Images security update), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHSA-2023:0408


Note You need to log in before you can comment on or make changes to this bug.