Spec URL: https://elmarco.fedorapeople.org/rest1.spec SRPM URL: https://elmarco.fedorapeople.org/rest1-0.9.1-2.fc37.src.rpm Description: A library for access to RESTful web services Fedora Account System Username: elmarco
This is rest with API version break, building against libsoup3. Michael, please review.
OK, I'm happy to review this but it's not quite ready for a full review. First issue I noticed when running fedora-review: WARNING: Cannot download url: http://download.gnome.org/sources/rest1/0.9/rest-0.9.1.tar.xz Can't use %{name} there because it expands to "rest1" but we need it to expand to "rest". Next issue is the mockbuild fails due to missing build dependency. Need to add BuildRequires: pkgconfig(json-glib-1.0) I'll also ask that you convert -devel dependencies into pkgconfig dependencies: BuildRequires: pkgconfig(glib-2.0) BuildRequires: pkgconfig(gobject-introspection-1.0) BuildRequires: pkgconfig(libsoup-3.0) BuildRequires: pkgconfig(libxml-2.0) Finally, in the files list: %{_libdir}/librest-1.0.so.0.0.0 %{_libdir}/librest-extras-1.0.so.0.0.0 I would write: %{_libdir}/librest-1.0.so.0.* %{_libdir}/librest-extras-1.0.so.0.* to avoid needless churn when updating. It's important to keep the first component explicit to avoid unexpected soname bumps, but the rest can be globbed. One more thing: I noticed the upstream package name is inconsistent. I was going to suggest calling this package "librest" instead of "rest1" to match the GitLab project, but the upstream tarball is really called "rest" so I suppose "rest1" is the better name for us to use after all. Nevertheless, I've inquired at https://gitlab.gnome.org/GNOME/librest/-/issues/14 to see what upstream thinks.
Ah sorry, I missed this. I think we don't need this package any more because I already updated the rest package to 0.9.1 last week, and created a compat rest0.7 for the previous API.
ok, thanks