Spec URL: https://xdelaruelle.fedorapeople.org/nagelfar.spec SRPM URL: https://xdelaruelle.fedorapeople.org/nagelfar-1.3.2-1.fc36.src.rpm Description: Nagelfar is a Tcl application to read a Tcl program and provide static syntax analysis - information regarding Tcl syntax errors like missing braces, incomplete commands, etc. It is, moreover, extensible, with a customizable exposed syntax database and plugins. Nagelfar has also support for doing simple code coverage analysis. Fedora Account System Username: xdelaruelle
Hi Xavier, Thanks for your contribution. I will be reviewing your package. The main problem is that it fails to build in mock on Fedora 36 because of a failed dependency on /usr/bin/tclsh: + /usr/lib/rpm/generate-rpm-note.sh nagelfar 1.3.2-1.fc36 x86_64 + cd nagelfar132 + ./test_nagelfar.sh /builddir/build/BUILDROOT/nagelfar-1.3.2-1.fc36.x86_64/usr/bin/nagelfar.tcl /builddir/build/BUILDROOT/nagelfar-1.3.2-1.fc36.x86_64/usr/share/nagelfar/syntaxdb.tcl misctests/test.tcl ./test_nagelfar.sh: /builddir/build/BUILDROOT/nagelfar-1.3.2-1.fc36.x86_64/usr/bin/nagelfar.tcl: /usr/bin/tclsh: bad interpreter: No such file or directory error: Bad exit status from /var/tmp/rpm-tmp.lXpwtX (%check) RPM build errors: Bad exit status from /var/tmp/rpm-tmp.lXpwtX (%check) See: https://fedoraproject.org/wiki/Using_Mock_to_test_package_builds
Hi Stéphane, Many thanks for your feedback. I have just updated SPEC file and SRPM to include a 'BuildRequires: tcl' statement as the script run in %check step needs /usr/bin/tclsh. You could find updated files at the same location.
Looks good, thanks! Adding rpmlint output of both src.rpm and installed rpm below FYI. $ rpmlint -v nagelfar-1.3.2-1.fc36.src.rpm 331 blocks ================================================= rpmlint session starts ================================================ rpmlint: 2.2.0 configuration: /usr/lib/python3.10/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/licenses.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 32, packages: 1 nagelfar.spec:27: W: macro-in-comment %check There is a unescaped macro after a shell style comment in the specfile. Macros are expanded everywhere, so check if it can cause a problem in this case and escape the macro with another leading % if appropriate. ================== 1 packages and 0 specfiles checked; 0 errors, 1 warnings, 0 badness; has taken 0.1 s ================= $ rpmlint -i nagelfar ================================================= rpmlint session starts ================================================ rpmlint: 2.2.0 configuration: /usr/lib/python3.10/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/licenses.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 32, packages: 1 nagelfar.noarch: W: no-manual-page-for-binary nagelfar.tcl ================== 1 packages and 0 specfiles checked; 0 errors, 1 warnings, 0 badness; has taken 0.1 s =================
Many thanks for your review. I have just fixed the "macro-in-comment %check" warning.
(fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/nagelfar
Package is pushed and built on rawhide (pending update on epel7, epel8 and epel9).