Spec URL: https://dcavalca.fedorapeople.org/review/rust-wezterm-bidi/rust-wezterm-bidi.spec SRPM URL: https://dcavalca.fedorapeople.org/review/rust-wezterm-bidi/rust-wezterm-bidi-0.1.0-1.fc37.src.rpm Description: Unicode Bidi Algorithm (UBA). Fedora Account System Username: dcavalca
This package built on koji: https://koji.fedoraproject.org/koji/taskinfo?taskID=89345650
This crate contains data and code from Unicode, which seems to be licensed as "Unicode" (Fedora specifier) or "Unicode-DFS-2016" (SPDX). This is stated in the README and, and the license file contains texts for both the MIT and the Unicode license. However, the metadata in Cargo.toml only states "MIT", whereas it should probably be "MIT AND Unicode-DFS-2016". You might want to ask upstream about that, or at least patch Cargo.toml for our builds.
For reference, a similar change has been pushed to other crates that contain code that's derived from Unicode data. For unicode-ident, which is now used by syn and other popular crates, this change is already "live": https://github.com/dtolnay/unicode-ident/pull/9 For unicode-xid, which has been mostly replaced by unicode-ident, the change is still pending: https://github.com/unicode-rs/unicode-xid/pull/32
Thanks for resolving this upstream, looks like v0.2.0 contains your PR: https://crates.io/crates/wezterm-bidi/0.2.0 Would it be possible to update packaging to this version?
Spec URL: https://dcavalca.fedorapeople.org/review/rust-wezterm-bidi/rust-wezterm-bidi.spec SRPM URL: https://dcavalca.fedorapeople.org/review/rust-wezterm-bidi/rust-wezterm-bidi-0.2.1-1.fc38.src.rpm Changelog: - re-run rust2rpm - update to 0.2.1
Looks good to me, thanks! === Package was generated with rust2rpm, simplifying the review. - package builds and installs without errors on rawhide - test suite is run and all unit tests pass - latest version of the crate is packaged - license matches upstream specification and is acceptable for Fedora - license text is included with %license in %files - package complies with Rust Packaging Guidelines Package APPROVED. === Recommended post-import rust-sig tasks: - add @rust-sig with "commit" access as package co-maintainer - set bugzilla assignee overrides to @rust-sig (optional) - set up package on release-monitoring.org: project: $crate homepage: https://crates.io/crates/$crate backend: crates.io version scheme: semantic version filter: alpha;beta;rc;pre distro: Fedora Package: rust-$crate - track package in koschei for all built branches
(fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-wezterm-bidi
FEDORA-2022-b7ab5d93b9 has been submitted as an update to Fedora 38. https://bodhi.fedoraproject.org/updates/FEDORA-2022-b7ab5d93b9
FEDORA-2022-b7ab5d93b9 has been pushed to the Fedora 38 stable repository. If problem still persists, please make note of it in this bug report.
FEDORA-2022-5b3f11d714 has been submitted as an update to Fedora 37. https://bodhi.fedoraproject.org/updates/FEDORA-2022-5b3f11d714
FEDORA-2022-3ad7e1b623 has been submitted as an update to Fedora 36. https://bodhi.fedoraproject.org/updates/FEDORA-2022-3ad7e1b623
FEDORA-2022-1992e9f908 has been submitted as an update to Fedora 35. https://bodhi.fedoraproject.org/updates/FEDORA-2022-1992e9f908
FEDORA-2022-5b3f11d714 has been pushed to the Fedora 37 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2022-5b3f11d714 \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2022-5b3f11d714 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
FEDORA-2022-3ad7e1b623 has been pushed to the Fedora 36 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2022-3ad7e1b623 \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2022-3ad7e1b623 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
FEDORA-2022-1992e9f908 has been pushed to the Fedora 35 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2022-1992e9f908 \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2022-1992e9f908 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
FEDORA-2022-3ad7e1b623 has been pushed to the Fedora 36 stable repository. If problem still persists, please make note of it in this bug report.
FEDORA-2022-1992e9f908 has been pushed to the Fedora 35 stable repository. If problem still persists, please make note of it in this bug report.
FEDORA-2022-5b3f11d714 has been pushed to the Fedora 37 stable repository. If problem still persists, please make note of it in this bug report.