Bug 2105831 - Review Request: rust-wezterm-bidi - Unicode Bidi Algorithm (UBA)
Summary: Review Request: rust-wezterm-bidi - Unicode Bidi Algorithm (UBA)
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Fabio Valentini
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: 1984198
TreeView+ depends on / blocked
 
Reported: 2022-07-10 22:13 UTC by Davide Cavalca
Modified: 2022-11-10 22:20 UTC (History)
2 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2022-10-18 17:35:03 UTC
Type: ---
Embargoed:
decathorpe: fedora-review+


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Github wez wezterm pull 2340 0 None open bidi: update license tag to match the actual license 2022-08-01 16:17:58 UTC

Description Davide Cavalca 2022-07-10 22:13:56 UTC
Spec URL: https://dcavalca.fedorapeople.org/review/rust-wezterm-bidi/rust-wezterm-bidi.spec
SRPM URL: https://dcavalca.fedorapeople.org/review/rust-wezterm-bidi/rust-wezterm-bidi-0.1.0-1.fc37.src.rpm

Description:
Unicode Bidi Algorithm (UBA).

Fedora Account System Username: dcavalca

Comment 1 Davide Cavalca 2022-07-10 22:13:58 UTC
This package built on koji:  https://koji.fedoraproject.org/koji/taskinfo?taskID=89345650

Comment 2 Fabio Valentini 2022-07-29 09:25:53 UTC
This crate contains data and code from Unicode, which seems to be licensed as "Unicode" (Fedora specifier) or "Unicode-DFS-2016" (SPDX).
This is stated in the README and, and the license file contains texts for both the MIT and the Unicode license.

However, the metadata in Cargo.toml only states "MIT", whereas it should probably be "MIT AND Unicode-DFS-2016". You might want to ask upstream about that, or at least patch Cargo.toml for our builds.

Comment 3 Fabio Valentini 2022-08-11 17:04:26 UTC
For reference, a similar change has been pushed to other crates that contain code that's derived from Unicode data.

For unicode-ident, which is now used by syn and other popular crates, this change is already "live":
https://github.com/dtolnay/unicode-ident/pull/9

For unicode-xid, which has been mostly replaced by unicode-ident, the change is still pending:
https://github.com/unicode-rs/unicode-xid/pull/32

Comment 4 Fabio Valentini 2022-08-17 10:54:34 UTC
Thanks for resolving this upstream, looks like v0.2.0 contains your PR:
https://crates.io/crates/wezterm-bidi/0.2.0
Would it be possible to update packaging to this version?

Comment 6 Fabio Valentini 2022-10-17 20:04:48 UTC
Looks good to me, thanks!

===

Package was generated with rust2rpm, simplifying the review.

- package builds and installs without errors on rawhide
- test suite is run and all unit tests pass
- latest version of the crate is packaged
- license matches upstream specification and is acceptable for Fedora
- license text is included with %license in %files
- package complies with Rust Packaging Guidelines

Package APPROVED.

===

Recommended post-import rust-sig tasks:

- add @rust-sig with "commit" access as package co-maintainer

- set bugzilla assignee overrides to @rust-sig (optional)

- set up package on release-monitoring.org:
  project: $crate
  homepage: https://crates.io/crates/$crate
  backend: crates.io
  version scheme: semantic
  version filter: alpha;beta;rc;pre
  distro: Fedora
  Package: rust-$crate

- track package in koschei for all built branches

Comment 7 Gwyn Ciesla 2022-10-18 13:17:36 UTC
(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-wezterm-bidi

Comment 8 Fedora Update System 2022-10-18 17:32:21 UTC
FEDORA-2022-b7ab5d93b9 has been submitted as an update to Fedora 38. https://bodhi.fedoraproject.org/updates/FEDORA-2022-b7ab5d93b9

Comment 9 Fedora Update System 2022-10-18 17:35:03 UTC
FEDORA-2022-b7ab5d93b9 has been pushed to the Fedora 38 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 10 Fedora Update System 2022-10-18 20:33:42 UTC
FEDORA-2022-5b3f11d714 has been submitted as an update to Fedora 37. https://bodhi.fedoraproject.org/updates/FEDORA-2022-5b3f11d714

Comment 11 Fedora Update System 2022-10-18 21:39:59 UTC
FEDORA-2022-3ad7e1b623 has been submitted as an update to Fedora 36. https://bodhi.fedoraproject.org/updates/FEDORA-2022-3ad7e1b623

Comment 12 Fedora Update System 2022-10-18 22:18:20 UTC
FEDORA-2022-1992e9f908 has been submitted as an update to Fedora 35. https://bodhi.fedoraproject.org/updates/FEDORA-2022-1992e9f908

Comment 13 Fedora Update System 2022-10-19 08:32:39 UTC
FEDORA-2022-5b3f11d714 has been pushed to the Fedora 37 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2022-5b3f11d714 \*`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2022-5b3f11d714

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 14 Fedora Update System 2022-10-19 10:25:51 UTC
FEDORA-2022-3ad7e1b623 has been pushed to the Fedora 36 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2022-3ad7e1b623 \*`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2022-3ad7e1b623

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 15 Fedora Update System 2022-10-19 10:26:32 UTC
FEDORA-2022-1992e9f908 has been pushed to the Fedora 35 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2022-1992e9f908 \*`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2022-1992e9f908

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 16 Fedora Update System 2022-10-26 17:27:57 UTC
FEDORA-2022-3ad7e1b623 has been pushed to the Fedora 36 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 17 Fedora Update System 2022-10-26 17:35:06 UTC
FEDORA-2022-1992e9f908 has been pushed to the Fedora 35 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 18 Fedora Update System 2022-11-10 22:20:16 UTC
FEDORA-2022-5b3f11d714 has been pushed to the Fedora 37 stable repository.
If problem still persists, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.