Bug 2105872 - Review Request: rust-konst_proc_macros - Implementation detail of the konst crate
Summary: Review Request: rust-konst_proc_macros - Implementation detail of the konst c...
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Fabio Valentini
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: 2105873
TreeView+ depends on / blocked
 
Reported: 2022-07-11 03:35 UTC by Davide Cavalca
Modified: 2022-08-07 05:08 UTC (History)
2 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2022-07-26 22:22:54 UTC
Type: ---
Embargoed:
decathorpe: fedora-review+


Attachments (Terms of Use)

Description Davide Cavalca 2022-07-11 03:35:50 UTC
Spec URL: https://dcavalca.fedorapeople.org/review/rust-konst_proc_macros/rust-konst_proc_macros.spec
SRPM URL: https://dcavalca.fedorapeople.org/review/rust-konst_proc_macros/rust-konst_proc_macros-0.2.11-1.fc37.src.rpm

Description:
Implementation detail of the `konst` crate.

Fedora Account System Username: dcavalca

Comment 1 Davide Cavalca 2022-07-11 03:35:52 UTC
This package built on koji:  https://koji.fedoraproject.org/koji/taskinfo?taskID=89355165

Comment 2 Fabio Valentini 2022-07-26 16:57:17 UTC
One nit-pick:
Please remove the `` markdown markup from the package's Summary and this bug's title.
Looks good otherwise:

===

Package was generated with rust2rpm, simplifying the review.

- package builds and installs without errors on rawhide
- test suite is run and all unit tests pass
- latest version of the crate is packaged
- license matches upstream specification (zlib) and is acceptable for Fedora
- license file is included with %license in %files
- package complies with Rust Packaging Guidelines

Package APPROVED.

===

Recommended post-import rust-sig tasks:

- add @rust-sig with "commit" access as package co-maintainer

- set bugzilla assignee overrides to @rust-sig (optional)

- set up package on release-monitoring.org:
  project: $crate
  homepage: https://crates.io/crates/$crate
  backend: crates.io
  version scheme: semantic
  version filter: alpha;beta;rc;pre
  distro: Fedora
  Package: rust-$crate

- track package in koschei for all built branches

Comment 3 Davide Cavalca 2022-07-26 20:00:30 UTC
$ fedpkg request-repo rust-konst_proc_macros 2105872
Could not execute request_repo: The Bugzilla bug is not approved yet

I think you set the wrong flag on this one, it's supposed to be fedora-review and you set needinfo.

Comment 4 Fabio Valentini 2022-07-26 21:41:01 UTC
uh, should be fixed now. sorry about that

Comment 5 Davide Cavalca 2022-07-26 21:43:40 UTC
Thanks!
$ fedpkg request-repo rust-konst_proc_macros 2105872
https://pagure.io/releng/fedora-scm-requests/issue/45975
$ fedpkg request-branch --repo rust-konst_proc_macros f36
https://pagure.io/releng/fedora-scm-requests/issue/45976
$ fedpkg request-branch --repo rust-konst_proc_macros f35
https://pagure.io/releng/fedora-scm-requests/issue/45977

Comment 6 Gwyn Ciesla 2022-07-26 22:02:54 UTC
(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-konst_proc_macros

Comment 7 Fedora Update System 2022-07-26 22:15:24 UTC
FEDORA-2022-cc8fb993c5 has been submitted as an update to Fedora 37. https://bodhi.fedoraproject.org/updates/FEDORA-2022-cc8fb993c5

Comment 8 Fedora Update System 2022-07-26 22:22:54 UTC
FEDORA-2022-cc8fb993c5 has been pushed to the Fedora 37 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 9 Fedora Update System 2022-07-28 03:43:41 UTC
FEDORA-2022-3e6a99a3da has been submitted as an update to Fedora 36. https://bodhi.fedoraproject.org/updates/FEDORA-2022-3e6a99a3da

Comment 10 Fedora Update System 2022-07-29 01:23:09 UTC
FEDORA-2022-3e6a99a3da has been pushed to the Fedora 36 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2022-3e6a99a3da \*`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2022-3e6a99a3da

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 11 Fedora Update System 2022-07-29 15:56:29 UTC
FEDORA-2022-c93ff772e4 has been submitted as an update to Fedora 35. https://bodhi.fedoraproject.org/updates/FEDORA-2022-c93ff772e4

Comment 12 Fedora Update System 2022-07-30 02:18:52 UTC
FEDORA-2022-c93ff772e4 has been pushed to the Fedora 35 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2022-c93ff772e4 \*`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2022-c93ff772e4

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 13 Fedora Update System 2022-08-06 01:52:12 UTC
FEDORA-2022-3e6a99a3da has been pushed to the Fedora 36 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 14 Fedora Update System 2022-08-07 05:08:57 UTC
FEDORA-2022-c93ff772e4 has been pushed to the Fedora 35 stable repository.
If problem still persists, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.