Red Hat Bugzilla – Bug 210632
Review Request: fbg - Falling Block Game
Last modified: 2007-11-30 17:11:45 EST
Spec URL: http://people.atrpms.net/~hdegoede/fbg.spec SRPM URL: http://people.atrpms.net/~hdegoede/fbg-0.9-1.fc6.src.rpm Description: Move and rotate variously shaped falling blocks to make them form a complete row. Once a complete row has formed it will disappear. If you make incomplete rows the screen will fill up and when it reaches the top the game is over.
MUST items: * rpmlint doesn't show anything * package is named well * spec file name is good * package meets Packaging Guidelines * package is licensed with an GPL open-source compatible license * License field in spec file doesn't match actual license * license file is included in %doc * md5sums are matching (82db64d84b6172f5676fcff69d533881) * package successfully compiles on x86_64 * BuildRequires listed well (mock builds fine) * no locales * proper %post and %postun sections * not relocatable * package owns directories well * no duplicates in %files * every %files section includes %defattr * proper %clean section * macros used well * .desktop file is present THINGS to do: * change spec's License field to GPL Fix thing mentioned above and package will be approved,
Woops, good catch. I used a spec from a previous package for this and that stayed in. Here is a version with the license tag fixed: Spec URL: http://people.atrpms.net/~hdegoede/fbg.spec SRPM URL: http://people.atrpms.net/~hdegoede/fbg-0.9-2.fc6.src.rpm
You haven't updated a spec file but a SRPM looks good. So package is APPROVED.
Oops, you're right I forgot to upload the spec. Thanks for looking at the SRPM. I've imported and build the correct/updated srpm, closing. Thanks!