Spec URL: https://jskarvad.fedorapeople.org/qucs-s/qucs-s.spec SRPM URL: https://jskarvad.fedorapeople.org/qucs-s/qucs-s-0.0.24-1.fc35.src.rpm Description: Qucs-S is a spin-off of the Qucs cross-platform circuit simulator. "S" letter indicates SPICE. The purpose of the Qucs-S subproject is to use free SPICE circuit simulation kernels with the Qucs GUI. It merges the power of SPICE and the simplicity of the Qucs GUI. Fedora Account System Username: jskarvad
Unofficial Review: License: GPLv2+ is OK - Header files in -devel subpackage, if present. Note: qucs-s : /usr/share/qucs-s/xspice_cmlib/include/xspice_mathfunc.h See: https://docs.fedoraproject.org/en-US/packaging- guidelines/#_devel_packages Well... There is no -devel package... [!]: Large data in /usr/share should live in a noarch subpackage if package is arched. Note: Arch-ed rpms have a total of 16046080 bytes in /usr/share qucs-s-0.0.24-1.fc37.x86_64.rpm:16046080 See: https://fedoraproject.org/wiki/Packaging:ReviewGuidelines#Package_Review_Guidelines suggests the creation of a noarch -doc subpackage, with examples dir, and some docs if possible. ChangeLog NEWS_qucs README_qucs files are outdated (remove or install in -doc) But the library will remain large in /usr/share ! I can co-maintain: FAS: avigne
(In reply to Alain V. from comment #1) > Unofficial Review: > > License: GPLv2+ > is OK > > - Header files in -devel subpackage, if present. > Note: qucs-s : /usr/share/qucs-s/xspice_cmlib/include/xspice_mathfunc.h > See: https://docs.fedoraproject.org/en-US/packaging- > guidelines/#_devel_packages > > Well... There is no -devel package... > Is it worth to create devel sub-package? > > [!]: Large data in /usr/share should live in a noarch subpackage if package > is arched. > Note: Arch-ed rpms have a total of 16046080 bytes in /usr/share > qucs-s-0.0.24-1.fc37.x86_64.rpm:16046080 > See: > > https://fedoraproject.org/wiki/Packaging: > ReviewGuidelines#Package_Review_Guidelines > > suggests the creation of a noarch -doc subpackage, with examples dir, and > some docs if possible. > ChangeLog NEWS_qucs README_qucs files are outdated (remove or install in > -doc) > > But the library will remain large in /usr/share ! > I will probably split it to the doc subpackage. The library is essential for the functionality, thus I think the library shouldn't be split. > I can co-maintain: FAS: avigne NP I will add you if the package gets to the Fedora.
(In reply to Jaroslav Škarvada from comment #2) > (In reply to Alain V. from comment #1) > > Unofficial Review: > > > > License: GPLv2+ > > is OK > > > > - Header files in -devel subpackage, if present. > > Note: qucs-s : /usr/share/qucs-s/xspice_cmlib/include/xspice_mathfunc.h > > See: https://docs.fedoraproject.org/en-US/packaging- > > guidelines/#_devel_packages > > > > Well... There is no -devel package... > > > Is it worth to create devel sub-package? I don't think so. > > > > > [!]: Large data in /usr/share should live in a noarch subpackage if package > > is arched. > > Note: Arch-ed rpms have a total of 16046080 bytes in /usr/share > > qucs-s-0.0.24-1.fc37.x86_64.rpm:16046080 > > See: > > > > https://fedoraproject.org/wiki/Packaging: > > ReviewGuidelines#Package_Review_Guidelines > > > > suggests the creation of a noarch -doc subpackage, with examples dir, and > > some docs if possible. > > ChangeLog NEWS_qucs README_qucs files are outdated (remove or install in > > -doc) > > > > But the library will remain large in /usr/share ! > > > I will probably split it to the doc subpackage. The library is essential for > the functionality, thus I think the library shouldn't be split. Agree. > > > I can co-maintain: FAS: avigne > > NP I will add you if the package gets to the Fedora. Thank you. I think this will be the "new" Qucs as https://github.com/orgs/Qucs/repositories can indicate, as well as recent https://wiki.f-si.org/index.php?title=Merging_Gnucap_and_Qucs_--_The_Why_and_How discussion.
Spec URL: https://jskarvad.fedorapeople.org/qucs-s/qucs-s.spec SRPM URL: https://jskarvad.fedorapeople.org/qucs-s/qucs-s-0.0.24-2.fc37.src.rpm
Alain are you going to do full review?
(In reply to Jaroslav Škarvada from comment #5) > Alain are you going to do full review? Sorry, I was totally AFK those past days. fedora-review is running ATM, and I am in the packager group. But, I am afraid to say it will be my first "approval" ! I still don't feel legitimate at approving a package... Anyhow, I will review your .spec version 2. From what I read so far, I would advise to change "Qucs-s" into "Qucs-S" in summary and description, as it seems upstream is enforcing this writing. "qucs-s" is the name of the binary.
Summary: I marked [!] on "Obsoletes, Provides" as I think this package should obsolete the qucs package. rpmlint has some suggestions for upstream... Maybe a -library noarch subpackage can be proposed (in the same idea than the -examples subpackage ?) for files in /usr/share/qucs-s/library/ Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed Issues: ======= - Header files in -devel subpackage, if present. Note: qucs-s : /usr/share/qucs-s/xspice_cmlib/include/xspice_mathfunc.h See: https://docs.fedoraproject.org/en-US/packaging- guidelines/#_devel_packages ===== MUST items ===== C/C++: [x]: Package does not contain kernel modules. [x]: Package contains no static executables. [x]: If your application is a C or C++ application you must list a BuildRequires against gcc, gcc-c++ or clang. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "*No copyright* GNU General Public License v2.0 or later", "Unknown or generated", "GNU General Public License, Version 2", "*No copyright* GNU General Public License", "GNU General Public License v2.0 or later", "*No copyright* [generated file]", "FSF All Permissive License", "GNU General Public License", "GNU General Public License, Version 3 LGPL (v2.1 or v3)". 868 files have unknown license. Detailed output of licensecheck in /home/name/rpmbuild/SRPMS/2106445-qucs-s/licensecheck.txt [x]: License file installed when any subpackage combination is installed. [x]: Package must own all directories that it creates. Note: Directories without known owners: /usr/share/icons/hicolor [x]: Package does not own files or directories owned by other packages. Note: Dirs in package are owned also by: /usr/share/icons/hicolor/128x128(vacuum-im, lammps-data, freedroidrpg, redeclipse, yokadi, hicolor-icon-theme, sxiv, klatexformula, wesnoth- data, xchm, qemu-common, qmmp, korganizer), /usr/share/icons/hicolor/128x128/apps(vacuum-im, qucs, freedroidrpg, lammps-data, redeclipse, yokadi, hicolor-icon-theme, sxiv, klatexformula, wesnoth-data, xchm, qemu-common, qmmp, alsa-tools, korganizer), /usr/share/icons/hicolor/16x16(mono-tools, vacuum-im, redeclipse, vim-X11, fedora-logos, hicolor-icon-theme, klatexformula, lammps-data, yokadi, kgraphviewer, eom, sxiv, libgda-tools, wesnoth- data, xchm, qemu-common, qmmp, pdfmod, korganizer), /usr/share/icons/hicolor/16x16/apps(mono-tools, qucs, vacuum-im, redeclipse, vim-X11, fedora-logos, hicolor-icon-theme, klatexformula, lammps-data, yokadi, kgraphviewer, eom, sxiv, libgda-tools, wesnoth- data, xchm, qemu-common, qmmp, pdfmod, korganizer), /usr/share/icons/hicolor/22x22(mono-tools, lammps-data, yokadi, hicolor-icon-theme, libgda-tools, eom, fedora-logos, pdfmod, korganizer), /usr/share/icons/hicolor/22x22/apps(mono-tools, qucs, lammps-data, yokadi, hicolor-icon-theme, libgda-tools, eom, fedora- logos, pdfmod, korganizer), /usr/share/icons/hicolor/256x256(mono- tools, hicolor-icon-theme, libgda-tools, wesnoth-data, qemu-common, fedora-logos, qmmp, pdfmod, korganizer), /usr/share/icons/hicolor/256x256/apps(mono-tools, qucs, hicolor-icon- theme, libgda-tools, wesnoth-data, qemu-common, fedora-logos, qmmp, alsa-tools, pdfmod, korganizer), /usr/share/icons/hicolor/32x32(mono- tools, vacuum-im, redeclipse, vim-X11, fedora-logos, hicolor-icon- theme, klatexformula, freedroidrpg, lammps-data, yokadi, kgraphviewer, eom, sxiv, libgda-tools, wesnoth-data, xchm, qemu-common, qmmp, pdfmod, korganizer), /usr/share/icons/hicolor/32x32/apps(mono-tools, qucs, vacuum-im, redeclipse, vim-X11, fedora-logos, hicolor-icon- theme, klatexformula, freedroidrpg, lammps-data, yokadi, kgraphviewer, eom, sxiv, libgda-tools, wesnoth-data, xchm, qemu-common, qmmp, pdfmod, korganizer), /usr/share/icons/hicolor/48x48(mono-tools, lxqt- config, freedroidrpg, lammps-data, vacuum-im, redeclipse, yokadi, hicolor-icon-theme, vim-X11, sxiv, libgda-tools, tuxanci, xchm, qemu- common, qmmp, nedit, fedora-logos, korganizer), /usr/share/icons/hicolor/48x48/apps(mono-tools, qucs, vacuum-im, redeclipse, vim-X11, tuxanci, alsa-tools, fedora-logos, hicolor-icon- theme, freedroidrpg, lammps-data, yokadi, lxqt-config, sxiv, libgda- tools, xchm, qemu-common, qmmp, nedit, korganizer), /usr/share/icons/hicolor/512x512(android-file-transfer, hicolor-icon- theme, qemu-common, wesnoth-data), /usr/share/icons/hicolor/512x512/apps(qucs, android-file-transfer, hicolor-icon-theme, wesnoth-data, qemu-common), /usr/share/icons/hicolor/64x64(vacuum-im, qterminal, lammps-data, freedroidrpg, redeclipse, yokadi, hicolor-icon-theme, vim-X11, sxiv, klatexformula, wesnoth-data, qemu-common, qmmp, korganizer), /usr/share/icons/hicolor/64x64/apps(vacuum-im, qterminal, lammps-data, freedroidrpg, qucs, redeclipse, yokadi, hicolor-icon-theme, vim-X11, sxiv, klatexformula, wesnoth-data, qemu-common, qmmp, korganizer), /usr/share/icons/hicolor/scalable(freedroidrpg, fedora-logos, dxf2gcode, autokey-common, hicolor-icon-theme, massif-visualizer, budgie-control-center-common, klatexformula, lxqt-powermanagement, tuxanci, qemu-common, swappy, eom, wdisplays, qmmp, pdfmod, korganizer, qtl866), /usr/share/icons/hicolor/scalable/apps(qucs, freedroidrpg, fedora-logos, dxf2gcode, autokey-common, hicolor-icon- theme, massif-visualizer, budgie-control-center-common, klatexformula, tuxanci, qemu-common, swappy, eom, wdisplays, qmmp, pdfmod, korganizer, qtl866) [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Development files must be in a -devel package [-]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [!]: If the package is a rename of another package, proper Obsoletes and Provides are present. [-]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 20480 bytes in 5 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Package contains desktop file if it is a GUI application. [x]: Package installs a %{name}.desktop using desktop-file-install or desktop-file-validate if there is such a file. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [ ]: Final provides and requires are sane (see attachments). [x]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in qucs-s- examples [x]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [x]: Patches link to upstream bugs/comments/lists or are otherwise justified. [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [x]: Package should compile and build into binary rpms on all supported architectures. [!]: %check is present and all tests pass. [?]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [!]: Large data in /usr/share should live in a noarch subpackage if package is arched. Note: Arch-ed rpms have a total of 5611520 bytes in /usr/share [x]: Rpmlint is run on debuginfo package(s). Note: There are rpmlint messages (see attachment). [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Cannot parse rpmlint output: Rpmlint (debuginfo) ------------------- Cannot parse rpmlint output: Rpmlint (installed packages) ---------------------------- Cannot parse rpmlint output: Source checksums ---------------- https://github.com/ra3xdh/qucs_s/archive/0.0.24/qucs_s-0.0.24.tar.gz : CHECKSUM(SHA256) this package : f4d26c146ce8d2bd6d5837ef288d87eeed9399e09c21376c858543d6e55caeed CHECKSUM(SHA256) upstream package : f4d26c146ce8d2bd6d5837ef288d87eeed9399e09c21376c858543d6e55caeed Requires -------- qucs-s (rpmlib, GLIBC filtered): libQt5Core.so.5()(64bit) libQt5Core.so.5(Qt_5)(64bit) libQt5Core.so.5(Qt_5.15)(64bit) libQt5Gui.so.5()(64bit) libQt5Gui.so.5(Qt_5)(64bit) libQt5PrintSupport.so.5()(64bit) libQt5PrintSupport.so.5(Qt_5)(64bit) libQt5Svg.so.5()(64bit) libQt5Svg.so.5(Qt_5)(64bit) libQt5Widgets.so.5()(64bit) libQt5Widgets.so.5(Qt_5)(64bit) libc.so.6()(64bit) libgcc_s.so.1()(64bit) libgcc_s.so.1(GCC_3.0)(64bit) libgcc_s.so.1(GCC_3.3.1)(64bit) libgcc_s.so.1(GCC_4.0.0)(64bit) libm.so.6()(64bit) libstdc++.so.6()(64bit) libstdc++.so.6(CXXABI_1.3)(64bit) libstdc++.so.6(CXXABI_1.3.8)(64bit) ngspice rtld(GNU_HASH) qucs-s-examples (rpmlib, GLIBC filtered): qucs-s qucs-s-debuginfo (rpmlib, GLIBC filtered): qucs-s-debugsource (rpmlib, GLIBC filtered): Provides -------- qucs-s: application() application(qucs-s.desktop) qucs-s qucs-s(x86-64) qucs-s-examples: qucs-s-examples qucs-s-debuginfo: debuginfo(build-id) qucs-s-debuginfo qucs-s-debuginfo(x86-64) qucs-s-debugsource: qucs-s-debugsource qucs-s-debugsource(x86-64) Generated by fedora-review 0.8.0 (e988316) last change: 2022-04-07 Command line :/usr/bin/fedora-review -b 2106445 Buildroot used: fedora-rawhide-x86_64 Active plugins: Generic, Shell-api, C/C++ Disabled plugins: Python, PHP, Haskell, Java, SugarActivity, fonts, R, Perl, Ocaml Disabled flags: EPEL6, EPEL7, DISTTAG, BATCH, EXARCH rpmlint qucs-s-0.0.24-2.fc37.src.rpm ==================================================================================== rpmlint session starts =============================================================================== rpmlint: 2.2.0 configuration: /usr/lib/python3.10/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/licenses.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 32, packages: 1 ===================================================== 1 packages and 0 specfiles checked; 0 errors, 0 warnings, 0 badness; has taken 0.2 s ==================================================== rpmlint qucs-s-examples-0.0.24-2.fc37.noarch.rpm ==================================================================================== rpmlint session starts =============================================================================== rpmlint: 2.2.0 configuration: /usr/lib/python3.10/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/licenses.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 32, packages: 1 qucs-s-examples.noarch: E: zero-length /usr/share/qucs-s/examples/ngspice/BJT-swp.dpl qucs-s-examples.noarch: W: no-documentation qucs-s-examples.noarch: W: files-duplicate /usr/share/qucs-s/examples/external_interface/m-interface/boostconverter.net /usr/share/qucs-s/examples/external_interface/cpp-interface/boostconverter.net qucs-s-examples.noarch: W: devel-file-in-non-devel-package /usr/share/qucs-s/examples/external_interface/cpp-interface/main.cpp ===================================================== 1 packages and 0 specfiles checked; 1 errors, 3 warnings, 1 badness; has taken 0.2 s ==================================================== rpmlint qucs-s-0.0.24-2.fc37.x86_64.rpm ==================================================================================== rpmlint session starts =============================================================================== rpmlint: 2.2.0 configuration: /usr/lib/python3.10/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/licenses.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 32, packages: 1 qucs-s.x86_64: W: no-manual-page-for-binary qucs-sactivefilter qucs-s.x86_64: W: no-manual-page-for-binary qucs-sfilter qucs-s.x86_64: W: no-manual-page-for-binary qucs-slib qucs-s.x86_64: W: devel-file-in-non-devel-package /usr/share/qucs-s/xspice_cmlib/include/xspice_mathfunc.h ===================================================== 1 packages and 0 specfiles checked; 0 errors, 4 warnings, 0 badness; has taken 2.0 s ================================================
I would make qucs-s-library package with noarch *.lib files, on which main arch package would depend. I find a little suspicious xspice_cmlib/include/xspice_mathfunc.h header. I do not understand how should it be used and for what exactly. It might be part of examples package. In case it is some kind of binding, it should have subpackage ending with cmlib-devel or similar. Otherwise I think Alain V. did a good job and should take the bug and move it to assigned. And set review flag to '?'.
(In reply to Alain V. from comment #6) Thanks for the review. > (In reply to Jaroslav Škarvada from comment #5) > > Alain are you going to do full review? > Sorry, I was totally AFK those past days. > fedora-review is running ATM, and I am in the packager group. But, I am > afraid to say it will be my first "approval" ! > I still don't feel legitimate at approving a package... > Anyhow, I will review your .spec version 2. > > From what I read so far, I would advise to change "Qucs-s" into "Qucs-S" in > summary and description, as it seems upstream is enforcing this writing. > "qucs-s" is the name of the binary. There should be already Qucs-S. The current summary is: "Qucs circuit simulator which works with SPICE" Which I think it's OK, it says it's Qucs like simulator.
(In reply to Petr Menšík from comment #8) > I would make qucs-s-library package with noarch *.lib files, on which main > arch package would depend. I find a little suspicious > xspice_cmlib/include/xspice_mathfunc.h header. I do not understand how > should it be used and for what exactly. I think it's for creation of the spice cmlib models, which are binary compiled, so let's package it to the -devel subpackage.
Spec URL: https://jskarvad.fedorapeople.org/qucs-s/qucs-s.spec SRPM URL: https://jskarvad.fedorapeople.org/qucs-s/qucs-s-0.0.24-3.fc37.src.rpm
Thank you for this quick improvement, Jaroslav. What I meant about summary and description is: diff qucs-s.spec qucs-s.av.spec 35c35 < Summary: Qucs-s library --- > Summary: Qucs-S library 41c41 < Qucs-s library. --- > Qucs-S library. 45c45 < Summary: Qucs-s development files --- > Summary: Qucs-S development files 50c50 < Qucs-s development files. --- > Qucs-S development files. 54c54 < Summary: Qucs-s examples --- > Summary: Qucs-S examples 60c60 < Qucs-s examples. --- > Qucs-S examples. This is minor. I think installing the main package will need also the library. A `suggests` might be useful, no ? I will fedora-review this version 3...
=== APPROVED === My previous suggestions could be (or not) included during import. Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed ===== MUST items ===== C/C++: [x]: Package does not contain kernel modules. [x]: Package contains no static executables. [x]: If your application is a C or C++ application you must list a BuildRequires against gcc, gcc-c++ or clang. [x]: Header files in -devel subpackage, if present. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "*No copyright* GNU General Public License v2.0 or later", "Unknown or generated", "GNU General Public License, Version 2", "*No copyright* GNU General Public License", "GNU General Public License v2.0 or later", "*No copyright* [generated file]", "FSF All Permissive License", "GNU General Public License", "GNU General Public License, Version 3 LGPL (v2.1 or v3)". 868 files have unknown license. Detailed output of licensecheck in /home/name/rpmbuild/SRPMS/2106445-qucs-s/licensecheck.txt [x]: License file installed when any subpackage combination is installed. [x]: Package must own all directories that it creates. Note: Directories without known owners: /usr/share/icons/hicolor [x]: Package does not own files or directories owned by other packages. Note: Dirs in package are owned also by: /usr/share/icons/hicolor/128x128(vacuum-im, qemu-common, freedroidrpg, hicolor-icon-theme, lammps-data, redeclipse, sxiv, wesnoth-data, qmmp, xchm, yokadi, klatexformula, korganizer), /usr/share/icons/hicolor/128x128/apps(vacuum-im, alsa-tools, qemu- common, freedroidrpg, hicolor-icon-theme, lammps-data, redeclipse, sxiv, wesnoth-data, qmmp, xchm, yokadi, qucs, klatexformula, korganizer), /usr/share/icons/hicolor/16x16(qemu-common, libgda-tools, klatexformula, lammps-data, eom, wesnoth-data, vacuum-im, hicolor- icon-theme, sxiv, redeclipse, yokadi, kgraphviewer, korganizer, fedora-logos, vim-X11, xchm, mono-tools, qmmp, pdfmod), /usr/share/icons/hicolor/16x16/apps(qemu-common, libgda-tools, klatexformula, lammps-data, eom, wesnoth-data, qucs, vacuum-im, hicolor-icon-theme, sxiv, redeclipse, yokadi, kgraphviewer, korganizer, fedora-logos, vim-X11, xchm, mono-tools, qmmp, pdfmod), /usr/share/icons/hicolor/22x22(libgda-tools, hicolor-icon-theme, lammps-data, eom, mono-tools, yokadi, pdfmod, korganizer, fedora- logos), /usr/share/icons/hicolor/22x22/apps(libgda-tools, hicolor- icon-theme, lammps-data, eom, mono-tools, yokadi, pdfmod, qucs, korganizer, fedora-logos), /usr/share/icons/hicolor/256x256(qemu- common, libgda-tools, hicolor-icon-theme, wesnoth-data, mono-tools, qmmp, pdfmod, korganizer, fedora-logos), /usr/share/icons/hicolor/256x256/apps(alsa-tools, qemu-common, libgda- tools, hicolor-icon-theme, wesnoth-data, mono-tools, qmmp, pdfmod, qucs, korganizer, fedora-logos), /usr/share/icons/hicolor/32x32(qemu- common, libgda-tools, freedroidrpg, klatexformula, lammps-data, eom, wesnoth-data, vacuum-im, hicolor-icon-theme, sxiv, redeclipse, yokadi, kgraphviewer, korganizer, fedora-logos, vim-X11, xchm, mono-tools, qmmp, pdfmod), /usr/share/icons/hicolor/32x32/apps(qemu-common, libgda-tools, freedroidrpg, klatexformula, lammps-data, eom, wesnoth- data, qucs, vacuum-im, hicolor-icon-theme, sxiv, redeclipse, yokadi, kgraphviewer, korganizer, fedora-logos, vim-X11, xchm, mono-tools, qmmp, pdfmod), /usr/share/icons/hicolor/48x48(vacuum-im, qemu-common, libgda-tools, tuxanci, freedroidrpg, lammps-data, hicolor-icon-theme, nedit, redeclipse, mono-tools, qmmp, sxiv, vim-X11, xchm, yokadi, lxqt-config, korganizer, fedora-logos), /usr/share/icons/hicolor/48x48/apps(qemu-common, libgda-tools, tuxanci, freedroidrpg, lammps-data, lxqt-config, qucs, vacuum-im, hicolor-icon-theme, sxiv, redeclipse, yokadi, korganizer, fedora- logos, alsa-tools, vim-X11, nedit, xchm, mono-tools, qmmp), /usr/share/icons/hicolor/512x512(hicolor-icon-theme, android-file- transfer, qemu-common, wesnoth-data), /usr/share/icons/hicolor/512x512/apps(qemu-common, hicolor-icon-theme, wesnoth-data, qucs, android-file-transfer), /usr/share/icons/hicolor/64x64(vacuum-im, qemu-common, freedroidrpg, hicolor-icon-theme, lammps-data, qterminal, redeclipse, sxiv, qmmp, vim-X11, wesnoth-data, yokadi, klatexformula, korganizer), /usr/share/icons/hicolor/64x64/apps(vacuum-im, qemu-common, freedroidrpg, hicolor-icon-theme, lammps-data, qterminal, redeclipse, sxiv, qmmp, vim-X11, wesnoth-data, yokadi, qucs, klatexformula, korganizer), /usr/share/icons/hicolor/scalable(budgie-control-center- common, qemu-common, fedora-logos, tuxanci, freedroidrpg, hicolor- icon-theme, eom, qtl866, lxqt-powermanagement, qmmp, pdfmod, wdisplays, autokey-common, massif-visualizer, swappy, klatexformula, korganizer, dxf2gcode), /usr/share/icons/hicolor/scalable/apps(budgie- control-center-common, qemu-common, fedora-logos, tuxanci, freedroidrpg, hicolor-icon-theme, eom, qtl866, qmmp, pdfmod, wdisplays, autokey-common, massif-visualizer, qucs, swappy, klatexformula, korganizer, dxf2gcode) [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [x]: Development files must be in a -devel package [-]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [!]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [-]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 20480 bytes in 5 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Package contains desktop file if it is a GUI application. [x]: Package installs a %{name}.desktop using desktop-file-install or desktop-file-validate if there is such a file. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [?]: Final provides and requires are sane (see attachments). [x]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in qucs-s- library , qucs-s-examples [x]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [x]: Patches link to upstream bugs/comments/lists or are otherwise justified. [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [x]: Package should compile and build into binary rpms on all supported architectures. [!]: %check is present and all tests pass. [?]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. Note: Arch-ed rpms have a total of 3532800 bytes in /usr/share [x]: Rpmlint is run on debuginfo package(s). Note: There are rpmlint messages (see attachment). [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Cannot parse rpmlint output: Rpmlint (debuginfo) ------------------- Cannot parse rpmlint output: Rpmlint (installed packages) ---------------------------- Cannot parse rpmlint output: Source checksums ---------------- https://github.com/ra3xdh/qucs_s/archive/0.0.24/qucs_s-0.0.24.tar.gz : CHECKSUM(SHA256) this package : f4d26c146ce8d2bd6d5837ef288d87eeed9399e09c21376c858543d6e55caeed CHECKSUM(SHA256) upstream package : f4d26c146ce8d2bd6d5837ef288d87eeed9399e09c21376c858543d6e55caeed Requires -------- qucs-s (rpmlib, GLIBC filtered): libQt5Core.so.5()(64bit) libQt5Core.so.5(Qt_5)(64bit) libQt5Core.so.5(Qt_5.15)(64bit) libQt5Gui.so.5()(64bit) libQt5Gui.so.5(Qt_5)(64bit) libQt5PrintSupport.so.5()(64bit) libQt5PrintSupport.so.5(Qt_5)(64bit) libQt5Svg.so.5()(64bit) libQt5Svg.so.5(Qt_5)(64bit) libQt5Widgets.so.5()(64bit) libQt5Widgets.so.5(Qt_5)(64bit) libc.so.6()(64bit) libgcc_s.so.1()(64bit) libgcc_s.so.1(GCC_3.0)(64bit) libgcc_s.so.1(GCC_3.3.1)(64bit) libgcc_s.so.1(GCC_4.0.0)(64bit) libm.so.6()(64bit) libstdc++.so.6()(64bit) libstdc++.so.6(CXXABI_1.3)(64bit) libstdc++.so.6(CXXABI_1.3.8)(64bit) ngspice rtld(GNU_HASH) qucs-s-library (rpmlib, GLIBC filtered): qucs-s qucs-s-devel (rpmlib, GLIBC filtered): qucs-s(x86-64) qucs-s-examples (rpmlib, GLIBC filtered): qucs-s qucs-s-debuginfo (rpmlib, GLIBC filtered): qucs-s-debugsource (rpmlib, GLIBC filtered): Provides -------- qucs-s: application() application(qucs-s.desktop) qucs-s qucs-s(x86-64) qucs-s-library: qucs-s-library qucs-s-devel: qucs-s-devel qucs-s-devel(x86-64) qucs-s-examples: qucs-s-examples qucs-s-debuginfo: debuginfo(build-id) qucs-s-debuginfo qucs-s-debuginfo(x86-64) qucs-s-debugsource: qucs-s-debugsource qucs-s-debugsource(x86-64) Generated by fedora-review 0.8.0 (e988316) last change: 2022-04-07 Command line :/usr/bin/fedora-review -b 2106445 Buildroot used: fedora-rawhide-x86_64 Active plugins: C/C++, Generic, Shell-api Disabled plugins: Haskell, Perl, SugarActivity, fonts, Python, Ocaml, R, PHP, Java Disabled flags: EPEL6, EPEL7, DISTTAG, BATCH, EXARCH $ rpmlint qucs-s-0.0.24-3.fc37.x86_64.rpm ==================================== rpmlint session starts =================================== rpmlint: 2.2.0 configuration: /usr/lib/python3.10/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/licenses.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 32, packages: 1 qucs-s.x86_64: W: no-manual-page-for-binary qucs-sactivefilter qucs-s.x86_64: W: no-manual-page-for-binary qucs-sfilter qucs-s.x86_64: W: no-manual-page-for-binary qucs-slib ===== 1 packages and 0 specfiles checked; 0 errors, 3 warnings, 0 badness; has taken 0.4 s ==== $rpmlint qucs-s-library-0.0.24-3.fc37.noarch.rpm ==================================== rpmlint session starts =================================== rpmlint: 2.2.0 configuration: /usr/lib/python3.10/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/licenses.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 32, packages: 1 qucs-s-library.noarch: W: no-documentation ===== 1 packages and 0 specfiles checked; 0 errors, 1 warnings, 0 badness; has taken 0.1 s ==== $ rpmlint qucs-s-examples-0.0.24-3.fc37.noarch.rpm ==================================== rpmlint session starts =================================== rpmlint: 2.2.0 configuration: /usr/lib/python3.10/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/licenses.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 32, packages: 1 qucs-s-examples.noarch: E: zero-length /usr/share/qucs-s/examples/ngspice/BJT-swp.dpl qucs-s-examples.noarch: W: no-documentation qucs-s-examples.noarch: W: files-duplicate /usr/share/qucs-s/examples/external_interface/m-interface/boostconverter.net /usr/share/qucs-s/examples/external_interface/cpp-interface/boostconverter.net qucs-s-examples.noarch: W: devel-file-in-non-devel-package /usr/share/qucs-s/examples/external_interface/cpp-interface/main.cpp ===== 1 packages and 0 specfiles checked; 1 errors, 3 warnings, 1 badness; has taken 0.2 s ==== (An empty file + duplicate to report upstream) $ rpmlint qucs-s-devel-0.0.24-3.fc37.x86_64.rpm ==================================== rpmlint session starts =================================== rpmlint: 2.2.0 configuration: /usr/lib/python3.10/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/licenses.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 32, packages: 1 qucs-s-devel.x86_64: W: no-documentation ===== 1 packages and 0 specfiles checked; 0 errors, 1 warnings, 0 badness; has taken 0.0 s ====
Thanks for the review, I fixed the small S (hopefully) and used Recommends: for the library, because I think it should be installed by default, although it can be weak-dep. Spec URL: https://jskarvad.fedorapeople.org/qucs-s/qucs-s.spec SRPM URL: https://jskarvad.fedorapeople.org/qucs-s/qucs-s-0.0.24-4.fc37.src.rpm
What is next step ? You request the repo ? I do something ?
(In reply to Alain V. from comment #15) > What is next step ? You request the repo ? I do something ? Could you please take the bugzilla (i.e. assign it to yourself), because my SCM request was dropped as invalid due to it.
(In reply to Jaroslav Škarvada from comment #16) > (In reply to Alain V. from comment #15) > > What is next step ? You request the repo ? I do something ? > > Could you please take the bugzilla (i.e. assign it to yourself), done > because my SCM request was dropped as invalid due to it. Sorry about that.
(fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/qucs-s
FEDORA-2022-11562f1ce3 has been submitted as an update to Fedora 37. https://bodhi.fedoraproject.org/updates/FEDORA-2022-11562f1ce3
FEDORA-2022-4dd476ce11 has been submitted as an update to Fedora 36. https://bodhi.fedoraproject.org/updates/FEDORA-2022-4dd476ce11
FEDORA-2022-c850e93a42 has been submitted as an update to Fedora 35. https://bodhi.fedoraproject.org/updates/FEDORA-2022-c850e93a42
FEDORA-2022-11562f1ce3 has been pushed to the Fedora 37 stable repository. If problem still persists, please make note of it in this bug report.
FEDORA-2022-4dd476ce11 has been pushed to the Fedora 36 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2022-4dd476ce11 \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2022-4dd476ce11 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
FEDORA-2022-c850e93a42 has been pushed to the Fedora 35 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2022-c850e93a42 \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2022-c850e93a42 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
FEDORA-2022-4dd476ce11 has been pushed to the Fedora 36 stable repository. If problem still persists, please make note of it in this bug report.
FEDORA-2022-c850e93a42 has been pushed to the Fedora 35 stable repository. If problem still persists, please make note of it in this bug report.