RHEL Engineering is moving the tracking of its product development work on RHEL 6 through RHEL 9 to Red Hat Jira (issues.redhat.com). If you're a Red Hat customer, please continue to file support cases via the Red Hat customer portal. If you're not, please head to the "RHEL project" in Red Hat Jira and file new tickets here. Individual Bugzilla bugs in the statuses "NEW", "ASSIGNED", and "POST" are being migrated throughout September 2023. Bugs of Red Hat partners with an assigned Engineering Partner Manager (EPM) are migrated in late September as per pre-agreed dates. Bugs against components "kernel", "kernel-rt", and "kpatch" are only migrated if still in "NEW" or "ASSIGNED". If you cannot log in to RH Jira, please consult article #7032570. That failing, please send an e-mail to the RH Jira admins at rh-issues@redhat.com to troubleshoot your issue as a user management inquiry. The email creates a ServiceNow ticket with Red Hat. Individual Bugzilla bugs that are migrated will be moved to status "CLOSED", resolution "MIGRATED", and set with "MigratedToJIRA" in "Keywords". The link to the successor Jira issue will be found under "Links", have a little "two-footprint" icon next to it, and direct you to the "RHEL project" in Red Hat Jira (issue links are of type "https://issues.redhat.com/browse/RHEL-XXXX", where "X" is a digit). This same link will be available in a blue banner at the top of the page informing you that that bug has been migrated.
Bug 2107424 - "mem lock limit" of qemu process is not restored when kill src virtqemud during zerocopy migration.
Summary: "mem lock limit" of qemu process is not restored when kill src virtqemud duri...
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Red Hat Enterprise Linux 9
Classification: Red Hat
Component: libvirt
Version: 9.1
Hardware: Unspecified
OS: Unspecified
medium
medium
Target Milestone: rc
: ---
Assignee: Jiri Denemark
QA Contact: Fangge Jin
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2022-07-15 02:09 UTC by Fangge Jin
Modified: 2022-11-15 10:41 UTC (History)
5 users (show)

Fixed In Version: libvirt-8.5.0-4.el9
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2022-11-15 10:04:39 UTC
Type: Bug
Target Upstream Version: 8.6.0
Embargoed:

Attachments (Terms of Use)
virtqemud log (108.18 KB, application/x-bzip)
2022-07-15 02:09 UTC, Fangge Jin 		no flags Details
Show Obsolete (1) View All


Links
System ID Private Priority Status Summary Last Updated
Red Hat Issue Tracker LIBVIRTAT-13416 0 None None None 2022-09-20 17:04:48 UTC
Red Hat Issue Tracker RHELPLAN-127800 0 None None None 2022-07-15 02:17:03 UTC
Red Hat Product Errata RHSA-2022:8003 0 None None None 2022-11-15 10:05:06 UTC

Description Fangge Jin 2022-07-15 02:09:50 UTC 
Created attachment 1897265 [details]
virtqemud log

Description of problem:
Start vm, do zerocopy migration, kill src virtqemud before migration completes.
"mem lock limit"(prlimit) of qemu process is not restored to original value.

Version-Release number of selected component (if applicable):
libvirt-8.5.0-1.el9.x86_64
qemu-kvm-7.0.0-8.el9.x86_64

How reproducible:
100%

Steps to Reproduce:
1. Start vm

2. Check mem lock limit of qemu process:
# prlimit -p `pidof qemu-kvm` -l
RESOURCE DESCRIPTION                            SOFT     HARD UNITS
MEMLOCK  max locked-in-memory address space 67108864 67108864 bytes

3. Do zerocopy migration
# virsh migrate vm1 qemu+tcp://dell-per640***/system --live --p2p --zerocopy --parallel --bandwidth 10

4. Check mem lock limit of qemu process:
# prlimit -p `pidof qemu-kvm` -l
RESOURCE DESCRIPTION                              SOFT       HARD UNITS
MEMLOCK  max locked-in-memory address space 2147483648 2147483648 bytes

5. Kill source virtqemud before migration completes. It will be restarted immediately by systemd. And migration fails as expected.
# pkill -9 virtqemud

6. Check mem lock limit of qemu process:
# prlimit -p `pidof qemu-kvm` -l
RESOURCE DESCRIPTION                              SOFT       HARD UNITS
MEMLOCK  max locked-in-memory address space 2147483648 2147483648 bytes


Actual results:
In step6, mem lock limit of qemu process is not restored

Expected results:
In step6, mem lock limit of qemu process should be restored to original value.

Additional info:
Comment 2 Jiri Denemark 2022-07-27 13:34:01 UTC 
Fix sent upstream for review: https://listman.redhat.com/archives/libvir-list/2022-July/233273.html
Comment 3 Jiri Denemark 2022-07-28 11:13:07 UTC 
Fixed upstream by

commit bb9badb9168ad0d40bca86b6463ef504624f096d
Refs: v8.6.0-rc1-7-gbb9badb916
Author:     Jiri Denemark <jdenemar>
AuthorDate: Wed Jul 27 14:33:23 2022 +0200
Commit:     Jiri Denemark <jdenemar>
CommitDate: Thu Jul 28 13:04:45 2022 +0200

    qemu: Restore original memory locking limit on reconnect

    Commit v8.4.0-287-gd4d3bb8130 tried to make sure the original
    pre-migration memory locking limit is restored at the end of migration,
    but it missed the case when libvirt daemon is restarted during
    migration which needs to be aborted on reconnect.

    And if this was not enough, I forgot to actually save the status XML
    after setting the field in priv (in the commit mentioned above and also
    in v8.4.0-291-gd375993ab3).

    https://bugzilla.redhat.com/show_bug.cgi?id=2107424

    Signed-off-by: Jiri Denemark <jdenemar>
    Reviewed-by: Michal Privoznik <mprivozn>
Comment 4 Jiri Denemark 2022-07-29 08:10:04 UTC 
Backported as part of https://gitlab.com/redhat/rhel/src/libvirt/-/merge_requests/40
Comment 5 Fangge Jin 2022-08-01 08:48:47 UTC 
Versions:
libvirt-8.5.0-4.el9.x86_64
qemu-kvm-7.0.0-9.el9.x86_64

Test matrix:
non-p2p, kill src virtqemud, pass
non-p2p, kill dest virtqemud, pass
non-p2p, kill dest virtproxyd, pass
p2p, kill src virtqemud, pass
p2p, kill dest virtqemud, pass
p2p, kill dest virtproxyd, pass
Comment 8 Fangge Jin 2022-08-11 04:48:31 UTC 
Verified with
libvirt-8.5.0-5.el9.x86_64
qemu-kvm-7.0.0-10.el9.x86_64
Comment 10 errata-xmlrpc 2022-11-15 10:04:39 UTC 
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (Low: libvirt security, bug fix, and enhancement update), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHSA-2022:8003
Note You need to log in before you can comment on or make changes to this bug.