Bug 2107945 - Review Request: rust-data-encoding-macro - Macros for data-encoding
Summary: Review Request: rust-data-encoding-macro - Macros for data-encoding
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Fabio Valentini
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On: 2107944
Blocks: 1980198
TreeView+ depends on / blocked
 
Reported: 2022-07-17 22:20 UTC by Davide Cavalca
Modified: 2022-08-14 03:01 UTC (History)
2 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2022-08-13 15:54:09 UTC
Type: ---
Embargoed:
decathorpe: fedora-review+


Attachments (Terms of Use)

Comment 1 Fabio Valentini 2022-08-11 16:46:09 UTC
Package was generated with rust2rpm, simplifying the review.

- package builds and installs without errors on rawhide
- test suite is run and all unit tests pass
- latest version of the crate is packaged
- license matches upstream specification (MIT) and is acceptable for Fedora
- license file is included with %license in %files
- package complies with Rust Packaging Guidelines

Package APPROVED.

===

Recommended post-import rust-sig tasks:

- add @rust-sig with "commit" access as package co-maintainer

- set bugzilla assignee overrides to @rust-sig (optional)

- set up package on release-monitoring.org:
  project: $crate
  homepage: https://crates.io/crates/$crate
  backend: crates.io
  version scheme: semantic
  version filter: alpha;beta;rc;pre
  distro: Fedora
  Package: rust-$crate

- track package in koschei for all built branches

===

Consider re-generating the .spec file with rust2rpm v22 before importing the package.
But since this is such a simple package, it won't make much of a difference, either way.

Comment 2 Davide Cavalca 2022-08-11 18:58:15 UTC
Thanks!

$ fedpkg request-repo rust-data-encoding-macro 2107945
https://pagure.io/releng/fedora-scm-requests/issue/46386
$ fedpkg request-branch --repo rust-data-encoding-macro f37
https://pagure.io/releng/fedora-scm-requests/issue/46387
$ fedpkg request-branch --repo rust-data-encoding-macro f36
https://pagure.io/releng/fedora-scm-requests/issue/46388
$ fedpkg request-branch --repo rust-data-encoding-macro f35
https://pagure.io/releng/fedora-scm-requests/issue/46389

Comment 3 Gwyn Ciesla 2022-08-11 19:05:08 UTC
(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-data-encoding-macro

Comment 4 Fedora Update System 2022-08-13 15:52:54 UTC
FEDORA-2022-ede5aaa465 has been submitted as an update to Fedora 38. https://bodhi.fedoraproject.org/updates/FEDORA-2022-ede5aaa465

Comment 5 Fedora Update System 2022-08-13 15:54:09 UTC
FEDORA-2022-ede5aaa465 has been pushed to the Fedora 38 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 6 Fedora Update System 2022-08-13 16:04:45 UTC
FEDORA-2022-bdf15fb26e has been submitted as an update to Fedora 37. https://bodhi.fedoraproject.org/updates/FEDORA-2022-bdf15fb26e

Comment 7 Fedora Update System 2022-08-13 16:06:13 UTC
FEDORA-2022-bdf15fb26e has been pushed to the Fedora 37 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 8 Fedora Update System 2022-08-13 16:17:43 UTC
FEDORA-2022-05497408c0 has been submitted as an update to Fedora 36. https://bodhi.fedoraproject.org/updates/FEDORA-2022-05497408c0

Comment 9 Fedora Update System 2022-08-13 16:32:14 UTC
FEDORA-2022-366906e2b6 has been submitted as an update to Fedora 35. https://bodhi.fedoraproject.org/updates/FEDORA-2022-366906e2b6

Comment 10 Fedora Update System 2022-08-14 02:37:47 UTC
FEDORA-2022-05497408c0 has been pushed to the Fedora 36 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 11 Fedora Update System 2022-08-14 03:01:25 UTC
FEDORA-2022-366906e2b6 has been pushed to the Fedora 35 stable repository.
If problem still persists, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.