Red Hat Bugzilla – Bug 210826
Review Request: genius - An arbitrary precision integer and multiple precision floatingpoint calculator
Last modified: 2007-11-30 17:11:45 EST
Spec URL: http://math.ifi.unizh.ch/fedora/spec/genius.spec SRPM URL: http://math.ifi.unizh.ch/fedora/5/i386/SRPMS.gemi/genius-0.7.6.1-1.src.rpm Description: Genius is a calculator program similar in some aspects to BC, Matlab or Maple. GEL is the name of its extension language, in fact, a large part of the standard genius functions are written in GEL itself.
Hi Gerard, I just tried: mock -r fedora-5-i386-core genius-0.7.6.1-1.src.rpm and it failed with the message: checking for XML::Parser... configure: error: XML::Parser perl module is required for intltool so it looks like a missing BR.
I forgot to run it through mock. This one should work: http://math.ifi.unizh.ch/fedora/5/i386/SRPMS.gemi/genius-0.7.6.1-2.src.rpm
OK, the -2 release now builds with mock! needswork: - rpmlint reports: E: genius-debuginfo script-without-shebang /usr/src/debug/genius-0.7.6.1/mpfr/mul.c W: genius-devel no-documentation W: gnome-genius no-documentation the warnings are harmless and can be ignored but the error can be fixed by changing the file's permissions within the build dir. good: + spec is legible + source matches upstream + license looks good and is correctly included + spec file looks sane and is legible + builds in mock on FC-5 i386 + uses %find_lang macro correctly + dir ownership look OK + appears to have no shared libs + permissions look good (except for the one exception above) + has proper clean section and command + proper use of devel + code not content + no *.la files + scripts appear to be sane + proper use of desktop-file-install + consistent use of macros + installs and runs without seg-faulting on i386 FC-5 I don't see any blockers here so its APPROVED. Please fix the permissions on that one file before submitting the first build.
Some notes from me: Requires(post): shared-mime-info, desktop-file-utils, scrollkeeper Requires(postun): shared-mime-info, desktop-file-utils, scrollkeeper All this requires should be for gnome-genius. Please fix this.
FYI, See: http://fedoraproject.org/wiki/Packaging/ScriptletSnippets that no new dependancies (like for shared-mime-info or desktop-file-utils) need be added, so likely all you really want/need is: Requires(post): scrollkeeper Requires(postun): scrollkeeper
I fixed the permissions and the Requires, and imported into cvs.
Built on FC5 and FC6. Added entry to owners and comps files. Thanks for the review.
Good work! Please close it and remove from Extras/SIGs/SciTech proposals page.