Spec URL: https://xvitaly.fedorapeople.org/for-review/fmt8.spec SRPM URL: https://xvitaly.fedorapeople.org/for-review/fmt8-8.1.1-6.fc36.src.rpm Description: Compatibility version of the fmt library Fedora Account System Username: xvitaly
--- /dev/fd/63 2022-07-19 13:43:20.669980478 +0200 +++ /dev/fd/62 2022-07-19 13:43:20.669980478 +0200 @@ -1,47 +1,46 @@ -Name: fmt -Version: 8.1.1 -Release: 5%{?dist} - -License: BSD -Summary: Small, safe and fast formatting library for C++ -URL: https://github.com/fmtlib/%{name} -Source0: %{url}/archive/%{version}.tar.gz +%global appname fmt + +Name: fmt8 +Version: 8.1.1 +Release: 6%{?dist} + +License: BSD +Summary: Compatibility version of the %{appname} library +URL: https://github.com/fmtlib/%{appname} +Source0: %{url}/archive/%{version}.tar.gz # fix for https://github.com/fmtlib/fmt/issues/2717 -Patch100: %{name}-fix_implicit_ptr_conv.patch +Patch100: %{name}-fix_implicit_ptr_conv.patch -BuildRequires: cmake -BuildRequires: gcc -BuildRequires: gcc-c++ -BuildRequires: ninja-build - -# This package replaces the old name of cppformat -Provides: cppformat = %{?epoch:%{epoch}:}%{version}-%{release} -Obsoletes: cppformat < %{?epoch:%{epoch}:}%{version}-%{release} +BuildRequires: cmake +BuildRequires: gcc +BuildRequires: gcc-c++ +BuildRequires: ninja-build %description C++ Format is an open-source formatting library for C++. It can be used as a safe alternative to printf or as a fast alternative to IOStreams. -%package devel -Summary: Development files for %{name} -Requires: %{name}%{?_isa} = %{?epoch:%{epoch}:}%{version}-%{release} - -# This package replaces the old name of cppformat -Provides: cppformat-devel = %{?epoch:%{epoch}:}%{version}-%{release} -Obsoletes: cppformat-devel < %{?epoch:%{epoch}:}%{version}-%{release} +Warning! This is a limited-time compatibility version of %{appname}. + +%package devel +Summary: Development files for %{name} +Requires: %{name}%{?_isa} = %{?epoch:%{epoch}:}%{version}-%{release} +Conflicts: %{appname}-devel%{?_isa} -%description devel +%description devel This package contains the header file for using %{name}. +Warning! This is a limited-time compatibility version of %{appname}. + %prep -%autosetup -p1 +%autosetup -n %{appname}-%{version} -p1 %build %cmake -G Ninja \ -DCMAKE_BUILD_TYPE=RelWithDebInfo \ -DCMAKE_POSITION_INDEPENDENT_CODE:BOOL=ON \ - -DFMT_CMAKE_DIR:STRING=%{_libdir}/cmake/%{name} \ + -DFMT_CMAKE_DIR:STRING=%{_libdir}/cmake/%{appname} \ -DFMT_LIB_DIR:STRING=%{_libdir} %cmake_build @@ -54,12 +53,12 @@ %files %license LICENSE.rst %doc ChangeLog.rst README.rst -%{_libdir}/lib%{name}.so.8* +%{_libdir}/lib%{appname}.so.8* %files devel -%{_includedir}/%{name} -%{_libdir}/lib%{name}.so -%{_libdir}/cmake/%{name} -%{_libdir}/pkgconfig/%{name}.pc +%{_includedir}/%{appname} +%{_libdir}/lib%{appname}.so +%{_libdir}/cmake/%{appname} +%{_libdir}/pkgconfig/%{appname}.pc %changelog
The diff looks reasonable.
I removed the justification so the diff looks huge.
With --ignore-space-change: --- /dev/fd/63 2022-07-19 14:03:05.106928629 +0200 +++ /dev/fd/62 2022-07-19 14:03:05.106928629 +0200 @@ -1,10 +1,12 @@ -Name: fmt +%global appname fmt + +Name: fmt8 Version: 8.1.1 -Release: 5%{?dist} +Release: 6%{?dist} License: BSD -Summary: Small, safe and fast formatting library for C++ -URL: https://github.com/fmtlib/%{name} +Summary: Compatibility version of the %{appname} library +URL: https://github.com/fmtlib/%{appname} Source0: %{url}/archive/%{version}.tar.gz # fix for https://github.com/fmtlib/fmt/issues/2717 @@ -15,33 +17,30 @@ BuildRequires: gcc-c++ BuildRequires: ninja-build -# This package replaces the old name of cppformat -Provides: cppformat = %{?epoch:%{epoch}:}%{version}-%{release} -Obsoletes: cppformat < %{?epoch:%{epoch}:}%{version}-%{release} - %description C++ Format is an open-source formatting library for C++. It can be used as a safe alternative to printf or as a fast alternative to IOStreams. +Warning! This is a limited-time compatibility version of %{appname}. + %package devel Summary: Development files for %{name} Requires: %{name}%{?_isa} = %{?epoch:%{epoch}:}%{version}-%{release} - -# This package replaces the old name of cppformat -Provides: cppformat-devel = %{?epoch:%{epoch}:}%{version}-%{release} -Obsoletes: cppformat-devel < %{?epoch:%{epoch}:}%{version}-%{release} +Conflicts: %{appname}-devel%{?_isa} %description devel This package contains the header file for using %{name}. +Warning! This is a limited-time compatibility version of %{appname}. + %prep -%autosetup -p1 +%autosetup -n %{appname}-%{version} -p1 %build %cmake -G Ninja \ -DCMAKE_BUILD_TYPE=RelWithDebInfo \ -DCMAKE_POSITION_INDEPENDENT_CODE:BOOL=ON \ - -DFMT_CMAKE_DIR:STRING=%{_libdir}/cmake/%{name} \ + -DFMT_CMAKE_DIR:STRING=%{_libdir}/cmake/%{appname} \ -DFMT_LIB_DIR:STRING=%{_libdir} %cmake_build @@ -54,12 +53,12 @@ %files %license LICENSE.rst %doc ChangeLog.rst README.rst -%{_libdir}/lib%{name}.so.8* +%{_libdir}/lib%{appname}.so.8* %files devel -%{_includedir}/%{name} -%{_libdir}/lib%{name}.so -%{_libdir}/cmake/%{name} -%{_libdir}/pkgconfig/%{name}.pc +%{_includedir}/%{appname} +%{_libdir}/lib%{appname}.so +%{_libdir}/cmake/%{appname} +%{_libdir}/pkgconfig/%{appname}.pc %changelog
Approved. Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [x] = Manual review needed ===== MUST items ===== C/C++: [x]: Package does not contain kernel modules. [x]: Package contains no static executables. [x]: If your application is a C or C++ application you must list a BuildRequires against gcc, gcc-c++ or clang. [x]: Header files in -devel subpackage, if present. [x]: ldconfig not called in %post and %postun for Fedora 28 and later. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. [x]: Development (unversioned) .so files in -devel subpackage, if present. Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "MIT License", "*No copyright* MIT License CNRI Python License", "CNRI Python Open Source GPL Compatible License Agreement", "BSD 3-Clause License". 197 files have unknown license. Detailed output of licensecheck in /home/vascom/2108585-fmt8/licensecheck.txt [x]: License file installed when any subpackage combination is installed. [x]: Package does not own files or directories owned by other packages. Note: Dirs in package are owned also by: /usr/include/fmt(fmt-devel), /usr/lib64/cmake/fmt(fmt-devel) [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [x]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [x]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 215040 bytes in 2 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [x]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [x]: Patches link to upstream bugs/comments/lists or are otherwise justified. [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [x]: Package should compile and build into binary rpms on all supported architectures. [x]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Fully versioned dependency in subpackages if applicable. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: The placement of pkgconfig(.pc) files are correct. [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on debuginfo package(s). Note: There are rpmlint messages (see attachment). [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Cannot parse rpmlint output: Rpmlint (debuginfo) ------------------- Cannot parse rpmlint output: Rpmlint (installed packages) ---------------------------- Cannot parse rpmlint output: Source checksums ---------------- https://github.com/fmtlib/fmt/archive/8.1.1.tar.gz : CHECKSUM(SHA256) this package : 3d794d3cf67633b34b2771eb9f073bde87e846e0d395d254df7b211ef1ec7346 CHECKSUM(SHA256) upstream package : 3d794d3cf67633b34b2771eb9f073bde87e846e0d395d254df7b211ef1ec7346 Requires -------- fmt8 (rpmlib, GLIBC filtered): libc.so.6()(64bit) libgcc_s.so.1()(64bit) libgcc_s.so.1(GCC_3.0)(64bit) libgcc_s.so.1(GCC_3.3.1)(64bit) libstdc++.so.6()(64bit) libstdc++.so.6(CXXABI_1.3)(64bit) rtld(GNU_HASH) fmt8-devel (rpmlib, GLIBC filtered): /usr/bin/pkg-config cmake-filesystem(x86-64) fmt8(x86-64) libfmt.so.8()(64bit) fmt8-debuginfo (rpmlib, GLIBC filtered): fmt8-debugsource (rpmlib, GLIBC filtered): Provides -------- fmt8: fmt8 fmt8(x86-64) libfmt.so.8()(64bit) fmt8-devel: cmake(fmt) fmt8-devel fmt8-devel(x86-64) pkgconfig(fmt) fmt8-debuginfo: debuginfo(build-id) fmt8-debuginfo fmt8-debuginfo(x86-64) libfmt.so.8.1.1-8.1.1-6.fc37.x86_64.debug()(64bit) fmt8-debugsource: fmt8-debugsource fmt8-debugsource(x86-64) Generated by fedora-review 0.8.0 (e988316) last change: 2022-04-07 Command line :/usr/bin/fedora-review -b 2108585 Buildroot used: fedora-rawhide-x86_64 Active plugins: C/C++, Generic, Shell-api Disabled plugins: Perl, PHP, Ocaml, Python, fonts, SugarActivity, Java, Haskell, R Disabled flags: EPEL6, EPEL7, DISTTAG, BATCH, EXARCH
I've also verified the "main" package is co-installable.
Completed: fmt8-8.1.1-6.fc37. Rawhide compose should be fixed now.