Created attachment 1898159 [details] Make the pkgconfig generation script remove instruction set options before pasting them into CFLAGS. The file /usr/libXX/pkgconfig/absl_random_internal_randen_hwaes_impl.pc shipped in abseil-cpp-devel incorrectly specifies -maes -msse4.1 in its CFLAGS, causing any packages which use pkgconfig to compile against abseil to require SSE4.1 instructions to run. The issue occurs in Fedora 35, 36 and Rawhide. A patch is attached (present on upstream master and verified to already work on openSUSE)
Thanks for reporting this, and for submitting it upstream. I will work on getting this backported to Rawhide, F36, F35, and EPEL9. EPEL8 appears to be unaffected since the version there does not install .pc files. ----- To the best of my understanding—according to [1], and without digging into the code myself, the library uses runtime dispatch to select implementation with these instructions on hardware that supports them. If anyone knows of a case where instructions beyond the architectural baseline are used without runtime detection and dispatch in abseil-cpp itself, please report that as an additional bug. ----- I ran the command > mock -r fedora-rawhide-x86_64 --enablerepo='*source*' --dnf-cmd -- repoquery --whatrequires '*absl_random_internal_randen_hwaes_impl*' to see if any Fedora packages used the library in question, and if they were affected by the wayward compiler flags. I found that: - grpc uses it in Rawhide and in EPEL9, but (for some reason) does not appear to pick up the inappropriate compiler flags. (However, grpc in EPEL9 appears to be broken due to a libre2 soname bump, so it needs to be rebuilt anyway.) - frr uses it in Rawhide only, and definitely picks up the inappropriate compiler flags So frr will need to be rebuilt in Rawhide as part of the resolution for this bug. [1] https://github.com/abseil/abseil-cpp/issues/643#issuecomment-602643378
PR’s are open; waiting for the CI to complete. Rawhide: https://src.fedoraproject.org/rpms/abseil-cpp/pull-request/4 F36: https://src.fedoraproject.org/rpms/abseil-cpp/pull-request/5 F35: https://src.fedoraproject.org/rpms/abseil-cpp/pull-request/6 EPEL9: https://src.fedoraproject.org/rpms/abseil-cpp/pull-request/7
FEDORA-2022-b909a57118 has been submitted as an update to Fedora 37. https://bodhi.fedoraproject.org/updates/FEDORA-2022-b909a57118
FEDORA-2022-b909a57118 has been pushed to the Fedora 37 stable repository. If problem still persists, please make note of it in this bug report.
PR to rebuild frr in Rawhide: https://src.fedoraproject.org/rpms/frr/pull-request/10
FEDORA-2022-755db2684e has been submitted as an update to Fedora 36. https://bodhi.fedoraproject.org/updates/FEDORA-2022-755db2684e
FEDORA-2022-44cc36a3e7 has been submitted as an update to Fedora 35. https://bodhi.fedoraproject.org/updates/FEDORA-2022-44cc36a3e7
FEDORA-2022-755db2684e has been pushed to the Fedora 36 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf upgrade --enablerepo=updates-testing --refresh --advisory=FEDORA-2022-755db2684e` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2022-755db2684e See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
FEDORA-2022-44cc36a3e7 has been pushed to the Fedora 35 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf upgrade --enablerepo=updates-testing --refresh --advisory=FEDORA-2022-44cc36a3e7` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2022-44cc36a3e7 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
FEDORA-EPEL-2022-385236becf has been submitted as an update to Fedora EPEL 9. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2022-385236becf
FEDORA-EPEL-2022-385236becf has been pushed to the Fedora EPEL 9 testing repository. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2022-385236becf See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
FEDORA-2022-27f1b1aadb has been submitted as an update to Fedora 37. https://bodhi.fedoraproject.org/updates/FEDORA-2022-27f1b1aadb
Hi Ben, thanks for the PR, frr is now rebuilt with the new abseil-cpp-devel: https://koji.fedoraproject.org/koji/taskinfo?taskID=90335744 Regards, Michal
FEDORA-2022-27f1b1aadb has been pushed to the Fedora 37 stable repository. If problem still persists, please make note of it in this bug report.
FEDORA-2022-755db2684e has been pushed to the Fedora 36 stable repository. If problem still persists, please make note of it in this bug report.
FEDORA-EPEL-2022-385236becf has been pushed to the Fedora EPEL 9 stable repository. If problem still persists, please make note of it in this bug report.
FEDORA-2022-44cc36a3e7 has been pushed to the Fedora 35 stable repository. If problem still persists, please make note of it in this bug report.