Bug 2108677 - Please consider switching to active upstream
Summary: Please consider switching to active upstream
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: Fedora
Classification: Fedora
Component: gtk-sharp3
Version: 37
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Timotheus Pokorra
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: 2116282
TreeView+ depends on / blocked
 
Reported: 2022-07-19 16:49 UTC by Julian Sikorski
Modified: 2022-12-20 05:21 UTC (History)
3 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2022-12-20 05:21:50 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)
WIP patch (5.35 KB, patch)
2022-08-07 10:31 UTC, Julian Sikorski
no flags Details | Diff

Description Julian Sikorski 2022-07-19 16:49:46 UTC
Description of problem:
In order to update gnome-subtitles to 1.8, newer gtk-sharp is needed. https://github.com/GLibSharp/GtkSharp is mentioned, but gstreamer-sharp requires at least 3.22.6 which might be satisfied by https://github.com/GtkSharp/GtkSharp.

Comment 1 Timotheus Pokorra 2022-07-19 19:37:18 UTC
https://github.com/GtkSharp/GtkSharp seems to be built with dotnet.
That is quite a big change.

How many other packages depend on gtk-sharp3, besides gnome-subtitles?
We would need to test if those don't break if we upgrade gtksharp-3 in such a big way.

It seems all libraries are included, see https://github.com/GtkSharp/GtkSharp/tree/develop/Source/Libs. 
That is good, because with other solutions built with dotnet, you are required to download some nuget packages during the build time. It seems we don't have this problem in this case.

Comment 2 Julian Sikorski 2022-07-20 07:59:58 UTC
The dependencies list does not seem too long:

$ sudo dnf repoquery --whatrequires gtk-sharp3 -s
Letzte Prüfung auf abgelaufene Metadaten: vor 0:01:30 am Mi 20 Jul 2022 09:51:05 CEST.
gbrainy-2.4.4-1.fc36.src.rpm
gnome-subtitles-1.7.2-2.fc36.src.rpm
gtk-sharp3-2.99.3-33.fc36.src.rpm
notify-sharp3-3.0.3-16.fc36.src.rpm
soup-sharp-2.42.2-6.20190810git0f36d10.fc36.src.rpm
sparkleshare-3.28-7.fc36.src.rpm
webkit2-sharp-0-0.15.20170219gita59fd76.fc36.src.rpm

I will try to check locally whether it matters which of the two forks we pick. Hopefully one is sufficient. gnome-subtitles points to the GlibSharp one, but it also requires gstreamer-sharp, which in turn requires gtk-sharp>=3.22.6. GlibSharp fork only goes up to 3.22.2:
https://github.com/GLibSharp/GtkSharp/releases
The version in git has been downgraded to 3.22:
https://github.com/GLibSharp/GtkSharp/commit/19c566b1e835a2fdfadd85c8cbffbb1ea84be615
This seems very messy :(

Comment 3 Julian Sikorski 2022-08-07 10:31:31 UTC
Created attachment 1904112 [details]
WIP patch

It turns out the Glibsharp fork was at 3.22.6 at some point but got downgraded to 3.22.2 at some point. So, at least in theory, it should be sufficient. I made some progress updating the gtk-sharp3.spec but I have now reached a point where the assemblies get installed to /usr/lib64 instead of /usr/lib. Other than that, the changes are quite minimal. I have filed a bug about this upstream [1], but if you are familiar with meson and know how to fix it, let me know.

[1] https://github.com/GLibSharp/GtkSharp/issues/72

Comment 4 Timotheus Pokorra 2022-08-08 05:30:33 UTC
Thanks Julian for the patch!
Somehow in my previous comment, I only looked at the GtkSharp/GtkSharp repo, but missed the GlibSharp Repo that you had mentioned.
I have committed your changes, and added the --libdir parameter that was mentioned in the Github issue.
Latest version is now at https://src.fedoraproject.org/rpms/gtk-sharp3/blob/rawhide/f/gtk-sharp3.spec
I have built the package for Rawhide: https://koji.fedoraproject.org/koji/taskinfo?taskID=90600273
Let's see if we get any issues on koji for other packages, and you can check if that works now already for gstreamer-sharp.

Comment 5 Ben Cotton 2022-08-09 13:40:07 UTC
This bug appears to have been reported against 'rawhide' during the Fedora Linux 37 development cycle.
Changing version to 37.

Comment 7 Julian Sikorski 2022-08-12 20:12:20 UTC
I cannot get gstreamer-sharp to use the system gtk-sharp, it wants to use wrap no matter what. I opened a bug about this with gstreamer:
https://gitlab.freedesktop.org/gstreamer/gstreamer/-/issues/1375

Comment 8 Filipe Rosset 2022-08-23 04:34:15 UTC
due this upgrade, gbrainy is broken, reported the regression upstream -> https://github.com/GLibSharp/GtkSharp/issues/74

Comment 9 Filipe Rosset 2022-08-29 21:29:26 UTC
(In reply to Filipe Rosset from comment #8)
> due this upgrade, gbrainy is broken, reported the regression upstream ->
> https://github.com/GLibSharp/GtkSharp/issues/74

I worked with gbrainy upstream, it's fixed by now

Comment 10 Filipe Rosset 2022-09-02 12:39:55 UTC
Hi guys, can you please apply this Patch for gtk-sharp?

Thanks.

https://github.com/GLibSharp/GtkSharp/commit/8cce7f0d19e6378f652aa75dcaac348a869f6ece

Comment 11 Filipe Rosset 2022-09-03 19:52:33 UTC
Let me know if you can apply this Patch, I need this one go fix a runtime issue with gbrainy.
Thanks.

Comment 12 Julian Sikorski 2022-09-03 20:17:49 UTC
I don't have commit access, sorry.

Comment 13 Timotheus Pokorra 2022-09-06 05:18:34 UTC
Thank you for the patch!
I have added it to F37 and to Rawhide.

Comment 14 Filipe Rosset 2022-09-06 14:52:55 UTC
(In reply to Timotheus Pokorra from comment #13)
> Thank you for the patch!
> I have added it to F37 and to Rawhide.

thanks, now gbrainy is working fine, I'll upgrade to latest release soon

Comment 15 Fedora Update System 2022-09-07 18:37:19 UTC
FEDORA-2022-241a4e0cd9 has been submitted as an update to Fedora 37. https://bodhi.fedoraproject.org/updates/FEDORA-2022-241a4e0cd9

Comment 16 Fedora Update System 2022-09-08 09:33:06 UTC
FEDORA-2022-241a4e0cd9 has been pushed to the Fedora 37 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf upgrade --enablerepo=updates-testing --refresh --advisory=FEDORA-2022-241a4e0cd9`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2022-241a4e0cd9

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 17 Fedora Update System 2022-09-16 00:16:12 UTC
FEDORA-2022-241a4e0cd9 has been pushed to the Fedora 37 stable repository.
If problem still persists, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.