Bug 2109290 (golang-github-googleapis-type-adapters) - Review Request: golang-github-googleapis-type-adapters - Type adapters for common Go protobuf messages
Summary: Review Request: golang-github-googleapis-type-adapters - Type adapters for co...
Keywords:
Status: CLOSED ERRATA
Alias: golang-github-googleapis-type-adapters
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Maxwell G
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2022-07-20 21:28 UTC by Robert-André Mauchin 🐧
Modified: 2022-08-09 01:30 UTC (History)
2 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2022-07-31 08:00:41 UTC
Type: ---
Embargoed:
maxwell: fedora-review+


Attachments (Terms of Use)

Description Robert-André Mauchin 🐧 2022-07-20 21:28:23 UTC
Spec URL: https://eclipseo.fedorapeople.org/for-review/golang-github-googleapis-type-adapters.spec
SRPM URL: https://eclipseo.fedorapeople.org/for-review/golang-github-googleapis-type-adapters-1.0.0-1.20220720gitaf57806.fc36.src.rpm

Description:
 Type adapters for common Go protobuf messages.

Fedora Account System Username: eclipseo

Comment 1 Robert-André Mauchin 🐧 2022-07-20 21:39:59 UTC
Koji scratch build: https://koji.fedoraproject.org/koji/taskinfo?taskID=89755996

Comment 2 Maxwell G 2022-07-22 18:56:15 UTC
> # Upstream license specification: Apache-2.0

I'd remove this redundant comment.

> Version:                1.0.0
> %global commit          af57806e8585cc8193e513b7852348e23c44de1e

What's the point of packaging a git snapshot. Is that needed for golang-google-cloud-google?

Comment 3 Robert-André Mauchin 🐧 2022-07-23 13:19:25 UTC
(In reply to Maxwell G from comment #2)
> > # Upstream license specification: Apache-2.0
> 
> I'd remove this redundant comment.
> 
OK

> > Version:                1.0.0
> > %global commit          af57806e8585cc8193e513b7852348e23c44de1e
> 
> What's the point of packaging a git snapshot. Is that needed for
> golang-google-cloud-google?


go2rpm automatically chooses a git snapshot if a certain time or certain amounts of commit have passed since last release.

Comment 5 Robert-André Mauchin 🐧 2022-07-23 13:21:59 UTC
Koji scratch build:

Comment 6 Maxwell G 2022-07-24 02:26:49 UTC
I am not going to go through the whole fedora-review template, as this package uses go2rpm.

- [x] The specfile is sane.
- [x] License is correct
- [x] Builds successfully in mock
- [x] Package is installable (checked by fedora-review)
- [x] No relevant rpmlint errors[1]
- [x] %check section passes
- [x] The latest release is packaged
- [x] `%goipath` is set correctly
- [-] Binaries don't conflict with binaries already in the distribution
- [x] The package complies with the Packaging Guidelines.

Package approved! On import, don't forget to do the following:

- [ ] Add package to release-monitoring.org
- [ ] Add package to Koschei.
- [ ] Give go-sig privileges on package
- [ ] Close the review bug by referencing it in the rpm changelog and the Bodhi ticket.

Thanks!

[1]:
golang-github-googleapis-type-adapters.spec: W: no-%build-section
There's nothing to build

golang-github-googleapis-type-adapters.src: W: invalid-license Apache-2.0
golang-github-googleapis-type-adapters-devel.noarch: W: invalid-license Apache-2.0
rpmlint hasn't been updated to accept SPDX identifer

golang-github-googleapis-type-adapters-devel.noarch: W: hidden-file-or-dir /usr/share/gocode/src/github.com/googleapis/go-type-adapters/.goipath
Created by the go macros

golang-github-googleapis-type-adapters-devel.noarch: W: files-duplicate /usr/share/gocode/src/github.com/googleapis/go-type-adapters/CHANGELOG.md /usr/share/doc/golang-github-googleapis-type-adapters-devel/CHANGELOG.md
golang-github-googleapis-type-adapters-devel.noarch: W: files-duplicate /usr/share/gocode/src/github.com/googleapis/go-type-adapters/CODE_OF_CONDUCT.md /usr/share/doc/golang-github-googleapis-type-adapters-devel/CODE_OF_CONDUCT.md
golang-github-googleapis-type-adapters-devel.noarch: W: files-duplicate /usr/share/gocode/src/github.com/googleapis/go-type-adapters/CONTRIBUTING.md /usr/share/doc/golang-github-googleapis-type-adapters-devel/CONTRIBUTING.md
golang-github-googleapis-type-adapters-devel.noarch: W: files-duplicate /usr/share/gocode/src/github.com/googleapis/go-type-adapters/README.md /usr/share/doc/golang-github-googleapis-type-adapters-devel/README.md

This is something we should fix in golist. We don't want these files to be duplicated. This[2] is the relevant code.

[1]: https://pagure.io/golist/blob/master/f/cmd/golist/golist.go#_81

Comment 7 Kevin Fenzi 2022-07-31 00:42:50 UTC
(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/golang-github-googleapis-type-adapters

Comment 8 Fedora Update System 2022-07-31 08:00:22 UTC
FEDORA-2022-9e56197f64 has been submitted as an update to Fedora 37. https://bodhi.fedoraproject.org/updates/FEDORA-2022-9e56197f64

Comment 9 Fedora Update System 2022-07-31 08:00:41 UTC
FEDORA-2022-9e56197f64 has been pushed to the Fedora 37 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 10 Fedora Update System 2022-07-31 08:14:21 UTC
FEDORA-2022-65ece54948 has been submitted as an update to Fedora 36. https://bodhi.fedoraproject.org/updates/FEDORA-2022-65ece54948

Comment 11 Fedora Update System 2022-07-31 08:22:19 UTC
FEDORA-2022-716c21052c has been submitted as an update to Fedora 35. https://bodhi.fedoraproject.org/updates/FEDORA-2022-716c21052c

Comment 12 Fedora Update System 2022-08-01 00:33:10 UTC
FEDORA-2022-716c21052c has been pushed to the Fedora 35 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2022-716c21052c \*`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2022-716c21052c

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 13 Fedora Update System 2022-08-01 01:09:21 UTC
FEDORA-2022-65ece54948 has been pushed to the Fedora 36 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2022-65ece54948 \*`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2022-65ece54948

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 14 Fedora Update System 2022-08-09 01:24:05 UTC
FEDORA-2022-65ece54948 has been pushed to the Fedora 36 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 15 Fedora Update System 2022-08-09 01:30:08 UTC
FEDORA-2022-716c21052c has been pushed to the Fedora 35 stable repository.
If problem still persists, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.