Bug 2109831 - Review Request: golang-github-okta-sdk-2 - Okta SDK for Go [NEEDINFO]
Summary: Review Request: golang-github-okta-sdk-2 - Okta SDK for Go
Keywords:
Status: POST
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Robert-André Mauchin 🐧
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On: 2109619
Blocks:
TreeView+ depends on / blocked
 
Reported: 2022-07-22 09:32 UTC by Mark E. Fuller
Modified: 2023-07-30 19:02 UTC (History)
2 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed:
Type: ---
Embargoed:
zebob.m: fedora-review+
package-review: needinfo? (mark.e.fuller)
zebob.m: needinfo? (mark.e.fuller)


Attachments (Terms of Use)

Description Mark E. Fuller 2022-07-22 09:32:35 UTC
Spec URL: https://fuller.fedorapeople.org/golang-github-okta-sdk-2.spec
SRPM URL: https://fuller.fedorapeople.org/golang-github-okta-sdk-2-2.13.0-1.fc37.src.rpm
Description: Okta SDK for Go
Fedora Account System Username: fuller

Comment 1 Package Review 2023-07-23 00:45:32 UTC
This is an automatic check from review-stats script.

This review request ticket hasn't been updated for some time. We're sorry
it is taking so long. If you're still interested in packaging this software
into Fedora repositories, please respond to this comment clearing the
NEEDINFO flag.

You may want to update the specfile and the src.rpm to the latest version
available and to propose a review swap on Fedora devel mailing list to increase
chances to have your package reviewed. If this is your first package and you
need a sponsor, you may want to post some informal reviews. Read more at
https://fedoraproject.org/wiki/How_to_get_sponsored_into_the_packager_group.

Without any reply, this request will shortly be considered abandoned
and will be closed.
Thank you for your patience.

Comment 2 Robert-André Mauchin 🐧 2023-07-30 19:00:55 UTC
 - update to 2.20.0

 - use SPDX for the license field

 - update the spec with latest go2rpm:


# Generated by go2rpm 1.9.0
%bcond_without check
%global debug_package %{nil}

# https://github.com/segmentio/encoding
%global goipath         github.com/segmentio/encoding
Version:                0.3.6

%gometa -f

%global common_description %{expand:
Go package containing implementations of efficient encoding, decoding, and
validation APIs.}

%global golicenses      LICENSE json/fuzz/LICENSE
%global godocs          README.md

Name:           %{goname}
Release:        %autorelease
Summary:        Implementations of efficient encoding, decoding, and validation APIs

License:        Apache-2.0 AND MIT
URL:            %{gourl}
Source:         %{gosource}

%description %{common_description}

%gopkg

%prep
%goprep
%autopatch -p1

%generate_buildrequires
%go_generate_buildrequires

%install
%gopkginstall

%if %{with check}
%check
%ifarch s390x
for test in "TestUnmarshalMarshal" \
            "TestCompactBig" \
            "TestAppendEscape" \
            "TestIndentBig" \
; do
awk -i inplace '/^func.*'"$test"'\(/ { print; print "\tt.Skip(\"disabled failing test\")"; next}1' $(grep -rl $test)
done
%endif
%gocheck
%endif

%gopkgfiles

%changelog
%autochangelog





 - License ok
 - Builds in mock
 - Checks pass
 - No rpmlint errors
 - Conforms to Go Packaging Guidelines


Package approved. Update the version number and regenerate the SPEc with latest go2rpm.


Please :
 - add it to Koschei
 - add it to release-monitoring.org
 - add commit rights to the go-sig group

Comment 3 Robert-André Mauchin 🐧 2023-07-30 19:02:36 UTC
Pasted the wrong spec :

# Generated by go2rpm 1.9.0
%bcond_without check
%global debug_package %{nil}

# https://github.com/okta/okta-sdk-golang
%global goipath         github.com/okta/okta-sdk-golang/v2
%global forgeurl        https://github.com/okta/okta-sdk-golang
Version:                2.20.0

%gometa -f

%global common_description %{expand:
Okta Golang management SDK.}

%global golicenses      LICENSE.md NOTICE.md
%global godocs          CONTRIBUTING.md CHANGELOG.md README.md

Name:           %{goname}
Release:        %autorelease
Summary:        Okta Golang management SDK

License:        Apache-2.0
URL:            %{gourl}
Source:         %{gosource}

%description %{common_description}

%gopkg

%prep
%goprep
%autopatch -p1

%generate_buildrequires
%go_generate_buildrequires

%install
%gopkginstall

%if %{with check}
%check
%gocheck
%endif

%gopkgfiles

%changelog
%autochangelog


Note You need to log in before you can comment on or make changes to this bug.