Spec URL: https://fuller.fedorapeople.org/golang-github-huaweicloud-golangsdk.spec SRPM URL: https://fuller.fedorapeople.org/golang-github-huaweicloud-golangsdk-0-0.1.20220721gitd823fe1.fc37.src.rpm Description: Huawei Golang SDK Fedora Account System Username: fuller
This is an automatic check from review-stats script. This review request ticket hasn't been updated for some time. We're sorry it is taking so long. If you're still interested in packaging this software into Fedora repositories, please respond to this comment clearing the NEEDINFO flag. You may want to update the specfile and the src.rpm to the latest version available and to propose a review swap on Fedora devel mailing list to increase chances to have your package reviewed. If this is your first package and you need a sponsor, you may want to post some informal reviews. Read more at https://fedoraproject.org/wiki/How_to_get_sponsored_into_the_packager_group. Without any reply, this request will shortly be considered abandoned and will be closed. Thank you for your patience.
- update to SPDX licensing - don't need this if you're removing the binary %files %license LICENSE %doc CHANGELOG.md FAQ.md MIGRATING.md README.md STYLEGUIDE.md - You should run the test. Some tests are failing, probably network issues : github.com/huaweicloud/golangsdk/acceptance/openstack/networking/v2/peering --- FAIL: TestPeeringList (0.00s) peerings_test.go:14: Unable to create a vpc client: Missing input for argument [authURL] --- FAIL: TestAcceptPeering (0.00s) peerings.go:93: Unable to create a network v2 client: Missing input for argument [authURL] --- FAIL: TestRejectPeering (0.00s) peerings.go:93: Unable to create a network v2 client: Missing input for argument [authURL] --- FAIL: TestPeeringCRUD (0.00s) peerings.go:93: Unable to create a network v2 client: Missing input for argument [authURL] FAIL exit status 1 FAIL github.com/huaweicloud/golangsdk/acceptance/openstack/networking/v2/peering 0.003s - update the SPEC with the latest go2rpm: # Generated by go2rpm 1.9.0 %bcond_without check %global debug_package %{nil} # https://github.com/huaweicloud/golangsdk %global goipath github.com/huaweicloud/golangsdk %global commit d823fe11ceba2353b043a2a5039dc2e4d90f1fc3 %gometa -f %global common_description %{expand: Golangsdk: this is a sdk only using by Huawei inner projects. please refer to https://github.com/huaweicloud/huaweicloud-sdk-go.} %global golicenses LICENSE %global godocs CHANGELOG.md FAQ.md MIGRATING.md README.md\\\ STYLEGUIDE.md Name: %{goname} Version: 0 Release: %autorelease -p Summary: Huawei Golang SDK License: Apache-2.0 URL: %{gourl} Source: %{gosource} %description %{common_description} %gopkg %prep %goprep %autopatch -p1 %generate_buildrequires %go_generate_buildrequires %install %gopkginstall %if %{with check} %check for test in "TestPeeringList" \ "TestAcceptPeering" \ "TestRejectPeering" \ "TestPeeringCRUD" \ "TestRouteList" \ "TestRoutesCRUD" \ ; do awk -i inplace '/^func.*'"$test"'\(/ { print; print "\tt.Skip(\"disabled failing test\")"; next}1' $(grep -rl $test) done %gocheck %endif %gopkgfiles %changelog %autochangelog - License ok - Latest version packaged - Builds in mock - Checks pass, after tweak - No rpmlint errors - Conforms to Go Packaging Guidelines Please update the SPEC and needinfo me for me to approve it.