Bug 2109939 - Review Request: mitmproxy - Interactive SSL-capable intercepting HTTP proxy
Summary: Review Request: mitmproxy - Interactive SSL-capable intercepting HTTP proxy
Keywords:
Status: NEW
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Nobody's working on this, feel free to take it
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On: 2048162
Blocks:
TreeView+ depends on / blocked
 
Reported: 2022-07-22 13:55 UTC by Dominik 'Rathann' Mierzejewski
Modified: 2023-01-20 18:40 UTC (History)
3 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed:
Type: ---
Embargoed:


Attachments (Terms of Use)
root.log (200.59 KB, text/plain)
2023-01-18 18:58 UTC, Petr Menšík
no flags Details
build.log (25.45 KB, text/plain)
2023-01-18 18:58 UTC, Petr Menšík
no flags Details

Description Dominik 'Rathann' Mierzejewski 2022-07-22 13:55:25 UTC
Spec URL: https://rathann.fedorapeople.org/review/mitmproxy/mitmproxy.spec
SRPM URL: https://rathann.fedorapeople.org/review/mitmproxy/mitmproxy-8.1.1-1.fc36.src.rpm
Description:
mitmproxy is an interactive, SSL-capable man-in-the-middle proxy for HTTP with
a console interface.

mitmdump is the command-line version of mitmproxy. Think tcpdump for HTTP.

libmproxy is the library that mitmproxy and mitmdump are built on.

Fedora Account System Username: rathann

Previous attempt by Fabian Affolter: bug 1198760.

Comment 1 Petr Menšík 2023-01-18 18:56:57 UTC
The current spec failed to build to me when trying fedora-review -b 2109939. I admit I have trouble finding what exactly is reponsible for the failure.

I think the package should Provides: python3-%{name}, as recommended by python guidelines.

I think the main issue reported in root.log:

DEBUG util.py:443:  Error: 
DEBUG util.py:443:   Problem 1: nothing provides requested (python3dist(blinker) < 1.5~~ with python3dist(blinker) >= 1.4)
DEBUG util.py:443:   Problem 2: nothing provides requested (python3dist(flask) < 2.2~~ with python3dist(flask) >= 1.1.1)
DEBUG util.py:443:   Problem 3: nothing provides requested (python3dist(wsproto) < 1.2~~ with python3dist(wsproto) >= 1)
DEBUG util.py:443:   Problem 4: nothing provides requested (python3dist(zstandard) < 0.19~~ with python3dist(zstandard) >= 0.11)
DEBUG util.py:445:  (try to add '--skip-broken' to skip uninstallable packages or '--nobest' to use not only best candidate packages)
DEBUG util.py:596:  Child return code was: 1

Please fix dependencies to build on current rawhide. It seems adjustment to newer versions is required.

python3-blinker-0:1.5-1.fc37.noarch
python3-flask-1:2.2.2-1.fc37.noarch
python3-wsproto-0:1.2.0-1.fc38.noarch
python3-zstandard-0:0.19.0-1.fc38.x86_64

Comment 2 Petr Menšík 2023-01-18 18:58:07 UTC
Created attachment 1939023 [details]
root.log

Comment 3 Petr Menšík 2023-01-18 18:58:38 UTC
Created attachment 1939024 [details]
build.log

Comment 4 Dominik 'Rathann' Mierzejewski 2023-01-20 18:28:17 UTC
Spec URL: https://rathann.fedorapeople.org/review/mitmproxy/mitmproxy.spec
SRPM URL: https://rathann.fedorapeople.org/review/mitmproxy/mitmproxy-8.1.1-2.fc37.src.rpm

* Fri Jan 20 2023 Dominik Mierzejewski <dominik> - 8.1.1-2
- relax deps versions requirements to fix build on rawhide
- fix tests

NOTE: I can't update to 9.0.x because some dependencies are too old in Fedora rawhide, in particular pyOpenSSL 22.1 is required.

Comment 5 Fabio Valentini 2023-01-20 18:35:51 UTC
If you need help with packaging mitmproxy_wireguard (a new dependency of mitmproxy 9), let me know. I'm the upstream developer. :)

Comment 6 Jakub Kadlčík 2023-01-20 18:40:38 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/5278069
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2109939-mitmproxy/fedora-rawhide-x86_64/05278069-mitmproxy/fedora-review/review.txt

Please take a look if any issues were found.

---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service


Note You need to log in before you can comment on or make changes to this bug.