Spec URL: https://eclipseo.fedorapeople.org/for-review/golang-x-vuln.spec SRPM URL: https://eclipseo.fedorapeople.org/for-review/golang-x-vuln-0-0.1.20220723git3484609.fc36.src.rpm Description: The database client and tools for the Go vulnerability database. Fedora Account System Username: eclipseo
Koji scratch build: https://koji.fedoraproject.org/koji/taskinfo?taskID=89939421
> %{_bindir}/* Globs like this should not be used, according to the packaging guidelines. Please explicitly list the paths. You can use bash style parameter expansion (e.g. `%{_bindir}/{bin1,bin2,bin3}`) if you'd like. > # Upstream license specification: BSD-3-Clause > License: BSD You might want to switch this to use the SPDX identifier. You should also include PATENTS in %license or %doc. --- I am not going to go through the whole fedora-review template, as this package uses go2rpm. - [x] The specfile is sane. - [x] License is correct NOTE: The README says: > Database entries available at https://vuln.go.dev are distributed under the terms of the [CC-BY 4.0](https://creativecommons.org/licenses/by/4.0/) license. These files don't appear to be included in the package, however. - [x] Builds successfully in mock - [x] Package is installable (checked by fedora-review) - [x] No relevant rpmlint errors - [x] %check section passes - [x] The latest version is packaged - [x] `%goipath` is set correctly - [-] Binaries don't conflict with binaries already in the distribution - [!] The package complies with the Packaging Guidelines.
New Spec URL: https://eclipseo.fedorapeople.org/for-review/golang-x-vuln.spec New SRPM URL: https://eclipseo.fedorapeople.org/for-review/golang-x-vuln-0-0.1.20220723git3484609.fc36.src.rpm
Koji scratch build:
Koji scratch build: https://koji.fedoraproject.org/koji/taskinfo?taskID=90270140
LGTM. Note, there seems to be a blank line missing above `%install`, but otherwise approved. Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed ===== MUST items ===== Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: There is no build directory. Running licensecheck on vanilla upstream sources. Licenses found: "Unknown or generated", "BSD 3-Clause License", "*No copyright* Creative Commons Attribution 4.0". 93 files have unknown license. Detailed output of licensecheck in /home/elliott/rpmbuild/review/2110130-golang-x-vuln/licensecheck.txt [x]: License file installed when any subpackage combination is installed. [x]: Package does not own files or directories owned by other packages. Note: Dirs in package are owned also by: /usr/share/gocode/src/golang.org(golang-x-exp-devel, golang-x-crypto- devel, golang-x-perf-devel, golang-x-arch-devel, golang-x-xerrors- devel, golang-x-text-devel, golang-x-debug-devel, golang-x-time-devel, golang-x-mobile-devel, golang-x-lint-devel, golang-x-sys-devel, golang, golang-x-build-devel, golang-x-sync-devel, golang-x-net-devel, golang-x-tools-devel, golang-x-oauth2-devel, golang-x-mod-devel, golang-x-term-devel, golang-x-image-devel), /usr/share/gocode/src/golang.org/x(golang-x-exp-devel, golang-x- crypto-devel, golang-x-perf-devel, golang-x-arch-devel, golang-x- xerrors-devel, golang-x-text-devel, golang-x-debug-devel, golang-x- time-devel, golang-x-mobile-devel, golang-x-lint-devel, golang-x-sys- devel, golang, golang-x-build-devel, golang-x-sync-devel, golang-x- net-devel, golang-x-tools-devel, golang-x-oauth2-devel, golang-x-mod- devel, golang-x-term-devel, golang-x-image-devel) [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [x]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [?]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [-]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 20480 bytes in 6 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in golang- x-vuln-devel [?]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [x]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Package should compile and build into binary rpms on all supported architectures. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [!]: Spec file according to URL is the same as in SRPM. Note: Spec file as given by url is not the same as in SRPM (see attached diff). See: (this test has no URL) [x]: Rpmlint is run on debuginfo package(s). Note: There are rpmlint messages (see attachment). [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. Rpmlint ------- Cannot parse rpmlint output: Rpmlint (debuginfo) ------------------- Cannot parse rpmlint output: Rpmlint (installed packages) ---------------------------- Cannot parse rpmlint output: Source checksums ---------------- https://github.com/golang/vuln/archive/348460952d62720df9244d4e7b81008a9195e109/vuln-348460952d62720df9244d4e7b81008a9195e109.tar.gz : CHECKSUM(SHA256) this package : ea4a7b98efd0869025f56bb35ac2909590cdb31a3819012b273a9a8560bfddb1 CHECKSUM(SHA256) upstream package : ea4a7b98efd0869025f56bb35ac2909590cdb31a3819012b273a9a8560bfddb1 Requires -------- golang-x-vuln (rpmlib, GLIBC filtered): libc.so.6()(64bit) golang-x-vuln-devel (rpmlib, GLIBC filtered): go-filesystem golang(github.com/google/go-cmp/cmp) golang(golang.org/x/mod/semver) golang(golang.org/x/tools/go/buildutil) golang(golang.org/x/tools/go/callgraph) golang(golang.org/x/tools/go/callgraph/cha) golang(golang.org/x/tools/go/callgraph/vta) golang(golang.org/x/tools/go/packages) golang(golang.org/x/tools/go/ssa) golang(golang.org/x/tools/go/ssa/ssautil) golang(golang.org/x/tools/go/types/typeutil) golang-x-vuln-debuginfo (rpmlib, GLIBC filtered): golang-x-vuln-debugsource (rpmlib, GLIBC filtered): Provides -------- golang-x-vuln: golang-x-vuln golang-x-vuln(x86-64) golang-x-vuln-devel: golang(golang.org/x/vuln/client) golang(golang.org/x/vuln/client)(commit=348460952d62720df9244d4e7b81008a9195e109) golang(golang.org/x/vuln/cmd/govulncheck/internal/govulncheck) golang(golang.org/x/vuln/cmd/govulncheck/internal/govulncheck)(commit=348460952d62720df9244d4e7b81008a9195e109) golang(golang.org/x/vuln/internal) golang(golang.org/x/vuln/internal)(commit=348460952d62720df9244d4e7b81008a9195e109) golang(golang.org/x/vuln/internal/buildtest) golang(golang.org/x/vuln/internal/buildtest)(commit=348460952d62720df9244d4e7b81008a9195e109) golang(golang.org/x/vuln/internal/derrors) golang(golang.org/x/vuln/internal/derrors)(commit=348460952d62720df9244d4e7b81008a9195e109) golang(golang.org/x/vuln/osv) golang(golang.org/x/vuln/osv)(commit=348460952d62720df9244d4e7b81008a9195e109) golang(golang.org/x/vuln/vulncheck) golang(golang.org/x/vuln/vulncheck)(commit=348460952d62720df9244d4e7b81008a9195e109) golang(golang.org/x/vuln/vulncheck/internal/binscan) golang(golang.org/x/vuln/vulncheck/internal/binscan)(commit=348460952d62720df9244d4e7b81008a9195e109) golang(golang.org/x/vuln/vulncheck/internal/gosym) golang(golang.org/x/vuln/vulncheck/internal/gosym)(commit=348460952d62720df9244d4e7b81008a9195e109) golang-ipath(golang.org/x/vuln) golang-ipath(golang.org/x/vuln)(commit=348460952d62720df9244d4e7b81008a9195e109) golang-x-vuln-devel golang-x-vuln-debuginfo: debuginfo(build-id) golang-x-vuln-debuginfo golang-x-vuln-debuginfo(x86-64) golang-x-vuln-debugsource: golang-x-vuln-debugsource golang-x-vuln-debugsource(x86-64) Diff spec file in url and in SRPM --------------------------------- --- /home/elliott/rpmbuild/review/2110130-golang-x-vuln/srpm/golang-x-vuln.spec 2022-08-01 12:25:57.050397310 -0400 +++ /home/elliott/rpmbuild/review/2110130-golang-x-vuln/srpm-unpacked/golang-x-vuln.spec 2022-07-30 15:16:59.000000000 -0400 @@ -20,4 +20,5 @@ Summary: Database client and tools for the Go vulnerability database +# Upstream license specification: BSD-3-Clause License: BSD-3-Clause URL: %{gourl} Generated by fedora-review 0.8.0 (e988316) last change: 2022-04-07 Command line :/usr/bin/fedora-review -b 2110130 Buildroot used: fedora-rawhide-x86_64 Active plugins: Generic, Shell-api Disabled plugins: Haskell, R, Python, Perl, fonts, SugarActivity, PHP, Java, Ocaml, C/C++ Disabled flags: EPEL6, EPEL7, DISTTAG, BATCH, EXARCH
(fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/golang-x-vuln
FEDORA-2022-4ee9d2157b has been submitted as an update to Fedora 37. https://bodhi.fedoraproject.org/updates/FEDORA-2022-4ee9d2157b
FEDORA-2022-4ee9d2157b has been pushed to the Fedora 37 stable repository. If problem still persists, please make note of it in this bug report.