Created attachment 1899463 [details] proposed fix for luac double free Description of problem: luac crashes with a double free when building lsyncd on f36 on armv7hl. Strangely, it builds fine on f37 and on other f36 arches. Version-Release number of selected component (if applicable): lua-5.4.4-1.fc36 How reproducible: always Steps to Reproduce: 1. fedpkg clone lsyncd 2. fedpkg switch-branch f36 3. fedpkg scratch-build Actual results: https://koji.fedoraproject.org/koji/taskinfo?taskID=90077485 Building target platforms: armv7hl Building for target armv7hl ... gmake[2]: Entering directory '/builddir/build/BUILD/lsyncd-2.3.0/redhat-linux-build' /usr/bin/cmake -E create_symlink /builddir/build/BUILD/lsyncd-2.3.0/tests tests Compiling built-in runner Compiling built-in default configs /usr/bin/luac -o defaults.out /builddir/build/BUILD/lsyncd-2.3.0/default.lua /builddir/build/BUILD/lsyncd-2.3.0/default-rsync.lua /builddir/build/BUILD/lsyncd-2.3.0/default-rsyncssh.lua /builddir/build/BUILD/lsyncd-2.3.0/default-direct.lua /usr/bin/luac -o runner.out /builddir/build/BUILD/lsyncd-2.3.0/lsyncd.lua free(): double free detected in tcache 2 gmake[2]: Leaving directory '/builddir/build/BUILD/lsyncd-2.3.0/redhat-linux-build' [ 22%] Built target prepare_tests [ 33%] Generating runner.c /usr/bin/cmake -E echo Generating\ built-in\ runner\ linkable Generating built-in runner linkable /usr/bin/lua /builddir/build/BUILD/lsyncd-2.3.0/bin2carray.lua runner.out runner runner.c gmake[2]: *** [CMakeFiles/lsyncd.dir/build.make:96: defaults.out] Aborted (core dumped) gmake[2]: *** Deleting file 'defaults.out' gmake[2]: Leaving directory '/builddir/build/BUILD/lsyncd-2.3.0/redhat-linux-build' gmake[1]: Leaving directory '/builddir/build/BUILD/lsyncd-2.3.0/redhat-linux-build' gmake[1]: *** [CMakeFiles/Makefile2:194: CMakeFiles/lsyncd.dir/all] Error 2 gmake: *** [Makefile:139: all] Error 2 Expected results: No crash Additional info: Upstream mailing list proposes this fix which I've attached as a patch: http://lua-users.org/lists/lua-l/2022-02/msg00113.html
F35 lsyncd build failure: https://koji.fedoraproject.org/koji/taskinfo?taskID=90929321 F36 lsyncd build failure: https://koji.fedoraproject.org/koji/taskinfo?taskID=90928740 F37 lsyncd build success: https://koji.fedoraproject.org/koji/taskinfo?taskID=90928567 F38 lsyncd build success: https://koji.fedoraproject.org/koji/taskinfo?taskID=90927943
Can you please apply https://src.fedoraproject.org/rpms/lua/pull-request/7 and backport to F36 so I can solve the FTBFS of lsyncd? Thank you.
FEDORA-2022-2e6b534152 has been submitted as an update to Fedora 36. https://bodhi.fedoraproject.org/updates/FEDORA-2022-2e6b534152
FEDORA-2022-a799145f70 has been submitted as an update to Fedora 37. https://bodhi.fedoraproject.org/updates/FEDORA-2022-a799145f70
FEDORA-2022-a799145f70 has been pushed to the Fedora 37 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf upgrade --enablerepo=updates-testing --refresh --advisory=FEDORA-2022-a799145f70` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2022-a799145f70 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
FEDORA-2022-2e6b534152 has been pushed to the Fedora 36 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf upgrade --enablerepo=updates-testing --refresh --advisory=FEDORA-2022-2e6b534152` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2022-2e6b534152 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
FEDORA-2022-a799145f70 has been pushed to the Fedora 37 stable repository. If problem still persists, please make note of it in this bug report.
FEDORA-2022-2e6b534152 has been pushed to the Fedora 36 stable repository. If problem still persists, please make note of it in this bug report.
I'm hitting this luac bug on f38 now. Can you please build this for rawhide/f38? Thanks! FTBFS: Generating built-in runner linkable /usr/bin/lua /builddir/build/BUILD/lsyncd-2.3.1/bin2carray.lua runner.out runner runner.c gmake[2]: *** [CMakeFiles/lsyncd.dir/build.make:96: defaults.out] Aborted (core dumped) https://github.com/lsyncd/lsyncd/issues/687 http://lua-users.org/lists/lua-l/2022-11/msg00008.html
(In reply to Charles R. Anderson from comment #9) > I'm hitting this luac bug on f38 now. Can you please build this for > rawhide/f38? Thanks! I was able to submit a build for rawhide since it was already merged: https://bodhi.fedoraproject.org/updates/FEDORA-2023-f8c4a4a032