Spec URL: http://declera.com/~yaneti/perl-HTTP-Easy/perl-HTTP-Easy.spec SRPM URL: http://declera.com/~yaneti/perl-HTTP-Easy/perl-HTTP-Easy-0.02-1.fc37.src.rpm Description: Set of useful helpers for HTTP work with perl. Fedora Account System Username: yaneti I know... everyone makes up their own HTTP helpers. MONS did and would require them for testing the new AnyEvent::HTTP::Server
URL and Source0 addresses are Ok. Source0 archive (SHA512: 887fa8f112270ee008aa1cfae6d7de6600b7fe1be8b94aece840248c1c4ecf2daa2c68eb94866689ab55318a5bcec5534baa04f46ec4e470015a503a770969e2) is original. Ok. Summary is Ok. Description is Ok. TODO: Capitalize "perl" in the description. This in used in a sense of the programming language. License verified from README and lib/HTTP/Easy.pm. FIX: We have new licensing guidelines. Please write a license tag value in SPDX syntax <https://docs.fedoraproject.org/en-US/legal/license-field/#_perl_packages> (perl-HTTP-Easy.spec:5). No XS code, noarch BuildArch is Ok. TODO: Constrain 'BuildeRequire: perl(ExtUtils::MakeMaker)' with '>= 6.76' because of Makefile.PL arguments (perl-HTTP-Easy.spec:15). TODO: Replace '%{__perl}' macro with a plain 'perl' command (perl-HTTP-Easy.spec:26). FIX: Build-require 'coreutils' (perl-HTTP-Easy.spec:40). TODO: Build-require 'perl(:VERSION) >= 5.8.8' (Makefile.PL:1). TODO: Unset 'AUTHOR' environment variable before executing Makefile.PL to prevent from loading CPAN::Meta accidentally (Makefile.PL:4). Test::Pod::Coverage, Pod::Coverage, Test::Pod are not used. Ok. HTTP::Easy::Headers::XS and HTTP::Easy::Cookies::XS do not exist. No need for soft-requiring them. Ok. All tests pass. Ok. $ rpmlint perl-HTTP-Easy.spec ../SRPMS/perl-HTTP-Easy-0.02-1.fc37.src.rpm ../RPMS/noarch/perl-HTTP-Easy-0.02-1.fc37.noarch.rpm ======================================== rpmlint session starts ======================================= rpmlint: 2.2.0 configuration: /usr/lib/python3.11/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/licenses.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 32, packages: 3 ========= 2 packages and 1 specfiles checked; 0 errors, 0 warnings, 0 badness; has taken 0.2 s ======== rpmlint is Ok. $ rpm -q -lv -p ../RPMS/noarch/perl-HTTP-Easy-0.02-1.fc37.noarch.rpm drwxr-xr-x 2 root root 0 Aug 4 14:53 /usr/share/doc/perl-HTTP-Easy -rw-r--r-- 1 root root 109 Jul 18 2013 /usr/share/doc/perl-HTTP-Easy/Changes -rw-r--r-- 1 root root 1000 Jul 18 2013 /usr/share/doc/perl-HTTP-Easy/README -rw-r--r-- 1 root root 1586 Aug 4 14:52 /usr/share/man/man3/HTTP::Easy.3pm.gz drwxr-xr-x 2 root root 0 Aug 4 14:53 /usr/share/perl5/vendor_perl/HTTP drwxr-xr-x 2 root root 0 Aug 4 14:53 /usr/share/perl5/vendor_perl/HTTP/Easy -rw-r--r-- 1 root root 1080 Jul 18 2013 /usr/share/perl5/vendor_perl/HTTP/Easy.pm drwxr-xr-x 2 root root 0 Aug 4 14:53 /usr/share/perl5/vendor_perl/HTTP/Easy/Cookies -rw-r--r-- 1 root root 263 Jul 18 2013 /usr/share/perl5/vendor_perl/HTTP/Easy/Cookies.pm -rw-r--r-- 1 root root 4109 Jul 18 2013 /usr/share/perl5/vendor_perl/HTTP/Easy/Cookies/PP.pm drwxr-xr-x 2 root root 0 Aug 4 14:53 /usr/share/perl5/vendor_perl/HTTP/Easy/Headers -rw-r--r-- 1 root root 263 Jul 18 2013 /usr/share/perl5/vendor_perl/HTTP/Easy/Headers.pm -rw-r--r-- 1 root root 1234 Jul 18 2013 /usr/share/perl5/vendor_perl/HTTP/Easy/Headers/PP.pm -rw-r--r-- 1 root root 1937 Jul 18 2013 /usr/share/perl5/vendor_perl/HTTP/Easy/Status.pm -rw-r--r-- 1 root root 1009 Jul 18 2013 /usr/share/perl5/vendor_perl/HTTP/Easy/URI.pm File layout and permissions are Ok. $ rpm -q --requires -p ../RPMS/noarch/perl-HTTP-Easy-0.02-1.fc37.noarch.rpm | sort -f | uniq -c 1 perl(:MODULE_COMPAT_5.36.0) 1 perl(base) 1 perl(Exporter) 1 perl(Scalar::Util) 1 perl(strict) 1 perl(Time::Local) 1 perl(warnings) 1 rpmlib(CompressedFileNames) <= 3.0.4-1 1 rpmlib(FileDigests) <= 4.6.0-1 1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 1 rpmlib(PayloadIsZstd) <= 5.4.18-1 Binary requires are Ok. $ rpm -q --provides -p ../RPMS/noarch/perl-HTTP-Easy-0.02-1.fc37.noarch.rpm | sort -f | uniq -c 1 perl(HTTP::Easy) = 0.02 1 perl(HTTP::Easy::Cookies) 1 perl(HTTP::Easy::Cookies::PP) 1 perl(HTTP::Easy::Headers) 1 perl(HTTP::Easy::Headers::PP) 1 perl(HTTP::Easy::Status) 1 perl(HTTP::Easy::URI) 1 perl-HTTP-Easy = 0.02-1.fc37 Binary provides are Ok. $ resolvedeps rawhide ../RPMS/noarch/perl-HTTP-Easy-0.02-1.fc37.noarch.rpm Binary dependencies are resolvable. Ok. The package builds in Fedora 37 (https://koji.fedoraproject.org/koji/taskinfo?taskID=90465393). Ok. Otherwise the package is in line with Fedora and Perl packaging guidelines. Please correct the 'FIX' items, consider fixing 'TODO' items, and provide a new spec file. Resolution: Package NOT approved.
-2 Addressed the FIX-mes and TODO-s Spec URL: http://declera.com/~yaneti/perl-HTTP-Easy/perl-HTTP-Easy.spec SRPM URL: http://declera.com/~yaneti/perl-HTTP-Easy/perl-HTTP-Easy-0.02-2.fc37.src.rpm
Changes in the spec file: --- perl-HTTP-Easy.spec.old 2022-07-27 19:56:52.000000000 +0200 +++ perl-HTTP-Easy.spec 2022-08-04 15:19:15.000000000 +0200 @@ -1,37 +1,40 @@ Name: perl-HTTP-Easy Version: 0.02 -Release: 1%{?dist} +Release: 2%{?dist} Summary: HTTP helpers for Perl -License: GPL+ or Artistic +License: GPL-1.0-or-later OR Artistic-1.0-Perl URL: https://metacpan.org/dist/HTTP-Easy Source0: https://cpan.metacpan.org/authors/id/M/MO/MONS/HTTP-Easy-%{version}.tar.gz BuildArch: noarch +BuildRequires: coreutils BuildRequires: make BuildRequires: perl-generators BuildRequires: perl-interpreter BuildRequires: perl(Exporter) -BuildRequires: perl(ExtUtils::MakeMaker) +BuildRequires: perl(ExtUtils::MakeMaker) >= 6.76 BuildRequires: perl(Scalar::Util) BuildRequires: perl(Time::Local) BuildRequires: perl(base) BuildRequires: perl(strict) BuildRequires: perl(warnings) +BuildRequires: perl(:VERSION) >= 5.8.8 # tests BuildRequires: perl(Test::More) BuildRequires: perl(lib::abs) BuildRequires: perl(URI) -Requires: perl(:MODULE_COMPAT_%(eval "`%{__perl} -V:version`"; echo $version)) +Requires: perl(:MODULE_COMPAT_%(eval "`perl -V:version`"; echo $version)) %description -Set of useful helpers for HTTP work with perl. +Set of useful helpers for HTTP work with Perl. %prep %setup -q -n HTTP-Easy-%{version} %build +unset AUTHOR perl Makefile.PL INSTALLDIRS=vendor NO_PACKLIST=1 NO_PERLLOCAL=1 %make_build @@ -48,5 +51,8 @@ %{_mandir}/man3/* %changelog +* Thu Aug 4 2022 Yanko Kaneti <yaneti> - 0.02-2 +- Address review issues (#2111647) + * Wed Jul 27 2022 Yanko Kaneti <yaneti> - 0.02-1 - First attempt $ rpmlint perl-HTTP-Easy.spec ../SRPMS/perl-HTTP-Easy-0.02-2.fc37.src.rpm ../RPMS/noarch/perl-HTTP-Easy-0.02-2.fc37.noarch.rpm ======================================== rpmlint session starts ======================================= rpmlint: 2.2.0 configuration: /usr/lib/python3.11/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/licenses.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 32, packages: 3 perl-HTTP-Easy.noarch: W: invalid-license GPL-1.0-or-later perl-HTTP-Easy.noarch: W: invalid-license Artistic-1.0-Perl perl-HTTP-Easy.src: W: invalid-license GPL-1.0-or-later perl-HTTP-Easy.src: W: invalid-license Artistic-1.0-Perl ========= 2 packages and 1 specfiles checked; 0 errors, 4 warnings, 0 badness; has taken 0.2 s ======== rpmlint is Ok. The package builds in F37 (https://koji.fedoraproject.org/koji/taskinfo?taskID=90466047). Ok. Resolution: Package APPROVED.
(fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/perl-HTTP-Easy
https://koji.fedoraproject.org/koji/buildinfo?buildID=2042013 Thanks for the review