Description of problem: THe mode and eip/rip are not properly updated for HVM guests for AMD-V. The attached patches modify AMD-V specific code, and add a generic xenoprofile function for HVM. These patches have not been pushed up to xen-unstable.hg, but will be when the tree reopens after 3.0.3 is released. Version-Release number of selected component (if applicable): All xen versions have this bug. How reproducible: run xenoprofile 0.9.2 with additional patch from HP (Renato Santos) to enable passive profiling. Steps to Reproduce: 1. start up hvm guest on AMD-V machine 2. run xenoprofile 0.9.2 w/ passive patch 3. the profiling records will be incorrect (wrong symbol matches) Actual results: Expected results: Additional info:
Created attachment 138715 [details] 1/3 patch for 3.0.3 xenoprofile AMD-V mode eip/rip fix.
Created attachment 138717 [details] 2/3 patch for 3.0.3 xenoprofile AMD-V mode eip/rip fix.
Created attachment 138718 [details] 3/3 patch for 3.0.3 xenoprofile AMD-V mode eip/rip fix.
Please attach the changeset once this is submitted in -unstable. We will include this after Beta 2.
the xenoprofile HVM support is now in the xen-unstable tree. please use changesets 11843 and 11844 from xen-unstable.hg for the latest patches.
This request was evaluated by Red Hat Product Management for inclusion in a Red Hat Enterprise Linux release. Product Management has requested further review of this request by Red Hat Engineering. This request is not yet committed for inclusion in release.
Does this patch require the HP xenoprofile patch to be relevant?
just to be clear, the HP patch is only used for the application oprofile, but the answer is yes. basically, to perform passive profiling for HVM guests properly you need to have the AMD-V patches from xen-unstable incorporated into your hypervisor, and also the oprofile-0.9.2+HP patch for the Dom0 application level opreport/opcontrol apps. 0.9.3 should be out soon with this patch integrated.
Created attachment 139462 [details] Upstream version of the patch (xen-unstable.hg changesets 11843 and 11844)
The attached patches from xen-unstable 11843 and 11844 are functionally correct.
Here's the user space patch link: A XenOprofile patch for Oprofile 0.9.2 is now available at http://xenoprof.sourceforge.net. Oprofile 0.9.2 already supports XenOprofile but it does not include support for passive domain profiling. This patch adds passive domain profiling support to Oprofile 0.9.2.
QE ack for RHEL5.
Bhavana Nagendra reports that xen-unstable.hg changeset 12667 is also needed. Posted, awaiting ACKs.
I'm adding these notes regarding testing to set expectations. There are more than 20+ xenoprof patches upstream which are required to completely get xenoprof to work. Out of these we have identified 3 patches that have the most impact. Running some known scripts utilizing opcontrol/opreport the hypervisor generates some good samples. There are some errors but these are expected as the RHEL5 code base is missing a number of patches. We will target RHEL5.1 for the remaining patches, but the submitted patches needs to be included in RHEL5 RC snapshot 6.
Release note: Profiling of fully virtual domains may be inaccurate. This will be addressed in a future update of Red Hat Enterprise Linux 5.
Too many patches for GA inclusion, pushing to 5.1.
Version flag needs to be modified to reflect that this is a RHEL5.1 requirement
Flags continue to be correctly set.
Switching to MODIFIED because the rebase to a 3.1 hypervisor took care of this. More changes are needed for a fully functional Xenoprof, but those are tracked in bug 241982.
A fix for this issue should have been included in the packages contained in the RHEL5.1-Snapshot3 on partners.redhat.com. Requested action: Please verify that your issue is fixed as soon as possible to ensure that it is included in this update release. After you (Red Hat Partner) have verified that this issue has been addressed, please perform the following: 1) Change the *status* of this bug to VERIFIED. 2) Add *keyword* of PartnerVerified (leaving the existing keywords unmodified) If this issue is not fixed, please add a comment describing the most recent symptoms of the problem you are having and change the status of the bug to FAILS_QA. More assistance: If you cannot access bugzilla, please reply with a message to Issue Tracker and I will change the status for you. If you need assistance accessing ftp://partners.redhat.com, please contact your Partner Manager.
A fix for this issue should have been included in the packages contained in the RHEL5.1-Snapshot4 on partners.redhat.com. Requested action: Please verify that your issue is fixed *as soon as possible* to ensure that it is included in this update release. After you (Red Hat Partner) have verified that this issue has been addressed, please perform the following: 1) Change the *status* of this bug to VERIFIED. 2) Add *keyword* of PartnerVerified (leaving the existing keywords unmodified) If this issue is not fixed, please add a comment describing the most recent symptoms of the problem you are having and change the status of the bug to FAILS_QA. If you cannot access bugzilla, please reply with a message to Issue Tracker and I will change the status for you. If you need assistance accessing ftp://partners.redhat.com, please contact your Partner Manager.
A fix for this issue should have been included in the packages contained in the RHEL5.1-Snapshot6 on partners.redhat.com. Requested action: Please verify that your issue is fixed ASAP to confirm that it will be included in this update release. After you (Red Hat Partner) have verified that this issue has been addressed, please perform the following: 1) Change the *status* of this bug to VERIFIED. 2) Add *keyword* of PartnerVerified (leaving the existing keywords unmodified) If this issue is not fixed, please add a comment describing the most recent symptoms of the problem you are having and change the status of the bug to FAILS_QA. If you cannot access bugzilla, please reply with a message to Issue Tracker and I will change the status for you. If you need assistance accessing ftp://partners.redhat.com, please contact your Partner Manager.
A fix for this issue should have been included in the packages contained in the RHEL5.1-Snapshot7 on partners.redhat.com. Requested action: Please verify that your issue is fixed ASAP to confirm that it will be included in this update release. After you (Red Hat Partner) have verified that this issue has been addressed, please perform the following: 1) Change the *status* of this bug to VERIFIED. 2) Add *keyword* of PartnerVerified (leaving the existing keywords unmodified) If this issue is not fixed, please add a comment describing the most recent symptoms of the problem you are having and change the status of the bug to FAILS_QA. If you cannot access bugzilla, please reply with a message to Issue Tracker and I will change the status for you. If you need assistance accessing ftp://partners.redhat.com, please contact your Partner Manager.
A fix for this issue should be included in the packages contained in RHEL5.1-Snapshot8--available now on partners.redhat.com. IMPORTANT: This is the last opportunity to confirm that your issue is fixed in the RHEL5.1 update release. After you (Red Hat Partner) have verified that this issue has been addressed, please perform the following: 1) Change the *status* of this bug to VERIFIED. 2) Add *keyword* of PartnerVerified (leaving the existing keywords unmodified) If this issue is not fixed, please add a comment describing the most recent symptoms of the problem you are having and change the status of the bug to FAILS_QA. If you cannot access bugzilla, please reply with a message to Issue Tracker and I will change the status for you. If you need assistance accessing ftp://partners.redhat.com, please contact your Partner Manager.
An advisory has been issued which should help the problem described in this bug report. This report is therefore being closed with a resolution of ERRATA. For more information on the solution and/or where to find the updated files, please follow the link below. You may reopen this bug report if the solution does not work for you. http://rhn.redhat.com/errata/RHBA-2007-0959.html