Fedora Account System
Red Hat Associate
Red Hat Customer
Spec URL: https://kalev.fedorapeople.org/libpanel.spec SRPM URL: https://kalev.fedorapeople.org/libpanel-1.0~alpha-1.fc37.src.rpm Description: libpanel is a collection of GTK widgets for IDE-like applications targeting GNOME using GTK and libadwaita. Fedora Account System Username: kalev This package is a new dependency for gnome-builder 43~alpha release. Koji scratch build: https://koji.fedoraproject.org/koji/taskinfo?taskID=90192785
The scratch build above failed due to what looks like an intermittent parallel build issue, should be easy to fix or work around if it shows up again (my earlier scratch build went fine).
I think you need "Requires: hicolor-icon-theme" so the icon directory structure retains proper package ownership.
I would also adjust the source to use variables wherever possible: Source0: https://download.gnome.org/sources/%{name}/1.0/%{name}-%{tarball_version}.tar.xz
(In reply to Jonathan Wright from comment #2) > I think you need "Requires: hicolor-icon-theme" so the icon directory > structure retains proper package ownership. Thanks! Fixed. Spec URL: https://kalev.fedorapeople.org/libpanel.spec SRPM URL: https://kalev.fedorapeople.org/libpanel-1.0~alpha-2.fc37.src.rpm Koji scratch build: https://koji.fedoraproject.org/koji/taskinfo?taskID=90200176 (In reply to Jonathan Wright from comment #3) > I would also adjust the source to use variables wherever possible: > > Source0: > https://download.gnome.org/sources/%{name}/1.0/%{name}-%{tarball_version}. > tar.xz I disagree with this one, because %{name} semantically means the package name and not necessarily the upstream tarball name. They happen to match here but if we had instead called the package e.g. libpanel1 (which can easily happen in the future if we need to make a compat package for a future API bump) then they no longer match up and someone needs to go and remove all the %{name} substitutions from urls and things where they then would be wrong. I have used %{name} where it semantically means the package name, e.g. "Requires: %{name}%{?_isa} = %{version}-%{release}" that the -devel package has.
Note the changelog diff at the bottom and the spec mismatch between spec and srpm. I imagine you're going to use %autochangelog from the spec file (not the static entries from the spec in the SRPM). Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated ===== MUST items ===== C/C++: [x]: Package does not contain kernel modules. [x]: Package contains no static executables. [x]: If your application is a C or C++ application you must list a BuildRequires against gcc, gcc-c++ or clang. [x]: Header files in -devel subpackage, if present. [x]: ldconfig not called in %post and %postun for Fedora 28 and later. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. [x]: Development (unversioned) .so files in -devel subpackage, if present. Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "GNU Lesser General Public License, Version 3", "GNU Lesser General Public License v3.0 or later", "GNU Lesser General Public License v2.1 or later", "GNU Library General Public License v2 or later". 40 files have unknown license. Detailed output of licensecheck in /home/jonathan/fedora- review/2111978-libpanel/licensecheck.txt [x]: License file installed when any subpackage combination is installed. [x]: Package does not own files or directories owned by other packages. Note: Dirs in package are owned also by: /usr/share/gir-1.0(amtk- devel, gfbgraph-devel, libchamplain-devel, libgepub-devel, gegl04-devel, libadwaita-devel, gplugin-devel, gtksourceview5-devel, gnome-bluetooth3.34-libs-devel, gtk3-devel, gdm-devel, libarrow- dataset-glib-devel, template-glib-devel, babl-devel, librsvg2-devel, libgtop2-devel, vte291-devel, webkit2gtk3-devel, libxklavier-devel, json-glib-devel, gnome-menus-devel, gnome-bluetooth-libs-devel, tracker-devel, gsound-devel, bamf-devel, gstreamer1-rtsp-server-devel, gnome-calculator-devel, appstream-devel, zbar-gi, libcryptui-devel, glade-devel, libmodulemd1-devel, libsoup3-devel, libhandy-devel, fcitx5-gtk-devel, gdk-pixbuf2-devel, libsoup-devel, gcr3-devel, gplugin-gtk4-devel, libmash-devel, libinsane-gobject-devel, gnome- online-accounts-devel, rygel-devel, libmypaint-devel, clapper-devel, gplugin-gtk3-devel, webkit2gtk4.1-devel, gupnp-devel, libsecret-devel, harfbuzz-devel, libgee-devel, grilo-devel, colord-gtk-devel, libgexiv2-devel, vips-devel, jsonrpc-glib-devel, malcontent-ui-devel, gitg-devel, libdazzle-devel, gupnp-igd-devel, gtksourceview4-devel, totem-pl-parser-devel, libpeas-devel, vte-devel, goocanvas2-devel, libgdl-devel, libgxps-devel, geoclue2-devel, gnome-autoar-devel, graphene-devel, gupnp-dlna-devel, atk-devel, libjcat-devel, ibus- devel, gobject-introspection-devel, gst-devtools-devel, gmime30-devel, libmodulemd-devel, libgdata-devel, parquet-glib-devel, webkit2gtk4.1-jsc-devel, gspell-devel, clutter-devel, libarrow-glib- devel, libmanette-devel, gsequencer-devel, libxmlb-devel, webkit2gtk3-jsc-devel, gtk4-devel, malcontent-devel, libdmapsharing4-devel, GConf2-devel, gucharmap-devel, libgnome- keyring-devel, fcitx-devel, gupnp-av-devel, gssdp-devel, libgee06-devel, at-spi2-core-devel, gtk2-devel), /usr/share/vala(libgweather4-devel, vala, gegl04-devel, jsonrpc-glib- devel, gplugin-vala, gtksourceview5-devel, libdmapsharing-devel, libsoup3-devel, gitg-devel, libhandy-devel, gspell-devel, libdazzle- devel, gtksourceview4-devel, libgda-ui-devel, caribou-devel, gedit- devel, libsoup-devel, libmanette-devel, gcr3-devel, libtranslit-devel, dconf-devel, grilo-devel, template-glib-devel, babl-devel, librsvg2-devel, libgweather-devel, vte291-devel, gnome-online- accounts-devel, rhythmbox-devel, pulseaudio-libs-devel, libcanberra- devel, rygel-devel, geoclue2-devel, libgit2-glib-devel, folks-devel, gnome-autoar-devel, gtksourceview3-devel, libgnome-games-support- devel, gupnp-devel, gupnp-dlna-devel, gmime-devel, libdmapsharing4-devel, tracker-devel, libsecret-devel, libgnome- keyring-devel, libjcat-devel, zeitgeist-devel, gsound-devel, gupnp-av- devel, libosinfo-devel, bamf-devel, ibus-devel, gmime30-devel, gssdp- devel, libgee-devel, libgee06-devel, gnome-calculator-devel, appstream-devel, libgdata-devel, libgda-devel, libgexiv2-devel), /usr/share/vala/vapi(libgweather4-devel, vala, gegl04-devel, jsonrpc- glib-devel, gplugin-vala, gtksourceview5-devel, libdmapsharing-devel, libsoup3-devel, gitg-devel, libhandy-devel, gspell-devel, libdazzle- devel, gtksourceview4-devel, libgda-ui-devel, caribou-devel, gedit- devel, libsoup-devel, libmanette-devel, gcr3-devel, libtranslit-devel, dconf-devel, grilo-devel, template-glib-devel, babl-devel, librsvg2-devel, libgweather-devel, vte291-devel, gnome-online- accounts-devel, rhythmbox-devel, pulseaudio-libs-devel, libcanberra- devel, rygel-devel, geoclue2-devel, libgit2-glib-devel, fwupd-devel, folks-devel, gnome-autoar-devel, gtksourceview3-devel, libgnome-games- support-devel, gupnp-devel, gupnp-dlna-devel, gmime-devel, libdmapsharing4-devel, tracker-devel, libsecret-devel, libgnome- keyring-devel, libjcat-devel, zeitgeist-devel, gsound-devel, gupnp-av- devel, libosinfo-devel, bamf-devel, ibus-devel, gmime30-devel, gssdp- devel, libgee-devel, libgee06-devel, gnome-calculator-devel, appstream-devel, libgdata-devel, libgda-devel, libzeitgeist-devel, libgexiv2-devel), /usr/lib64/girepository-1.0(libgexiv2, clutter, template-glib, libarrow-flight-libs, gcr, libdazzle, amtk, gcr3, glade-libs, libtracker-sparql, rygel, libgepub, GConf2, libgee, gnome- online-accounts, libsoup3, gsound, zbar-gi, gupnp, playerctl-libs, libgtop2, gspell, webkit2gtk4.1-jsc, ibus-libs, gtk3, webkit2gtk3-jsc, babl, libpeas, libinsane-gobject, libmash, libxmlb, gtksourceview4, gitg-libs, gnome-menus, appstream, gst-devtools, librsvg2, malcontent- ui-libs, gplugin-gtk3-libs, libgxps, gtksourceview5, libgdata, gnome- calculator, gucharmap-libs, atk, gupnp-igd, gplugin-gtk4-libs, gsequencer, libmodulemd1, libgee06, libarrow-dataset-glib-libs, libmanette, libsecret, libmodulemd, json-glib, gnome- bluetooth3.34-libs, libchamplain, jsonrpc-glib, gdk-pixbuf2, harfbuzz, libmypaint, malcontent-libs, gtk2, gmime30, gssdp, gupnp-dlna, gupnp- av, libhandy, gplugin-libs, libcryptui, webkit2gtk3, gnome-bluetooth- libs, gtk4, vte, goocanvas2, gnome-autoar, libjcat, libxklavier, libgdl, gstreamer1-rtsp-server, gobject-introspection, vte291, libdmapsharing4, geoclue2-libs, parquet-glib-libs, grilo, libgnome- keyring, gfbgraph, vips, libarrow-glib-libs, libsoup, at-spi2-core, graphene, fcitx-libs, webkit2gtk4.1) [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [x]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [-]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [ ]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 10240 bytes in 3 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in libpanel-devel [x]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [x]: Package should compile and build into binary rpms on all supported architectures. [-]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: The placement of pkgconfig(.pc) files are correct. [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Spec file according to URL is the same as in SRPM. Note: Spec file as given by url is not the same as in SRPM (see attached diff). See: (this test has no URL) [x]: Rpmlint is run on debuginfo package(s). Note: There are rpmlint messages (see attachment). [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. Rpmlint ------- Cannot parse rpmlint output: Rpmlint (debuginfo) ------------------- Cannot parse rpmlint output: Rpmlint (installed packages) ---------------------------- Cannot parse rpmlint output: Source checksums ---------------- https://download.gnome.org/sources/libpanel/1.0/libpanel-1.0.alpha.tar.xz : CHECKSUM(SHA256) this package : 370b39bf544c65ff732927817ede337cb8a15aa36d7081cdb91b593c040d3195 CHECKSUM(SHA256) upstream package : 370b39bf544c65ff732927817ede337cb8a15aa36d7081cdb91b593c040d3195 Requires -------- libpanel (rpmlib, GLIBC filtered): hicolor-icon-theme libadwaita-1.so.0()(64bit) libadwaita-1.so.0(LIBADWAITA_1_0)(64bit) libc.so.6()(64bit) libcairo.so.2()(64bit) libgcc_s.so.1()(64bit) libgcc_s.so.1(GCC_3.0)(64bit) libgcc_s.so.1(GCC_3.3.1)(64bit) libgio-2.0.so.0()(64bit) libglib-2.0.so.0()(64bit) libgobject-2.0.so.0()(64bit) libgraphene-1.0.so.0()(64bit) libgtk-4.so.1()(64bit) rtld(GNU_HASH) libpanel-devel (rpmlib, GLIBC filtered): /usr/bin/pkg-config libpanel(x86-64) libpanel-1.so.1()(64bit) pkgconfig(gio-2.0) pkgconfig(glib-2.0) pkgconfig(gobject-2.0) pkgconfig(gtk4) libpanel-debuginfo (rpmlib, GLIBC filtered): libpanel-debugsource (rpmlib, GLIBC filtered): Provides -------- libpanel: libpanel libpanel(x86-64) libpanel-1.so.1()(64bit) libpanel-devel: libpanel-devel libpanel-devel(x86-64) pkgconfig(libpanel-1) libpanel-debuginfo: debuginfo(build-id) libpanel-1.so.1.0.0-1.0~alpha-2.fc37.x86_64.debug()(64bit) libpanel-debuginfo libpanel-debuginfo(x86-64) libpanel-debugsource: libpanel-debugsource libpanel-debugsource(x86-64) Diff spec file in url and in SRPM --------------------------------- --- /home/jonathan/fedora-review/2111978-libpanel/srpm/libpanel.spec 2022-07-28 15:50:58.325428752 -0500 +++ /home/jonathan/fedora-review/2111978-libpanel/srpm-unpacked/libpanel.spec 2022-07-28 14:47:37.000000000 -0500 @@ -1,2 +1,11 @@ +## START: Set by rpmautospec +## (rpmautospec version 0.2.6) +%define autorelease(e:s:pb:) %{?-p:0.}%{lua: + release_number = 2; + base_release_number = tonumber(rpm.expand("%{?-b*}%{!?-b:1}")); + print(release_number + base_release_number - 1); +}%{?-e:.%{-e*}}%{?-s:.%{-s*}}%{?dist} +## END: Set by rpmautospec + %global tarball_version %%(echo %{version} | tr '~' '.') @@ -66,3 +75,7 @@ %changelog -%autochangelog +* Thu Jul 28 2022 Kalev Lember <klember> 1.0~alpha-2 +- Add hicolor-icon-theme requires + +* Thu Jul 28 2022 Kalev Lember <klember> 1.0~alpha-1 +- Initial Fedora packaging Generated by fedora-review 0.8.0 (e988316) last change: 2022-04-07 Command line :/usr/bin/fedora-review -b 2111978 Buildroot used: fedora-rawhide-x86_64 Active plugins: C/C++, Generic, Shell-api Disabled plugins: Java, SugarActivity, R, PHP, Haskell, Perl, fonts, Python, Ocaml Disabled flags: EPEL6, EPEL7, DISTTAG, BATCH, EXARCH
Package is APPROVED! If you have a second to review one of my open reviews I'd greatly appreciate it: https://bugzilla.redhat.com/show_bug.cgi?id=2110050 https://bugzilla.redhat.com/show_bug.cgi?id=2110055
Excellent, thank you!
(fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/libpanel