Bug 2112390 - ship a webp pixbuf loader
Summary: ship a webp pixbuf loader
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: gnome-backgrounds
Version: 37
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Kalev Lember
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: F37FinalBlocker
TreeView+ depends on / blocked
 
Reported: 2022-07-29 15:06 UTC by Jakub Steiner
Modified: 2022-08-16 12:26 UTC (History)
16 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2022-08-16 11:55:36 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)

Description Jakub Steiner 2022-07-29 15:06:53 UTC
Description of problem:
GNOME 43 has switched to webp for its bitmap wallpapers (upstream change here -- https://gitlab.gnome.org/GNOME/gnome-build-meta/-/merge_requests/1682, original issue here -- https://gitlab.gnome.org/GNOME/gnome-build-meta/-/issues/502)

Fedora 36 is currently unable to use the wallpapers because the webp pixbuf loader is missing. It will be a necessity to have for F37.

Comment 1 Felipe Borges 2022-08-01 13:33:59 UTC
Instead of adding it to the compose, couldn't webp-pixbuf-loader be listed as a dependency for gnome-backgrounds? https://src.fedoraproject.org/rpms/gnome-backgrounds/blob/rawhide/f/gnome-backgrounds.spec

Comment 2 Owen Taylor 2022-08-01 14:58:52 UTC
Perhaps overthinking it, but gnome-backgrounds could have a boolean dependency:

 Requires: (webp-pixbuf-loader if gdk-pixbuf2)

to allow it to be installable without the GNOME stack. More relevant for the fedora backgrounds if we switch them to webp.

Comment 3 Kalev Lember 2022-08-02 09:57:38 UTC
(In reply to Owen Taylor from comment #2)
> Perhaps overthinking it, but gnome-backgrounds could have a boolean
> dependency:
> 
>  Requires: (webp-pixbuf-loader if gdk-pixbuf2)
> 
> to allow it to be installable without the GNOME stack. More relevant for the
> fedora backgrounds if we switch them to webp.

I think that's a good plan. I'll add the boolean dependencies when a new gnome-backgrounds release is out that actually adds the webp images.

Comment 4 Fedora Blocker Bugs Application 2022-08-04 20:51:27 UTC
Proposed as a Blocker for 37-final by Fedora user bcotton using the blocker tracking app because:

 Violates the Final criterion: The proposed final Fedora artwork must be included and used as the background on release-blocking desktops. All Fedora artwork visible in critical path actions on release-blocking desktops must be consistent with the proposed final theme.

Specifically, it prevents the "and used" part of the criterion.

Comment 5 Adam Williamson 2022-08-05 16:56:14 UTC
Technically, isn't this only a blocker if we switch the *Fedora* backgrounds to webp, and then the bug would be against fedora-backgrounds or some core GNOME component, not against gnome-backgrounds?

The criteria cover the stuff from fedora-backgrounds, not gnome-backgrounds. We don't even need to ship gnome-backgrounds to satisfy the criteria.

Comment 6 Ben Cotton 2022-08-09 13:23:16 UTC
This bug appears to have been reported against 'rawhide' during the Fedora Linux 37 development cycle.
Changing version to 37.

Comment 7 Kamil Páral 2022-08-16 11:44:27 UTC
@jsteiner Hey Jakub (or anyone else), can we please get comment 5 addressed? (Or just somebody perform the change before the Beta freeze and then we don't need to discuss it).

Comment 8 Kalev Lember 2022-08-16 11:55:36 UTC
It should be already done in gnome-backgrounds-43~beta-1.fc37, https://src.fedoraproject.org/rpms/gnome-backgrounds/c/a92f603efb22e80cecb2b4d96480d514c3921df3?branch=rawhide

Comment 9 Kamil Páral 2022-08-16 12:26:57 UTC
I can confirm that with Fedora-Workstation-Live-x86_64-37-20220814.n.0.iso installation I can display webp images in Nautilus and EOG just fine.


Note You need to log in before you can comment on or make changes to this bug.