Spec URL: http://thecodergeek.com/downloads/fedora/viaideinfo.spec SRPM URL: http://thecodergeek.com/downloads/fedora/viaideinfo-0.4-1.src.rpm This command-line application identifies VIA IDE controllers installed in the computer, and displays various information/statistics regarding these. This does not depend on the via82cxxx kernel IDE driver, and will work regardless of whether it is present or not. All this information used to be available through /proc/ide/via; however this file was removed in Linux 2.6.15 to reduce the complexity of the IDE driver. Since it performs some basic port I/O, it must be run as root. rpmlint is silent on both the binary and source RPMs.
OK - Package meets naming and packaging guidelines OK - Spec file matches base package name. OK - Spec has consistant macro usage. OK - Meets Packaging Guidelines. OK - License (GPL) OK - License field in spec matches OK - License file included in package OK - Spec in American English OK - Spec is legible. OK - Sources match upstream md5sum: e436a580eb8a047a0551cb996b11e6f5 viaideinfo-0.4.tar.gz e436a580eb8a047a0551cb996b11e6f5 viaideinfo-0.4.tar.gz.1 OK - Package has Exclusivearch OK - BuildRequires correct OK - Package has %defattr and permissions on files is good. OK - Package has a correct %clean section. OK - Package has correct buildroot OK - Package is code or permissible content. OK - Packages %doc files don't affect runtime. OK - Package compiles and builds on at least one arch. OK - Package has no duplicate files in %files. OK - Package doesn't own any directories other packages own. OK - Package owns all the directories it creates. OK - No rpmlint output. OK - final provides and requires are sane: SHOULD Items: OK - Should build in mock. OK - Should build on all supported archs OK - Should function as described. OK - Should have dist tag OK - Should package latest version Issues: 1. Since this package has ExclusiveArch: %{ix86} I assume none of the supported VIA chipsets are shipped on x86_64? Works fine on my firewall machine with a VT82C586A/B. I don't see any blockers here at all, so this package is APPROVED. Don't forget to close this review request with NEXTRELEASE once it's been imported and built. Consider reviewing another waiting package to help spread out the reviewing load.
(In reply to comment #1) > 1. Since this package has > ExclusiveArch: %{ix86} > I assume none of the supported VIA chipsets are shipped on > x86_64? Daniel Drake, the upstream maintainer, is also the person who maintains the package in Gentoo's Portage. In that, it's keyworded as x86-only. I'll email him about that just to be sure, though. :) > Consider reviewing another waiting package to help spread > out the reviewing load. I really should. I'll see what I can get tomorrow after work. Importing now...thanks for the review!
Imported, FC-5 branch requested, and devel build running on the build system. Thanks for the review! :)
Please do not remove the blocker on FE-ACCEPT
(In reply to comment #4) > Please do not remove the blocker on FE-ACCEPT Ack. Sorry about that; and thanks, Christian.
(In reply to comment #5) > Ack. Sorry about that; and thanks, Christian. np :-)