Bug 2113118 - barrier: FTBFS in Fedora rawhide/f37
Summary: barrier: FTBFS in Fedora rawhide/f37
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: barrier
Version: 37
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Ding-Yi Chen
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: F37FTBFS F38FTBFS
TreeView+ depends on / blocked
 
Reported: 2022-08-01 23:16 UTC by Fedora Release Engineering
Modified: 2023-01-26 15:09 UTC (History)
4 users (show)

Fixed In Version: barrier-2.4.0-4.fc38
Clone Of:
Environment:
Last Closed: 2023-01-26 15:09:15 UTC
Type: ---
Embargoed:


Attachments (Terms of Use)
build.log (13.71 KB, text/plain)
2022-08-01 23:16 UTC, Fedora Release Engineering
no flags Details
root.log (32.00 KB, text/plain)
2022-08-01 23:16 UTC, Fedora Release Engineering
no flags Details
state.log (963 bytes, text/plain)
2022-08-01 23:16 UTC, Fedora Release Engineering
no flags Details

Description Fedora Release Engineering 2022-08-01 23:16:54 UTC
barrier failed to build from source in Fedora rawhide/f37

https://koji.fedoraproject.org/koji/taskinfo?taskID=89756842


For details on the mass rebuild see:

https://fedoraproject.org/wiki/Fedora_37_Mass_Rebuild
Please fix barrier at your earliest convenience and set the bug's status to
ASSIGNED when you start fixing it. If the bug remains in NEW state for 8 weeks,
barrier will be orphaned. Before branching of Fedora 38,
barrier will be retired, if it still fails to build.

For more details on the FTBFS policy, please visit:
https://docs.fedoraproject.org/en-US/fesco/Fails_to_build_from_source_Fails_to_install/

Comment 1 Fedora Release Engineering 2022-08-01 23:16:56 UTC
Created attachment 1900801 [details]
build.log

Comment 2 Fedora Release Engineering 2022-08-01 23:16:58 UTC
Created attachment 1900802 [details]
root.log

file root.log too big, will only attach last 32768 bytes

Comment 3 Fedora Release Engineering 2022-08-01 23:16:59 UTC
Created attachment 1900803 [details]
state.log

Comment 4 Ben Cotton 2022-08-09 13:24:02 UTC
This bug appears to have been reported against 'rawhide' during the Fedora Linux 37 development cycle.
Changing version to 37.

Comment 5 Ben Beasley 2023-01-25 21:09:53 UTC
It seems like the current Rawhide spec file could build cleanly on F37. It would be good to 

There are now some issues with missing #include directives on GCC 13 in Rawhide/F38, however.

> In file included from /builddir/build/BUILD/barrier-2.4.0/src/lib/base/XBase.cpp:20:
> /builddir/build/BUILD/barrier-2.4.0/src/./lib/base/String.h:78:43: error: 'uint8_t' is not a member of 'std'; did you mean 'wint_t'?
>    78 | std::string to_hex(const std::vector<std::uint8_t>& subject, int width, const char fill = '0');
>       |                                           ^~~~~~~
>       |                                           wint_t

Comment 6 Ali Erdinc Koroglu 2023-01-26 01:05:05 UTC
Hello Ben, I'm working on input-leap, saw the same thing and just patched like this.


--- a/src/lib/base/String.h 2023-01-24 11:17:58.283346928 +0200
+++ b/src/lib/base/String.h 2023-01-24 11:18:53.431138140 +0200
@@ -18,6 +18,7 @@

 #pragma once

+#include <cstdint>
 #include "common/common.h"
 #include "common/stdstring.h"

--- a/src/lib/net/FingerprintData.h 2023-01-24 11:28:51.249875874 +0200
+++ b/src/lib/net/FingerprintData.h 2023-01-24 11:29:15.818782944 +0200
@@ -18,6 +18,7 @@
 #ifndef BARRIER_LIB_NET_FINGERPRINT_DATA_H
 #define BARRIER_LIB_NET_FINGERPRINT_DATA_H

+#include <cstdint>
 #include <string>
 #include <vector>

Comment 7 Ben Beasley 2023-01-26 01:12:04 UTC
I agree, that’s the kind of thing I expected would be needed here.

I’m actually looking for packages that might have been broken by gtest 1.13.0, which has led me to file or comment on a number of these GCC 13 bugs, but I haven’t had enough time to jump in and patch them all even though the individual fixes tend to be straightforward.

Comment 9 Fedora Update System 2023-01-26 15:04:49 UTC
FEDORA-2023-936f1849dd has been submitted as an update to Fedora 38. https://bodhi.fedoraproject.org/updates/FEDORA-2023-936f1849dd

Comment 10 Fedora Update System 2023-01-26 15:09:15 UTC
FEDORA-2023-936f1849dd has been pushed to the Fedora 38 stable repository.
If problem still persists, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.